From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Daniel Golle <daniel@makrotopia.org>,
devicetree@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
Olivia Mackall <olivia@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Conor Dooley <conor.dooley@microchip.com>,
Mingming Su <Mingming.Su@mediatek.com>,
linux-crypto@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: rng: Add MediaTek MT7981 TRNG
Date: Thu, 16 Feb 2023 10:14:33 +0100 [thread overview]
Message-ID: <5341d0fa-1415-b711-30f0-f0a867af0bc4@linaro.org> (raw)
In-Reply-To: <c750e786ad0f529d2ae63c8f766d3c294808ff53.1676467500.git.daniel@makrotopia.org>
On 15/02/2023 14:27, Daniel Golle wrote:
> Add documentation to describe the MediaTek true random number generator
> which is provided by ARM TrustedFirmware-A of the MT7981.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../bindings/rng/mediatek,mt7981-rng.yaml | 39 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rng/mediatek,mt7981-rng.yaml
>
> diff --git a/Documentation/devicetree/bindings/rng/mediatek,mt7981-rng.yaml b/Documentation/devicetree/bindings/rng/mediatek,mt7981-rng.yaml
> new file mode 100644
> index 000000000000..d577d60538d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rng/mediatek,mt7981-rng.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rng/mediatek,mt7981-rng.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek Random number generator (v2/SMC)
> +
> +maintainers:
> + - Daniel Golle <daniel@makrotopia.org>
> +
> +properties:
> + $nodename:
> + pattern: "^rng$"
1. We don't enforce it in device bindings, so drop it.
2. It's not even correct. You have reg.
> +
> + compatible:
> + enum:
> + - mediatek,mt7981-rng
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: rng
Drop clock-names and rely on index.
> +
> +required:
> + - compatible
and reg?
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + rng {
> + compatible = "mediatek,mt7981-rng";
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-16 9:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 13:27 [PATCH 1/2] hwrng: add driver for MediaTek TRNG SMC Daniel Golle
2023-02-15 13:27 ` [PATCH 2/2] dt-bindings: rng: Add MediaTek MT7981 TRNG Daniel Golle
2023-02-16 9:14 ` Krzysztof Kozlowski [this message]
2023-02-16 9:19 ` Daniel Golle
2023-02-16 10:03 ` [PATCH 1/2] hwrng: add driver for MediaTek TRNG SMC AngeloGioacchino Del Regno
2023-02-16 11:32 ` Matthias Brugger
2023-02-20 23:58 ` Rob Herring
2023-02-21 0:14 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5341d0fa-1415-b711-30f0-f0a867af0bc4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Mingming.Su@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor.dooley@microchip.com \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=olivia@selenic.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).