From: "Pablo Sebastián Greco" <pgreco@centosproject.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Ryder Lee <ryder.lee@mediatek.com>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, Roy Luo <royluo@google.com>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Kalle Valo <kvalo@codeaurora.org>, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH v1] mt76: mt7615: Fix build with older compilers
Date: Mon, 2 Dec 2019 07:30:15 -0300 [thread overview]
Message-ID: <5e12af27-be82-894a-1abd-25d1f33a5144@centosproject.org> (raw)
In-Reply-To: <e18d798d-cdf3-da05-c139-403dfc80e8a3@cogentembedded.com>
On 2/12/19 06:18, Sergei Shtylyov wrote:
> Hello!
>
> On 01.12.2019 21:17, Pablo Greco wrote:
>
>> Some compilers (tested with 4.8.5 from CentOS 7) fail properly process
>
> Fail to?
Right
>
>> FIELD_GET inside an inline function, which ends up in a BUILD_BUG_ON.
>> Convert inline function to a macro.
>>
>> Fixes commit bf92e7685100 ("mt76: mt7615: add support for per-chain
>> signal strength reporting")
>
> Should be:
>
> Fixes: bf92e7685100 ("mt76: mt7615: add support for per-chain signal
> strength reporting")
>
> Do not ever break up the Fixes: line and don't insert empty lines
> between it and other tags.
Ack, I'll fix those for v2
>
>> Reported in https://lkml.org/lkml/2019/9/21/146
>>
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
> [...]
>
> MBR, Sergei
Thanks, Pablo
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2019-12-02 10:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-01 18:17 [PATCH v1] mt76: mt7615: Fix build with older compilers Pablo Greco
2019-12-02 9:18 ` Sergei Shtylyov
2019-12-02 10:30 ` Pablo Sebastián Greco [this message]
2019-12-02 9:25 ` Kalle Valo
[not found] ` <0101016ec5ed7d91-eac61501-1e4a-42f1-881d-cc2c02eb8372-000000@us-west-2.amazonses.com>
2019-12-02 10:42 ` Pablo Sebastián Greco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e12af27-be82-894a-1abd-25d1f33a5144@centosproject.org \
--to=pgreco@centosproject.org \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=royluo@google.com \
--cc=ryder.lee@mediatek.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).