From: Lukasz Luba <lukasz.luba@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-imx@nxp.com
Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org,
viresh.kumar@linaro.org, liviu.dudau@arm.com,
bjorn.andersson@linaro.org, bsegall@google.com,
festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org,
amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com,
vincent.guittot@linaro.org, khilman@kernel.org,
daniel.lezcano@linaro.org, steven.price@arm.com,
cw00.choi@samsung.com, mingo@redhat.com, mgorman@suse.de,
rui.zhang@intel.com, alyssa.rosenzweig@collabora.com,
daniel@ffwll.ch, b.zolnierkie@samsung.com,
s.hauer@pengutronix.de, rostedt@goodmis.org,
matthias.bgg@gmail.com, Chris.Redpath@arm.com, airlied@linux.ie,
javi.merino@arm.com, tomeu.vizoso@collabora.com,
qperret@google.com, sboyd@kernel.org, shawnguo@kernel.org,
rjw@rjwysocki.net, agross@kernel.org, kernel@pengutronix.de,
sudeep.holla@arm.com, patrick.bellasi@matbug.net,
ionela.voinescu@arm.com
Subject: Re: [PATCH v2 1/4] PM / EM: add devices to Energy Model
Date: Thu, 13 Feb 2020 15:25:11 +0000 [thread overview]
Message-ID: <6b1921bb-42c8-999f-abfa-5682e73015d5@arm.com> (raw)
In-Reply-To: <62a54ec9-0491-367d-0a36-7ea32c449acc@arm.com>
On 2/13/20 10:59 AM, Dietmar Eggemann wrote:
> On 06/02/2020 14:46, lukasz.luba@arm.com wrote:
>> From: Lukasz Luba <lukasz.luba@arm.com>
>
> [..]
>
>> @@ -26,7 +28,7 @@ framework, and interested clients reading the data from it::
>
> s/::/: ?
>
>> | Thermal (IPA) | | Scheduler (EAS) | | Other |
>> +---------------+ +-----------------+ +---------------+
>> | | em_pd_energy() |
>> - | | em_cpu_get() |
>> + | em_get_pd() | em_cpu_get() |
>> +---------+ | +---------+
>
> em_get_pd() and em_cpu_get()? Why not em_pd_get()? em_cpu_get() is a
> specific em_get_pd(). right?
Yes. I will rename 'em_get_pd' to 'em_pd_get'
>
> [...]
>
>> @@ -85,13 +89,20 @@ API.
>> 2.3 Accessing performance domains
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> +There is two API functions which provide the access to the energy model:
>> +em_cpu_get() which takes CPU id as an argument and em_get_pd() with device
>> +pointer as an argument. It depends on the subsystem which interface it is
>> +going to use, but in case of CPU devices both functions return the same
>> +performance domain.
>
> There is probably a reason why we need this specific function for CPU
> devices? The reason should be described. People might ask why
> em_get_pd() is not sufficient.
True, good point. I will extend the comment in em_cpu_get().
>
> [...]
>
>> - * A "performance domain" represents a group of CPUs whose performance is
>> - * scaled together. All CPUs of a performance domain must have the same
>> - * micro-architecture. Performance domains often have a 1-to-1 mapping with
>> - * CPUFreq policies.
>> + * In case of CPU device, a "performance domain" represents a group of CPUs
>> + * whose performance is scaled together. All CPUs of a performance domain
>> + * must have the same micro-architecture. Performance domains often have
>> + * a 1-to-1 mapping with CPUFreq policies.
>> + * In case of other devices the 'priv' field is unused.
>> */
>> struct em_perf_domain {
>> - struct em_cap_state *table;
>> - int nr_cap_states;
>> - unsigned long cpus[0];
>> + struct em_perf_state *table;
>> + int nr_perf_states;
>> + void *priv;
>
> In case you go back to the variable length field plus type field to
> distingush EM devices, keep cpus[0] as the name.
OK, I will.
>
> [..]
>
>> /**
>> - * em_pd_energy() - Estimates the energy consumed by the CPUs of a perf. domain
>> + * em_pd_energy() - Estimates the energy consumed by the CPUs of a perf.
>> + domain
>
> Why this change?
hmmm, that's odd, maybe there was 'device' then I changed it back to
'CPUs' but forgot to move the 'domain' to the old place.
>
> [...]
>
>> @@ -141,12 +210,12 @@ static struct em_perf_domain *em_create_pd(cpumask_t *span, int nr_states,
>> */
>> opp_eff = freq / power;
>> if (opp_eff >= prev_opp_eff)
>> - pr_warn("pd%d: hertz/watts ratio non-monotonically decreasing: em_cap_state %d >= em_cap_state%d\n",
>> - cpu, i, i - 1);
>> + dev_warn(dev, "energy_model: hertz/watts ratio non-monotonically decreasing: em_perf_state %d >= em_perf_state%d\n",
>
> s/energy_model/EM ?
OK, I will rename them in all places.
Thank you for the review.
Regards,
Lukasz
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-02-13 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 13:46 [PATCH v2 0/4] Add support for devices in the Energy Model lukasz.luba
2020-02-06 13:46 ` [PATCH v2 1/4] PM / EM: add devices to " lukasz.luba
2020-02-07 12:04 ` Quentin Perret
2020-02-07 15:59 ` Lukasz Luba
2020-02-13 10:59 ` Dietmar Eggemann
2020-02-13 15:25 ` Lukasz Luba [this message]
2020-02-06 13:46 ` [PATCH v2 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() lukasz.luba
2020-02-06 13:46 ` [PATCH v2 3/4] thermal: devfreq_cooling: Refactor code and switch to use Energy Model lukasz.luba
2020-02-08 9:51 ` kbuild test robot
2020-02-08 10:39 ` kbuild test robot
2020-02-06 13:46 ` [PATCH v2 4/4] drm/panfrost: Register to the Energy Model with devfreq device lukasz.luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b1921bb-42c8-999f-abfa-5682e73015d5@arm.com \
--to=lukasz.luba@arm.com \
--cc=Chris.Redpath@arm.com \
--cc=Morten.Rasmussen@arm.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=amit.kucheria@verdurent.com \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=bsegall@google.com \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dietmar.eggemann@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kernel@pengutronix.de \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=nm@ti.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).