From: Ryder Lee <ryder.lee@mediatek.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>, Bo Jiao <bo.jiao@mediatek.com>
Cc: Felix Fietkau <nbd@nbd.name>,
linux-wireless <linux-wireless@vger.kernel.org>,
Xing Song <xing.song@mediatek.com>,
"Sujuan Chen" <sujuan.chen@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
Evelyn Tsai <evelyn.tsai@mediatek.com>,
linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 1/1] mt76: add mt7916 to set wlan_idx_hi
Date: Fri, 24 Dec 2021 07:50:36 +0800 [thread overview]
Message-ID: <6d3a52918457d4fedf91a6a224cf35eaf940f22c.camel@mediatek.com> (raw)
In-Reply-To: <YcTwP6Hu5VoTMHEq@lore-desk>
On Thu, 2021-12-23 at 22:55 +0100, Lorenzo Bianconi wrote:
> > From: Bo Jiao <Bo.Jiao@mediatek.com>
> >
> > since mt7916 support up to 544 wcid entries,
> > add it to set wlan_idx_hi.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > Signed-off-by: Bo Jiao <Bo.Jiao@mediatek.com>
> > ---
> > drivers/net/wireless/mediatek/mt76/mt76_connac.h | 5 +++++
> > drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 +-
> > 2 files changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac.h
> > b/drivers/net/wireless/mediatek/mt76/mt76_connac.h
> > index e999d71..8701f04 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76_connac.h
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac.h
> > @@ -110,6 +110,11 @@ static inline bool is_mt7915(struct mt76_dev
> > *dev)
> > return mt76_chip(dev) == 0x7915;
> > }
> >
> > +static inline bool is_mt7916(struct mt76_dev *dev)
> > +{
> > + return mt76_chip(dev) == 0x7906;
> > +}
> > +
> > static inline u8 mt76_connac_chan_bw(struct cfg80211_chan_def
> > *chandef)
> > {
> > static const u8 width_to_bw[] = {
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > index edad583..fc9a084 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > @@ -1464,7 +1464,7 @@ mt76_connac_mcu_get_wlan_idx(struct mt76_dev
> > *dev, struct mt76_wcid *wcid,
> > {
> > *wlan_idx_hi = 0;
> >
> > - if (is_mt7921(dev) || is_mt7915(dev)) {
> > + if (is_mt7921(dev) || is_mt7915(dev) || is_mt7916(dev)) {
> > *wlan_idx_lo = wcid ? to_wcid_lo(wcid->idx) : 0;
> > *wlan_idx_hi = wcid ? to_wcid_hi(wcid->idx) : 0;
>
> I guess I have already included the fix here:
>
https://patchwork.kernel.org/project/linux-wireless/patch/df4d462f1ef4cfc1ae4f6482051a28a10c78262b.1640260901.git.lorenzo@kernel.org/
>
> Regards,
> Lorenzo
>
I think we can fold these patches together and use !is_connac_v1
instead so that we can avoid endless is_mtxxxx || ... || ...
Ryder
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-12-23 23:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1640175865.git.Bo.Jiao@mediatek.com>
2021-12-22 12:29 ` [PATCH 1/1] mt76: add mt7916 to set wlan_idx_hi Bo Jiao
2021-12-23 21:55 ` Lorenzo Bianconi
2021-12-23 23:50 ` Ryder Lee [this message]
2021-12-24 9:30 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d3a52918457d4fedf91a6a224cf35eaf940f22c.camel@mediatek.com \
--to=ryder.lee@mediatek.com \
--cc=bo.jiao@mediatek.com \
--cc=evelyn.tsai@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=shayne.chen@mediatek.com \
--cc=sujuan.chen@mediatek.com \
--cc=xing.song@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).