From: Matthias Brugger <mbrugger@suse.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
mark.rutland@arm.com, ck.hu@mediatek.com, sboyd@kernel.org,
ulrich.hecht+renesas@gmail.com
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
drinkcat@chromium.org,
Michael Turquette <mturquette@baylibre.com>,
matthias.bgg@kernel.org, linux-kernel@vger.kernel.org,
Richard Fontana <rfontana@redhat.com>,
linux-mediatek@lists.infradead.org,
Allison Randal <allison@lohutok.net>,
hsinyi@chromium.org, matthias.bgg@gmail.com,
Thomas Gleixner <tglx@linutronix.de>,
Collabora Kernel ML <kernel@collabora.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] clk / soc: mediatek: Bind clock and gpu driver for mt2701
Date: Mon, 6 Apr 2020 11:27:08 +0200 [thread overview]
Message-ID: <718ec9a7-1a3c-4233-cdd1-b243874b37d5@suse.com> (raw)
In-Reply-To: <20200401201736.2980433-3-enric.balletbo@collabora.com>
Hi Stephen,
On 01/04/2020 22:17, Enric Balletbo i Serra wrote:
> Now that the mmsys driver is the top-level entry point for the
> multimedia subsystem, we could bind the clock and the gpu driver on
> those devices that is expected to work, so the drm driver is
> intantiated by the mmsys driver and display, hopefully, working again.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
I'm happy to take this through my tree if you provide a Acked-by/Reviewed-by
Sounds good to you?
Regards,
Matthias
> ---
> If you have this hardware, please kindly provide your tested tag. Only
> build tested.
>
> Changes in v2:
> - Remove of_match_table
>
> drivers/clk/mediatek/clk-mt2701-mm.c | 9 ++-------
> drivers/soc/mediatek/mtk-mmsys.c | 8 ++++++++
> 2 files changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/clk/mediatek/clk-mt2701-mm.c b/drivers/clk/mediatek/clk-mt2701-mm.c
> index 054b597d4a73..cb18e1849492 100644
> --- a/drivers/clk/mediatek/clk-mt2701-mm.c
> +++ b/drivers/clk/mediatek/clk-mt2701-mm.c
> @@ -79,16 +79,12 @@ static const struct mtk_gate mm_clks[] = {
> GATE_DISP1(CLK_MM_TVE_FMM, "mm_tve_fmm", "mm_sel", 14),
> };
>
> -static const struct of_device_id of_match_clk_mt2701_mm[] = {
> - { .compatible = "mediatek,mt2701-mmsys", },
> - {}
> -};
> -
> static int clk_mt2701_mm_probe(struct platform_device *pdev)
> {
> + struct device *dev = &pdev->dev;
> + struct device_node *node = dev->parent->of_node;
> struct clk_onecell_data *clk_data;
> int r;
> - struct device_node *node = pdev->dev.of_node;
>
> clk_data = mtk_alloc_clk_data(CLK_MM_NR);
>
> @@ -108,7 +104,6 @@ static struct platform_driver clk_mt2701_mm_drv = {
> .probe = clk_mt2701_mm_probe,
> .driver = {
> .name = "clk-mt2701-mm",
> - .of_match_table = of_match_clk_mt2701_mm,
> },
> };
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index c7d3b7bcfa32..cacafe23c823 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -80,6 +80,10 @@ struct mtk_mmsys_driver_data {
> const char *clk_driver;
> };
>
> +static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
> + .clk_driver = "clk-mt2701-mm",
> +};
> +
> static const struct mtk_mmsys_driver_data mt2712_mmsys_driver_data = {
> .clk_driver = "clk-mt2712-mm",
> };
> @@ -323,6 +327,10 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
> }
>
> static const struct of_device_id of_match_mtk_mmsys[] = {
> + {
> + .compatible = "mediatek,mt2701-mmsys",
> + .data = &mt2701_mmsys_driver_data,
> + },
> {
> .compatible = "mediatek,mt2712-mmsys",
> .data = &mt2712_mmsys_driver_data,
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-04-06 9:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 20:17 [PATCH v2 1/4] soc: mediatek: Enable mmsys driver by default if Mediatek arch is selected Enric Balletbo i Serra
2020-04-01 20:17 ` [PATCH v2 2/4] clk / soc: mediatek: Bind clock and gpu driver for mt2712 Enric Balletbo i Serra
2020-04-06 9:26 ` Matthias Brugger
2020-05-20 10:13 ` Stephen Boyd
2020-05-20 10:51 ` Matthias Brugger
2020-04-01 20:17 ` [PATCH v2 3/4] clk / soc: mediatek: Bind clock and gpu driver for mt2701 Enric Balletbo i Serra
2020-04-06 9:27 ` Matthias Brugger [this message]
2020-05-20 10:13 ` Stephen Boyd
2020-05-20 10:51 ` Matthias Brugger
2020-04-01 20:17 ` [PATCH v2 4/4] arm64: dts: mt8173: Fix mmsys node name Enric Balletbo i Serra
2020-05-20 10:52 ` Matthias Brugger
2020-05-13 4:49 ` [PATCH v2 1/4] soc: mediatek: Enable mmsys driver by default if Mediatek arch is selected Hsin-Yi Wang
2020-05-20 10:51 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=718ec9a7-1a3c-4233-cdd1-b243874b37d5@suse.com \
--to=mbrugger@suse.com \
--cc=allison@lohutok.net \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=kernel@collabora.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rfontana@redhat.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).