From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1CCDC433E7 for ; Tue, 13 Oct 2020 10:36:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 712F420870 for ; Tue, 13 Oct 2020 10:36:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PIt7rqLK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rrHdIIkH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 712F420870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NXYjBG7LXq92EY0TBmbywOY56Xokxbfy9H1UhbhLJVs=; b=PIt7rqLKAYSxm4nAc+GS6bvXg U/ePoNet7LCSWf1MMs6BPWQ9+nCa72P0zSAcZEIrHGlpRZ7wfOIiz/q3odmGVZOc+UuXqaNqCpsrQ ATr1gMBYW/pcwWbDSJwIdc+JL/s/knSs8b8+vSBzAUNbaKitLnnU0mPIv6jF/gf9tBHEs5fXIIDwM yc7DOgWlDOI0Y5COLN1YCche7+qKfNuID11d8dJXoa5eo2TLCGv4Om0q/vn3i2T5AsmjlEcsh29UY N8VlRQUhu4mCKjxEL5FA0uVwbDUqD3zKGSYYQWpnQqk8zlRua4BFRO9fp+OOzewigKGMEPmAEHuKl pCvUQJrzw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSHfh-0004mv-Mr; Tue, 13 Oct 2020 10:36:45 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSHfb-0004jZ-9k for linux-mediatek@lists.infradead.org; Tue, 13 Oct 2020 10:36:40 +0000 Received: by mail-wm1-x32f.google.com with SMTP id d81so20428519wmc.1 for ; Tue, 13 Oct 2020 03:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CiWCv3BMnudQFt/Kh0EA1mCHFgkrHwPIFYjOeIiiAgM=; b=rrHdIIkHJ4RWluKR74GDVBCXZ3fHa+2GckpSDJAnPQr3LIihHVRnyUP0B3Pyy3ZhiX 8rSJA7CHd4bBwm+paLicw3yVKCUd7p47cqxTVZOMI8KQTToQQIRbcEkKYaCAJv5rCfEc 1bgA/vc4KEWcOYZ4uNSULZ7vzptJAjV8I6Yt5FQdZdfVDCfUWFaaYLymlxMbvCLnuB5g k4Q1OxKAiRD5UMQFq/jNfia58Icqaqxjn9Zw637CxWxICuvMpdldIxOsG31VbTFTfcjx fcwjAwQt64YG5s9nbZkfQG7kDKS53uzrSfQJevNyaAgzQJP/OvC7fnfI1m0PztItBYpx 0bKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CiWCv3BMnudQFt/Kh0EA1mCHFgkrHwPIFYjOeIiiAgM=; b=g85hb8vR813ZVrZ5ffWBcDBB03GK3K8BvPxUlAY8OFGbf3ie8TsrIyJ93ZVl3CyVz9 H3Gk3fSqhqGqsaubxhjnqa/G/hiNvBb8NBVfHfM6Dthr0YO/4VLbm+NbILf8QXzZa/39 DA9oXVsOYbFYKEJn9hauneHASMF0rFnKhLzBYlHIifWb3PPzRsIj9uLdOjKXIKMgiIeD 6Z42kVGm5XLb2jr58VDCFrLmuybsbiSd6VNAk1sLdeeIzjJHROdE/rcAun8Ibcx+4LUj QXx41b0PtqgE1qoNSI3+5vDMKq5gb1I/6Mk5c9lnqiio1xQ6ETdKGOhVnsdtmdjtkfvz DwrA== X-Gm-Message-State: AOAM531YF9E0/Jar0A6zrvhN3r/D3lEAZJacHZKzdeO3ZJkJ68ovn7JH vJQTZc3WE09hXIrA5TVRoPlq2A== X-Google-Smtp-Source: ABdhPJxiYcDKpnTqq5SWY21dPvFP7GNAu3f5Em/slUL6EOVBNEG9+t+pGtCNV4M0EgkRnYKNBcGB0w== X-Received: by 2002:a1c:1905:: with SMTP id 5mr15466149wmz.32.1602585396171; Tue, 13 Oct 2020 03:36:36 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id t6sm31809439wre.30.2020.10.13.03.36.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Oct 2020 03:36:35 -0700 (PDT) Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Cheng-Yi Chiang , linux-kernel@vger.kernel.org References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> From: Srinivas Kandagatla Message-ID: <7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org> Date: Tue, 13 Oct 2020 11:36:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200914080619.4178587-3-cychiang@chromium.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201013_063639_398419_212190F5 X-CRM114-Status: GOOD ( 14.88 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taniya Das , alsa-devel@alsa-project.org, Banajit Goswami , Heiko Stuebner , Liam Girdwood , Rohit kumar , Patrick Lai , linux-rockchip@lists.infradead.org, Andy Gross , dgreid@chromium.org, Jaroslav Kysela , devicetree@vger.kernel.org, tzungbi@chromium.org, Srinivasa Rao , Stephan Gerhold , linux-arm-msm@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, dianders@chromium.org, Takashi Iwai , Mark Brown Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Cheng, Sorry for such late review w.r.t compatibles, On 14/09/2020 09:06, Cheng-Yi Chiang wrote: > +--- > +$id:http://devicetree.org/schemas/sound/qcom,sc7180.yaml# > +$schema:http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies Inc. SC7180 ASoC sound card driver > + > +maintainers: > + - Rohit kumar > + - Cheng-Yi Chiang > + > +description: > + This binding describes the SC7180 sound card which uses LPASS for audio. > + > +properties: > + compatible: > + const: qcom,sc7180-sndcard-rt5682-m98357-1mic This information can come from the dai link description itself, why should compatible string have this information? Can't we have better compatible string with actual board name or use the same compatible name as used by other boards? Can you give us some details on the advantages of doing this way? Or am I missing something? AFAIU, you should add proper board name / model name to the compatible string rather than describe how its connected. Connection is already part of dai link definition. On the other hand model property can include variant information. This can also be used to set card long name which will help in UCM2. The reason I had to bring this up is because the use-space (ucm in this case) will not be in a position to differentiate between different board variants to select correct mixer controls, so its going to be a pain! Thanks, srini _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek