From: "Sam Shih (史碩三)" <Sam.Shih@mediatek.com>
To: "daniel@makrotopia.org" <daniel@makrotopia.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>
Cc: "robh@kernel.org" <robh@kernel.org>,
"sean.wang@kernel.org" <sean.wang@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH 1/2] pinctrl: mediatek: fix pull_type data for MT7981
Date: Mon, 21 Aug 2023 14:18:05 +0000 [thread overview]
Message-ID: <7f25a5a59b790c6988ed54003230ccab2b941675.camel@mediatek.com> (raw)
In-Reply-To: <CACRpkdYpLkPp0-3rT5xxbzO9Lf35020Aid7QX6iqZGaW3C5x0g@mail.gmail.com>
On Mon, 2023-08-21 at 12:40 +0200, Linus Walleij wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On Fri, Aug 18, 2023 at 5:02 AM Daniel Golle <daniel@makrotopia.org>
> wrote:
>
> > MediaTek has released pull_type data for MT7981 in their SDK.
> > Use it and set functions to configure pin bias.
> >
> > Fixes: 6c83b2d94fcc ("pinctrl: add mt7981 pinctrl driver")
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
>
> This looks pretty urgent but I applied it for v6.6 (non-urgent)
> for now so we get some testing in linux-next.
>
The MediaTek MT7981 SoC only has pin0 to pin56 which defined in
'mt7981_pins', This patch removes the non-existent pin57 to pin100 and
fixes the pull type for pins 40 through 56.
The driver can still work due to the pin numbers of MT7981 is defined
by ARRAY_SIZE(mt7981_pins), and the default hardware configuration for
pins 40 through 56 can work correctly without advanced adjustments,
However, without this patch, attempts to use pinconf to configure pins
40 through 56 result in a "-EINVAL" error.
Acked-by: Sam Shih <sam.shih@mediatek.com>
Best Regards,
Sam
prev parent reply other threads:[~2023-08-21 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 3:02 [PATCH 1/2] pinctrl: mediatek: fix pull_type data for MT7981 Daniel Golle
2023-08-18 3:03 ` [PATCH 2/2] pinctrl: mediatek: assign functions to configure pin bias on MT7986 Daniel Golle
2023-08-21 10:40 ` [PATCH 1/2] pinctrl: mediatek: fix pull_type data for MT7981 Linus Walleij
2023-08-21 14:18 ` Sam Shih (史碩三) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f25a5a59b790c6988ed54003230ccab2b941675.camel@mediatek.com \
--to=sam.shih@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sean.wang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).