From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96643C2BA83 for ; Fri, 14 Feb 2020 11:14:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6262A2082F for ; Fri, 14 Feb 2020 11:14:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uicsctNc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6262A2082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BPsU35Bh7vRWoZKsdr9HMFfQgLQ5N5Uf1yFx4CH/e0M=; b=uicsctNclPRClp UBxkXYjGMLJzgjmJreAEtuO//Z0IEQXbHn6dfLYhaBxYZ+/fMg3ymLxzDChDDA9mWHin4AQL0rGKH tnXm5ONQSLO1lvoOHWiGXBzeFgdSQPKuxI6hzjLXYGAXqqawRCi/oXFnoDUHUIMtyMeRMOYBjX7se XNTNogY8W8Ygi2fZRI8CszHy6LYrEqDfVuBkdDr/oZjoe9cOwIa66jQC4IQ1cZZwF/c40uPfNlvYS zfXSZP3QpJTN7gg8N6FMg0nug3+bq6s/KGkEhUe/XJux468FP85OfspVDcwDf/IeVA8gpVzCHsON3 yWUig0+eRcu5+qFY714w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2Yvp-0005MG-AY; Fri, 14 Feb 2020 11:14:49 +0000 Received: from mailgate1.rohmeurope.com ([178.15.145.194]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2Yvd-0005C2-P0; Fri, 14 Feb 2020 11:14:39 +0000 X-AuditID: c0a8fbf4-279ff70000001e6c-6b-5e46811668cc Received: from smtp.reu.rohmeu.com (will-cas002.reu.rohmeu.com [192.168.251.178]) by mailgate1.rohmeurope.com (Symantec Messaging Gateway) with SMTP id E8.DD.07788.611864E5; Fri, 14 Feb 2020 12:14:30 +0100 (CET) Received: from WILL-MAIL002.REu.RohmEu.com ([fe80::e0c3:e88c:5f22:d174]) by WILL-CAS002.REu.RohmEu.com ([fe80::fc24:4cbc:e287:8659%12]) with mapi id 14.03.0439.000; Fri, 14 Feb 2020 12:14:18 +0100 From: "Vaittinen, Matti" To: "linus.walleij@linaro.org" Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION Thread-Topic: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION Thread-Index: AQHVmWQOgs5cHlsmlU+Vdtkf5ZbC06eIlAaAgAAGWoCAAC7LgICSQxwA Date: Fri, 14 Feb 2020 11:14:18 +0000 Message-ID: <81f96837457028ad9eeb690776526701d5b1bc8c.camel@fi.rohmeurope.com> References: <20191112141819.GA22076@localhost.localdomain> <201911131438.KT6pnFZ7%lkp@intel.com> In-Reply-To: Accept-Language: en-US, de-DE Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [213.255.186.46] Content-ID: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA02TbVBUVRzG59x3wK3LirvH9WXGJTNyhLS3Y2MmTsNcPqQ11ZQ2Qte4shDs 0t3FYWWKBVNml0xWmRrXRQmwmF23bDchDAZafFkjREGXzCiBJVhqlolphuFN2utN4dN97nme 5/87H/6HwZU3aA2TozcJop7P01KxRHvDjHeDqjQt46nhay+ga0MzBCqPfEmjb0OdAHX3+3Hk OXKJQJ1tEQK1l/YCNB25SKPqk8cAcjaY0fzgXyQqre8lUFdFEKCq2a8w5B0Kksje1kUj3+lZ gHovOCnUe/AGQJ1TbhydD0cwNHF3Hkf2O+doZAuGSDR2cJBCo54+EpV9/DRyngkQ6NSch0T+ T99BTb4vcOQM3ALoaF0PgYZP+CgUcYcAOv51OhqfSkVXAlYcTfm7sW3ruLLxyxQ3/sshmjt1 tphz/NFFce6ecoo7N+gmOXvXBq7Z0U9zdd42ijttncS4upYwxnldVoqztHcT3G/BFoqrOHmP 4Hz1Ja+qdsdt2cub9r+ek61P2fpunO7zpiqiYAIWNfzooS2gBtoAw0D2GVg5nW4DsYySvQVg 6w+1lPwTALDs9mVcClHsFmi7TdtADJPAboYdASchaZw9Fg/HOp6Q9FL2RXjncA8lxRPYrdD3 XZws02BgNlVKEOxaOH54lJS0gt0Bj3s/IWXSPwD2jQ4DyYhhX4ONTsv98YBdBa2WCCaj1ND7 5+T9MmRZWN/Sjct6GQwP3fv/XAtbpwYIiYuzSfCbCylydRv02PpoWa+BVRUDtHyHeHj1RIio BCrHIoJjoe1Y1HYsajsWtWsA6QIwn8/Jy+ZNwsZkUShMFg26/OjnPUO+F8gr+u/3YN6f7gcY A/xgOYNplyly9WkZykf2GrLMOt6oyxQL8wSjH0AG1yYoOtZEPUUWbz4giIYH1gqG0KoV6wbs e5SsxHpfEAoE8YG7kmG0UBH+KFqMF4VsoWhfTp5pwcaYGGl4rCbBKOizBJEvNOkypeXINEa3 Q7KWRLn2EolrLODzo6dy9SewnqkMV9fizMXqM7W4ktAb9IJGrVglRVkpqivUPwSNATUDtEsV v0vukug7fThnLIrAoogjSS9LCBO/YGkswK48NLFLNe2uefyVzPVUyvaiZnOr+9H03OXq7eII s69/9/Xnm38OWWcm9TtuXndcTYp8uHOzqzELuF6aeyN1V+Jnc40u/9ri4kuhTaXq54KJtl+5 mStv3ky0v/3B/rMlq1ePHD3wbKWTX/lW7t97mu42qEY0JebG5BXnNzU/llFuLN85pCWMOn7j k7ho5P8DL+cyqWQEAAA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_031437_960693_993A3A6B X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "andrew@lunn.ch" , "alexandre.belloni@bootlin.com" , "heiko@sntech.de" , "geert+renesas@glider.be" , "narmstrong@baylibre.com" , "patrice.chotard@st.com" , "paul@crapouillou.net" , "eric@anholt.net" , "linux-stm32@st-md-mailman.stormreply.com" , "jason@lakedaemon.net" , "f.fainelli@gmail.com" , "lkp@intel.com" , "gregory.clement@bootlin.com" , "ludovic.desroches@microchip.com" , "linux-rockchip@lists.infradead.org" , "wens@csie.org" , "agross@kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "rjui@broadcom.com" , "sebastian.hesselbarth@gmail.com" , "alexandre.torgue@st.com" , "mazziesaccount@gmail.com" , "linux-arm-msm@vger.kernel.org" , "nicolas.ferre@microchip.com" , "linux-gpio@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-rpi-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "bjorn.andersson@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "kbuild-all@lists.01.org" , "sbranden@broadcom.com" , "sean.wang@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "wahrenst@gmx.net" , "mcoquelin.stm32@gmail.com" , "linux-oxnas@groups.io" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi-deeee-Ho Peeps! On Wed, 2019-11-13 at 10:40 +0100, Linus Walleij wrote: > On Wed, Nov 13, 2019 at 7:52 AM Vaittinen, Matti > wrote: > > On Wed, 2019-11-13 at 14:30 +0800, kbuild test robot wrote: > > > Hi Matti, > > > > > > Thank you for the patch! Perhaps something to improve: > > > > > > [auto build test WARNING on > > > 70d97e099bb426ecb3ad4bf31e88dbf2ef4b2e4c] > > > > > > 480 static int wmt_gpio_get_direction(struct gpio_chip > > > *chip, unsigned offset) > > > 481 { > > > 482 struct wmt_pinctrl_data *data = > > > gpiochip_get_data(chip); > > > 483 u32 bank = WMT_BANK_FROM_PIN(offset); > > > 484 u32 bit = WMT_BIT_FROM_PIN(offset); > > > 485 u32 reg_dir = data->banks[bank].reg_dir; > > > 486 u32 val; > > > 487 > > > 488 val = readl_relaxed(data->base + reg_dir); > > > 489 if (val & BIT(bit)) > > > > 490 GPIO_LINE_DIRECTION_OUT; > > > > Right. Return is missing. I think I already fixed this - I guess I > > sent > > wrong version... Sorry guys. I'll do v3 with only this return added > > - > > and I'll send it to limited amount of recipients as I think most of > > you > > guys may not be interested. Probably to Linus W, Geert and GPIO > > list > > only. Let me know if you want to see the v3 (or other subsequent > > patches) I just noticed this was never merged even though I was sure I sent a fixed version. It took me a while but I guess I managed to dig out the reason... First I sent v2 with the return missing: https://lore.kernel.org/linux-gpio/20191112141819.GA22076@localhost.localdomain/ And then I did indeed send a fixed version: https://lore.kernel.org/linux-gpio/20191113071501.GA22158@localhost.localdomain/#Z30drivers:pinctrl:vt8500:pinctrl-wmt.c ...but titled this as v2 too. I guess that's why it never caught correct attention. I tried rebasing this to current gpio/devel. The pinctrl-ingenic.c had gained trivial conflict - do you want me to get the pinctrl tree and do merging on top of it && resending this or do you want to try applying it? Sorry for messing with the versions! Br, Matti Vaittinen _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek