From: "Maso Huang (黃加竹)" <Maso.Huang@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Trevor Wu (吳文良)" <Trevor.Wu@mediatek.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Allen-KH Cheng (程冠勳)" <Allen-KH.Cheng@mediatek.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"renzhijie2@huawei.com" <renzhijie2@huawei.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"Jiaxin Yu (俞家鑫)" <Jiaxin.Yu@mediatek.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v2 7/7] ASoC: dt-bindings: mediatek,mt7986-afe: add audio afe document
Date: Fri, 30 Jun 2023 02:26:47 +0000 [thread overview]
Message-ID: <864c525d8daa088e294018d0889cff6262218c72.camel@mediatek.com> (raw)
In-Reply-To: <20230629150528.GA2961718-robh@kernel.org>
On Thu, 2023-06-29 at 09:05 -0600, Rob Herring wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On Mon, Jun 26, 2023 at 10:35:01AM +0800, Maso Huang wrote:
> > Add mt7986 audio afe document.
> >
> > Signed-off-by: Maso Huang <maso.huang@mediatek.com>
> > ---
> > .../bindings/sound/mediatek,mt7986-afe.yaml | 89
> +++++++++++++++++++
> > 1 file changed, 89 insertions(+)
> > create mode 100644
> Documentation/devicetree/bindings/sound/mediatek,mt7986-afe.yaml
> >
> > diff --git
> a/Documentation/devicetree/bindings/sound/mediatek,mt7986-afe.yaml
> b/Documentation/devicetree/bindings/sound/mediatek,mt7986-afe.yaml
> > new file mode 100644
> > index 000000000000..257327a33ea1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt7986-
> afe.yaml
> > @@ -0,0 +1,89 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/mediatek,mt7986-afe.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek AFE PCM controller for MT7986
> > +
> > +maintainers:
> > + - Maso Huang <maso.huang@mediatek.com>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - const: mediatek,mt7986-afe
> > + - items:
> > + - enum:
> > + - mediatek,mt7981-afe
> > + - mediatek,mt7988-afe
> > + - const: mediatek,mt7986-afe
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + minItems: 5
> > + items:
> > + - description: audio bus clock
> > + - description: audio 26M clock
> > + - description: audio intbus clock
> > + - description: audio hopping clock
> > + - description: audio pll clock
> > + - description: mux for pcm_mck
> > + - description: audio i2s/pcm mck
> > +
> > + clock-names:
> > + minItems: 5
> > + items:
> > + - const: aud_bus_ck
> > + - const: aud_26m_ck
> > + - const: aud_l_ck
> > + - const: aud_aud_ck
> > + - const: aud_eg2_ck
> > + - const: aud_sel
> > + - const: aud_i2s_m
>
> 'aud_' is redundant.
>
Hi Rob,
Thanks for your review.
I'll refine as below in v3 patch.
items:
- const: bus_ck
- const: 26m_ck
- const: l_ck
- const: aud_ck
- const: eg2_ck
- const: sel
- const: i2s_m
And modify example as well.
Best regards,
Maso
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - clock-names
> > + - assigned-clocks
> > + - assigned-clock-parents
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/clock/mt7986-clk.h>
> > +
> > + afe@11210000 {
> > + compatible = "mediatek,mt7986-afe";
> > + reg = <0x11210000 0x9000>;
> > + interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&infracfg_ao CLK_INFRA_AUD_BUS_CK>,
> > + <&infracfg_ao CLK_INFRA_AUD_26M_CK>,
> > + <&infracfg_ao CLK_INFRA_AUD_L_CK>,
> > + <&infracfg_ao CLK_INFRA_AUD_AUD_CK>,
> > + <&infracfg_ao CLK_INFRA_AUD_EG2_CK>;
> > + clock-names = "aud_bus_ck",
> > + "aud_26m_ck",
> > + "aud_l_ck",
> > + "aud_aud_ck",
> > + "aud_eg2_ck";
> > + assigned-clocks = <&topckgen CLK_TOP_A1SYS_SEL>,
> > + <&topckgen CLK_TOP_AUD_L_SEL>,
> > + <&topckgen CLK_TOP_A_TUNER_SEL>;
> > + assigned-clock-parents = <&topckgen CLK_TOP_APLL2_D4>,
> > + <&apmixedsys CLK_APMIXED_APLL2>,
> > + <&topckgen CLK_TOP_APLL2_D4>;
> > + };
> > +
> > +...
> > --
> > 2.18.0
> >
next prev parent reply other threads:[~2023-06-30 2:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230626023501.11120-1-maso.huang@mediatek.com>
[not found] ` <20230626023501.11120-7-maso.huang@mediatek.com>
2023-06-29 14:58 ` [PATCH v2 6/7] ASoC: dt-bindings: mediatek,mt7986-wm8960: add mt7986-wm8960 document Rob Herring
2023-06-30 9:29 ` Maso Huang (黃加竹)
[not found] ` <20230626023501.11120-8-maso.huang@mediatek.com>
2023-06-29 15:05 ` [PATCH v2 7/7] ASoC: dt-bindings: mediatek,mt7986-afe: add audio afe document Rob Herring
2023-06-30 2:26 ` Maso Huang (黃加竹) [this message]
[not found] ` <20230626023501.11120-3-maso.huang@mediatek.com>
2023-07-04 8:53 ` [PATCH v2 2/7] ASoC: mediatek: mt7986: support audio clock control AngeloGioacchino Del Regno
2023-07-05 7:52 ` Maso Huang (黃加竹)
[not found] ` <20230626023501.11120-4-maso.huang@mediatek.com>
2023-07-04 8:58 ` [PATCH v2 3/7] ASoC: mediatek: mt7986: support etdm in platform driver AngeloGioacchino Del Regno
2023-07-05 7:57 ` Maso Huang (黃加竹)
[not found] ` <20230626023501.11120-2-maso.huang@mediatek.com>
2023-07-04 9:01 ` [PATCH v2 1/7] ASoC: mediatek: mt7986: add common header AngeloGioacchino Del Regno
2023-07-05 7:58 ` Maso Huang (黃加竹)
[not found] ` <20230626023501.11120-5-maso.huang@mediatek.com>
2023-07-04 9:13 ` [PATCH v2 4/7] ASoC: mediatek: mt7986: add platform driver AngeloGioacchino Del Regno
2023-07-05 8:03 ` Maso Huang (黃加竹)
2023-07-13 7:44 ` Maso Huang (黃加竹)
2023-07-24 6:17 ` [PATCH v2 0/7] ASoC: mediatek: Add support for MT7986 SoC Maso Huang (黃加竹)
2023-07-24 7:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864c525d8daa088e294018d0889cff6262218c72.camel@mediatek.com \
--to=maso.huang@mediatek.com \
--cc=Allen-KH.Cheng@mediatek.com \
--cc=Jiaxin.Yu@mediatek.com \
--cc=Trevor.Wu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=renzhijie2@huawei.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).