From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C642C433E0 for ; Fri, 31 Jul 2020 11:21:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB213208E4 for ; Fri, 31 Jul 2020 11:21:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l1fcZiPp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB213208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ki909IzgOEA7y+VElYr/6PiHBzeix0R3oGRX1YRAQVA=; b=l1fcZiPp+06kJzjiNSOMTEDM5 M8nT3GzDcn5+WgiEWi9Fip1R/wWTbCdCM9OeIfpj3tY+KIn+PvyLueKqyyUY3xigUHF9s2jX+zszm Wg0aaTQrt9Cg5MZuN0B4Q9rdXZZ91+WRPMyaFUcSTMO6/s2rkxf2+GA9cJ74nJWpAGBAcU7UbW+NI qeyCzmJ0wwPEJcOeY7JzhVzoxpUUmbCv8QiJLhWB/iVbDzH1ZAN0xGqSH3eb69jqAe786o3XnxAVt YK9QLM23ucISgaIql3YO6cf7t10+NSzg4deJoOUujdiBq1SFxWUvqOATHe5gQof9VkyRYFlo0mhp2 YnYzU+BpA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1T63-00059x-Ai; Fri, 31 Jul 2020 11:21:07 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1T5z-00058V-3s; Fri, 31 Jul 2020 11:21:03 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 6CC63299217 Subject: Re: [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property To: Hsin-Yi Wang , Matthias Brugger References: <20200727074124.3779237-1-hsinyi@chromium.org> From: Enric Balletbo i Serra Message-ID: <8aedcc7e-fea5-367c-e3a8-8a013cf629c1@collabora.com> Date: Fri, 31 Jul 2020 13:20:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200727074124.3779237-1-hsinyi@chromium.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_072103_258295_137FB35B X-CRM114-Status: GOOD ( 17.36 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Hsin-Yi, Thank you for your patch. On 27/7/20 9:41, Hsin-Yi Wang wrote: > bus-width and non-removable is not used by the driver. > max-frequency should be spi-max-frequency for flash node. > > Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board") > Reported-by: Nicolas Boichat > Signed-off-by: Hsin-Yi Wang Reviewed-by: Enric Balletbo i Serra > --- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > index a5a12b2599a4..01522dd10603 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > @@ -431,12 +431,11 @@ &nor_flash { > status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&nor_gpio1_pins>; > - bus-width = <8>; > - max-frequency = <50000000>; > - non-removable; > + > flash@0 { > compatible = "jedec,spi-nor"; > reg = <0>; > + spi-max-frequency = <50000000>; > }; > }; > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek