From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Devicetree List <devicetree@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
David Airlie <airlied@linux.ie>,
lkml <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Steven Price <steven.price@arm.com>,
Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches)
Date: Fri, 7 Feb 2020 09:13:37 +0100 [thread overview]
Message-ID: <93aec9ae-00fc-bf55-1d6c-9bd715b78344@collabora.com> (raw)
In-Reply-To: <CANMq1KCD1U7iym_fFWAd-Xa6ipxHmF_FAYxDL5WqGzDnA0KKLw@mail.gmail.com>
On 2/7/20 8:42 AM, Nicolas Boichat wrote:
> On Fri, Feb 7, 2020 at 2:18 PM Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
>>
>> On 2/7/20 6:26 AM, Nicolas Boichat wrote:
>>> Hi!
>>>
>>> Follow-up on the v3: https://patchwork.kernel.org/cover/11331343/.
>>>
>>> The main purpose of this series is to upstream the dts change and the
>>> binding document, but I wanted to see how far I could probe the GPU, to
>>> check that the binding is indeed correct. The rest of the patches are
>>> RFC/work-in-progress, but I think some of them could already be picked up.
>>>
>>> So this is tested on MT8183 with a chromeos-4.19 kernel, and a ton of
>>> backports to get the latest panfrost driver (I should probably try on
>>> linux-next at some point but this was the path of least resistance).
>>>
>>> I tested it as a module as it's more challenging (originally probing would
>>> work built-in, on boot, but not as a module, as I didn't have the power
>>> domain changes, and all power domains are on by default during boot).
>>>
>>> Probing logs looks like this, currently. They look sane.
>>> [ 501.319728] panfrost 13040000.gpu: clock rate = 511999970
>>> [ 501.320041] panfrost 13040000.gpu: Linked as a consumer to regulator.14
>>> [ 501.320102] panfrost 13040000.gpu: Linked as a consumer to regulator.31
>>> [ 501.320651] panfrost 13040000.gpu: Linked as a consumer to genpd:0:13040000.gpu
>>> [ 501.320954] panfrost 13040000.gpu: Linked as a consumer to genpd:1:13040000.gpu
>>> [ 501.321062] panfrost 13040000.gpu: Linked as a consumer to genpd:2:13040000.gpu
>>> [ 501.321734] panfrost 13040000.gpu: mali-g72 id 0x6221 major 0x0 minor 0x3 status 0x0
>>> [ 501.321741] panfrost 13040000.gpu: features: 00000000,13de77ff, issues: 00000000,00000400
>>> [ 501.321747] panfrost 13040000.gpu: Features: L2:0x07120206 Shader:0x00000000 Tiler:0x00000809 Mem:0x1 MMU:0x00002830 AS:0xff JS:0x7
>>> [ 501.321752] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1
>>> [ 501.324951] [drm] Initialized panfrost 1.1.0 20180908 for 13040000.gpu on minor 2
>>>
>>> Some more changes are still required to get devfreq working, and of course
>>> I do not have a userspace driver to test this with.
>>
>> Have you tried the Panfrost tests in IGT? They are atm quite basic, but
>> could be interesting to check that the different HW units are correctly
>> powered on.
>
> I haven't, you mean this right?
> https://gitlab.freedesktop.org/tomeu/igt-gpu-tools/tree/panfrost
Yes, though may be better to use the upstream repo:
https://gitlab.freedesktop.org/drm/igt-gpu-tools
> Any specific test you have in mind?
All the panfrost ones, but looks like panfrost_prime:gem-prime-import is
failing atm:
https://lava.collabora.co.uk/scheduler/job/2214987
Cheers,
Tomeu
> Thanks,
>
>> Regards,
>>
>> Tomeu
>>
>>> I believe at least patches 1, 2, and 3 can be merged. 4 and 5 are mostly
>>> useful in conjunction with 6 and 7 (which are not ready yet), so I'll let
>>> maintainers decide.
>>>
>>> Thanks!
>>>
>>> Nicolas Boichat (7):
>>> dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183
>>> arm64: dts: mt8183: Add node for the Mali GPU
>>> drm/panfrost: Improve error reporting in panfrost_gpu_power_on
>>> drm/panfrost: Add support for multiple regulators
>>> drm/panfrost: Add support for multiple power domains
>>> RFC: drm/panfrost: Add mt8183-mali compatible string
>>> RFC: drm/panfrost: devfreq: Add support for 2 regulators
>>>
>>> .../bindings/gpu/arm,mali-bifrost.yaml | 25 ++++
>>> arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 7 +
>>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 105 +++++++++++++++
>>> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 17 +++
>>> drivers/gpu/drm/panfrost/panfrost_device.c | 123 +++++++++++++++---
>>> drivers/gpu/drm/panfrost/panfrost_device.h | 27 +++-
>>> drivers/gpu/drm/panfrost/panfrost_drv.c | 41 ++++--
>>> drivers/gpu/drm/panfrost/panfrost_gpu.c | 11 +-
>>> 8 files changed, 326 insertions(+), 30 deletions(-)
>>>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-02-07 8:14 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 5:26 [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches) Nicolas Boichat
2020-02-07 5:26 ` [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 Nicolas Boichat
2020-02-25 17:16 ` Rob Herring
2020-02-26 0:55 ` Nicolas Boichat
2020-03-06 2:34 ` Nick Fan
2020-03-06 2:43 ` Nicolas Boichat
2020-03-06 14:13 ` Rob Herring
2020-03-06 14:43 ` Steven Price
2020-03-09 7:55 ` Nick Fan
2020-02-07 5:26 ` [PATCH v4 2/7] arm64: dts: mt8183: Add node for the Mali GPU Nicolas Boichat
2020-02-07 5:26 ` [PATCH v4 3/7] drm/panfrost: Improve error reporting in panfrost_gpu_power_on Nicolas Boichat
2020-02-12 10:38 ` Matthias Brugger
2020-02-07 5:26 ` [PATCH v4 4/7] drm/panfrost: Add support for multiple regulators Nicolas Boichat
2020-02-10 11:31 ` Steven Price
2020-02-10 14:00 ` Mark Brown
2020-02-07 5:26 ` [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains Nicolas Boichat
2020-02-07 13:52 ` Alyssa Rosenzweig
2020-02-09 12:43 ` Nicolas Boichat
2020-02-07 14:25 ` Ulf Hansson
2020-02-09 12:50 ` Nicolas Boichat
2020-02-10 7:50 ` Ulf Hansson
2020-02-10 11:39 ` Steven Price
2020-02-11 19:43 ` Rob Herring
2020-02-11 20:08 ` Saravana Kannan
2020-02-12 1:58 ` Rob Herring
2020-02-12 2:10 ` Saravana Kannan
2020-02-12 2:08 ` Nicolas Boichat
2020-02-07 5:26 ` [PATCH v4 6/7] RFC: drm/panfrost: Add mt8183-mali compatible string Nicolas Boichat
2020-02-07 5:26 ` [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators Nicolas Boichat
2020-02-12 8:49 ` Nicolas Boichat
2020-02-12 9:06 ` Viresh Kumar
2020-02-12 18:14 ` Rob Herring
2020-02-13 7:57 ` Nicolas Boichat
2020-02-13 8:24 ` Nicolas Boichat
[not found] ` <e4e95aa7713344e8b43fe5fad05de3ee@mtkmbs01n1.mediatek.inc>
2020-03-09 1:53 ` Nicolas Boichat
2020-02-07 6:17 ` [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches) Tomeu Vizoso
2020-02-07 7:42 ` Nicolas Boichat
2020-02-07 8:13 ` Tomeu Vizoso [this message]
2020-02-10 3:39 ` Nicolas Boichat
2020-02-10 8:17 ` Tomeu Vizoso
2020-02-25 20:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93aec9ae-00fc-bf55-1d6c-9bd715b78344@collabora.com \
--to=tomeu.vizoso@collabora.com \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=hsinyi@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=steven.price@arm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).