From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Daniel Golle" <daniel@makrotopia.org>,
linux-pwm@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"John Crispin" <john@phrozen.org>
Subject: Re: [PATCH v2 2/2] pwm: mediatek: Add support for MT7981
Date: Thu, 20 Apr 2023 16:32:27 +0200 [thread overview]
Message-ID: <99c2ec7c-bff2-fa50-f267-d5ca383bd5ca@collabora.com> (raw)
In-Reply-To: <7c6e31c844642c199f223f4229a04a37b57a34f3.1681992038.git.daniel@makrotopia.org>
Il 20/04/23 14:36, Daniel Golle ha scritto:
> The PWM unit on MT7981 uses different register offsets than previous
> MediaTek PWM units. Add support for these new offsets and add support
> for PWM on MT7981 which has 3 PWM channels, one of them is typically
> used for a temperature controlled fan.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
The implementation is good now; there's only one nitpick: you're reordering
the platform data entries and I agree about doing that, as they should be
alphabetically sorted, but you didn't mention that in the commit message.
Please send a v3 that mentions that you're also reordering.
"...while at it, also reorder..."
After which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
prev parent reply other threads:[~2023-04-20 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 12:35 [PATCH v2 0/2] Support PWM on MediaTek MT7981 Daniel Golle
2023-04-20 12:35 ` [PATCH v2 1/2] dt-bindings: pwm: mediatek: Add mediatek,mt7981 compatible Daniel Golle
2023-04-20 15:52 ` Krzysztof Kozlowski
2023-04-20 12:36 ` [PATCH v2 2/2] pwm: mediatek: Add support for MT7981 Daniel Golle
2023-04-20 14:32 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99c2ec7c-bff2-fa50-f267-d5ca383bd5ca@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).