From: Bernard <bernard@vivo.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
opensource.kernel@vivo.com, David Airlie <airlied@linux.ie>,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re:Re: [PATCH] drm/mediatek: cleanup coding style in mediatek a bit
Date: Thu, 30 Apr 2020 14:31:31 +0800 (GMT+08:00) [thread overview]
Message-ID: <AOsApgASCAa7imxfuvZwXqq0.3.1588228291133.Hmail.bernard@vivo.com> (raw)
In-Reply-To: <CAAOTY_86d-UryKQrLy8-zjTbrTRrHL4k3x=bx1KqvWxPL5jj2Q@mail.gmail.com>
发件人:Chun-Kuang Hu <chunkuang.hu@kernel.org>
发送日期:2020-04-29 22:22:50
收件人:Bernard Zhao <bernard@vivo.com>
抄送人:Chun-Kuang Hu <chunkuang.hu@kernel.org>,Philipp Zabel <p.zabel@pengutronix.de>,David Airlie <airlied@linux.ie>,Daniel Vetter <daniel@ffwll.ch>,Matthias Brugger <matthias.bgg@gmail.com>,DRI Development <dri-devel@lists.freedesktop.org>,Linux ARM <linux-arm-kernel@lists.infradead.org>,"moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org>,linux-kernel <linux-kernel@vger.kernel.org>,opensource.kernel@vivo.com
主题:Re: [PATCH] drm/mediatek: cleanup coding style in mediatek a bit>Hi, Bernard:
>
>Bernard Zhao <bernard@vivo.com> 於 2020年4月27日 週一 下午3:53寫道:
>>
>> This code change is to make code bit more readable.
>> Optimise array size align to HDMI macro define.
>> Add check if len is overange.
>
>One patch should just do one thing, but this do three things.
>So break this into three patches.
>
>Regards,
>Chun-Kuang.
Hi
This optimization is mainly to make the code a bit readable.
These modifications are related, main in several related function calls in the same file.
I was a bit confused that if it is really necessary to change to three separate patch submissions?
Regards
Bernard
>>
>> Signed-off-by: Bernard Zhao <bernard@vivo.com>
>> ---
>> drivers/gpu/drm/mediatek/mtk_hdmi.c | 22 +++++++++++-----------
>> 1 file changed, 11 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
>> index ff43a3d80410..40fb5154ed5d 100644
>> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
>> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
>> @@ -311,15 +311,15 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
>> u8 checksum;
>> int ctrl_frame_en = 0;
>>
>> - frame_type = *buffer;
>> - buffer += 1;
>> - frame_ver = *buffer;
>> - buffer += 1;
>> - frame_len = *buffer;
>> - buffer += 1;
>> - checksum = *buffer;
>> - buffer += 1;
>> + frame_type = *buffer++;
>> + frame_ver = *buffer++;
>> + frame_len = *buffer++;
>> + checksum = *buffer++;
>> frame_data = buffer;
>> + if ((frame_len + HDMI_INFOFRAME_HEADER_SIZE) > len) {
>> + dev_err(hdmi->dev, "Wrong frame len: %d\n", frame_len;
>> + return;
>> + }
>>
>> dev_dbg(hdmi->dev,
>> "frame_type:0x%x,frame_ver:0x%x,frame_len:0x%x,checksum:0x%x\n",
>> @@ -982,7 +982,7 @@ static int mtk_hdmi_setup_avi_infoframe(struct mtk_hdmi *hdmi,
>> struct drm_display_mode *mode)
>> {
>> struct hdmi_avi_infoframe frame;
>> - u8 buffer[17];
>> + u8 buffer[HDMI_INFOFRAME_HEADER_SIZE + HDMI_AVI_INFOFRAME_SIZE];
>> ssize_t err;
>>
>> err = drm_hdmi_avi_infoframe_from_display_mode(&frame,
>> @@ -1008,7 +1008,7 @@ static int mtk_hdmi_setup_spd_infoframe(struct mtk_hdmi *hdmi,
>> const char *product)
>> {
>> struct hdmi_spd_infoframe frame;
>> - u8 buffer[29];
>> + u8 buffer[HDMI_INFOFRAME_HEADER_SIZE + HDMI_SPD_INFOFRAME_SIZE];
>> ssize_t err;
>>
>> err = hdmi_spd_infoframe_init(&frame, vendor, product);
>> @@ -1031,7 +1031,7 @@ static int mtk_hdmi_setup_spd_infoframe(struct mtk_hdmi *hdmi,
>> static int mtk_hdmi_setup_audio_infoframe(struct mtk_hdmi *hdmi)
>> {
>> struct hdmi_audio_infoframe frame;
>> - u8 buffer[14];
>> + u8 buffer[HDMI_INFOFRAME_HEADER_SIZE + HDMI_AUDIO_INFOFRAME_SIZE];
>> ssize_t err;
>>
>> err = hdmi_audio_infoframe_init(&frame);
>> --
>> 2.26.2
>>
>>
>> _______________________________________________
>> Linux-mediatek mailing list
>> Linux-mediatek@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-04-30 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 7:52 [PATCH] drm/mediatek: cleanup coding style in mediatek a bit Bernard Zhao
2020-04-29 14:22 ` Chun-Kuang Hu
2020-04-30 6:31 ` Bernard [this message]
2020-04-30 15:50 ` Chun-Kuang Hu
2020-05-06 12:14 ` Bernard
2020-05-01 3:57 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AOsApgASCAa7imxfuvZwXqq0.3.1588228291133.Hmail.bernard@vivo.com \
--to=bernard@vivo.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=opensource.kernel@vivo.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).