linux-mediatek.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@google.com>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Cc: Alexandre Courbot <acourbot@chromium.org>,
	Tiffany Lin <tiffany.lin@mediatek.com>,
	 Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	 Yunfei Dong <Yunfei.Dong@mediatek.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	 linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-mediatek@lists.infradead.org,
	 Collabora Kernel ML <kernel@collabora.com>,
	 Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH v6 12/14] media: mtk-vcodec: vdec: add media device if using stateless api
Date: Thu, 5 Aug 2021 19:51:55 +0800	[thread overview]
Message-ID: <CA+Px+wVEpDazZP9gOV=5ANOKhV-k5GzbRWDWFMAJQO7_S=bgEg@mail.gmail.com> (raw)
In-Reply-To: <a0a8b9a1-df9e-0e30-9ce6-36759f707e27@collabora.com>

On Tue, Jul 20, 2021 at 12:22 AM Dafna Hirschfeld
<dafna.hirschfeld@collabora.com> wrote:
> On 05.07.21 07:32, Alexandre Courbot wrote:
> > +             mtk_v4l2_debug(0, "media registered as /dev/media%d", vfd_dec->num);
> the media's node minor is not vfd_dec->num
IIUC, it should be vfd_dec->minor[1].  Will fix in the next version.

[1]: https://elixir.bootlin.com/linux/v5.14-rc4/source/include/media/v4l2-dev.h#L243

> >   struct mtk_vcodec_dev {
> This structs has a lot of duplicated fields for enc/dec
> Since the device represents either a decoder or an encoder,
> I think all those dupliactes can be removed, so for example
> instead of having both 'dec_irq' and 'enc_irq' we can have just 'irq'
I understand the struct may contain duplicate fields.  However I
prefer to separate the refactor into another series.  Would provide
the fixes later.

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2021-08-05 11:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05  5:32 [PATCH v6 00/14] media: mtk-vcodec: support for MT8183 decoder Alexandre Courbot
2021-07-05  5:32 ` [PATCH v6 01/14] media: mtk-vcodec: vdec: Support H264 profile control Alexandre Courbot
2021-07-05  5:32 ` [PATCH v6 02/14] media: mtk-vcodec: vdec: use helpers in VIDIOC_(TRY_)DECODER_CMD Alexandre Courbot
2021-07-05  5:32 ` [PATCH v6 03/14] media: mtk-vcodec: vdec: clamp OUTPUT resolution to hardware limits Alexandre Courbot
2021-07-05  5:32 ` [PATCH v6 04/14] media: mtk-vcodec: make flush buffer reusable by encoder Alexandre Courbot
2021-07-05  5:32 ` [PATCH v6 05/14] media: mtk-vcodec: venc: support START and STOP commands Alexandre Courbot
2021-07-05  5:32 ` [PATCH v6 06/14] media: mtk-vcodec: vdec: move stateful ops into their own file Alexandre Courbot
2021-07-05  5:32 ` [PATCH v6 07/14] media: mtk-vcodec: vdec: handle firmware version field Alexandre Courbot
2021-07-05  5:32 ` [PATCH v6 08/14] media: mtk-vcodec: support version 2 of decoder firmware ABI Alexandre Courbot
2021-07-05  5:32 ` [PATCH v6 09/14] media: add Mediatek's MM21 format Alexandre Courbot
2021-07-05  5:32 ` [PATCH v6 10/14] media: mtk-vcodec: vdec: support stateless API Alexandre Courbot
2021-07-05  5:32 ` [PATCH v6 11/14] media: mtk-vcodec: vdec: support stateless H.264 decoding Alexandre Courbot
2021-07-20 10:52   ` Hans Verkuil
2021-08-05 11:51     ` Tzung-Bi Shih
2021-07-05  5:32 ` [PATCH v6 12/14] media: mtk-vcodec: vdec: add media device if using stateless api Alexandre Courbot
2021-07-19 16:22   ` Dafna Hirschfeld
2021-08-05 11:51     ` Tzung-Bi Shih [this message]
2021-07-05  5:32 ` [PATCH v6 13/14] dt-bindings: media: document mediatek, mt8183-vcodec-dec Alexandre Courbot
2021-07-05  5:32 ` [PATCH v6 14/14] media: mtk-vcodec: enable MT8183 decoder Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+Px+wVEpDazZP9gOV=5ANOKhV-k5GzbRWDWFMAJQO7_S=bgEg@mail.gmail.com' \
    --to=tzungbi@google.com \
    --cc=Yunfei.Dong@mediatek.com \
    --cc=acourbot@chromium.org \
    --cc=andrew-ct.chen@mediatek.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=enric.balletbo@collabora.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=tiffany.lin@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).