From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C462C433DF for ; Sun, 14 Jun 2020 22:43:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01050206D7 for ; Sun, 14 Jun 2020 22:43:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eLPHsfoY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=vanguardiasur-com-ar.20150623.gappssmtp.com header.i=@vanguardiasur-com-ar.20150623.gappssmtp.com header.b="kPQ+nCIo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01050206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vanguardiasur.com.ar Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B1ZnUMpCsPPFnd7F03cNztji3e4F9sPfxvx/uJEb+cA=; b=eLPHsfoYvRTShs VLJi2pj1a8QKD/YE18jRaCgLmgF9YcUjtJQMNush+DaQZmTHdjz9WTRWH88QhKZzoO0UI0oOziOCG 73pTukqDXolUV694aWYr8aQuYQt6LEuUqOColN7MAyZ5xUxxGW7/FajU9VJhEjlnWgaxCHznofwhr akzgZaqLm9qUvRB9kItdTxyYSZaSXszV5m8zIMMa1/0XepYSB80VIvfbXMXTsMepI/QrnHMEHqM2u Zn16HdGPLOp5CZHA85pYwRtNoNmxm6F2h2GpqMTAPoNp+9xMzWRqa77FUemroPVG/ZiEnl05wv9Iz 5PxC4FcvOmONYZ/bcpQg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkbLi-0003s5-Ua; Sun, 14 Jun 2020 22:43:34 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkbLf-0003rD-Gm for linux-mediatek@lists.infradead.org; Sun, 14 Jun 2020 22:43:33 +0000 Received: by mail-ed1-x543.google.com with SMTP id g1so10133745edv.6 for ; Sun, 14 Jun 2020 15:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1lprYkJAyOKBzMBK93xU+u9SELPnGpp6W2PGiHIuVVE=; b=kPQ+nCIobtuVJOw0grvTibWxlmGDjjahO9NjG44BUlkoB2sTgHGRV0XsX7QWMvwB9S neLYTlf0CCiyBpIVzhA2RHrp18f1EgUTB7whyM/6eEyH0WHvFLJQnNTj6OcSklQpRUDt QTBYg/aYZzL3oe+1154pAzoV1yA03zDNk6rctJf7dCatSMEhrVao+wH/2i87+aKo6RH8 7U35KdFwGpzlwZZb1eOD9kmIH19b5i6npQG/6QBr82w+doAnSgG0Xr24PRGVuV1n3SVY 3fHUpT3u0WMPmq+Ex/pJyFTq53zmVH36HextUqd8ZVqQdz3oUWrZxyaze3lcOv9QIb5D yWDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1lprYkJAyOKBzMBK93xU+u9SELPnGpp6W2PGiHIuVVE=; b=BG7szAjMHXzxWiRaoV9kLtBsblahoazHDuiSsK+1OH3lOap7g0W0sKKUVJsHgPBtul Xvjj2LlI2unKO0opc1lGWAb83pAztImwg1gVgMTYFEqU9xzZkxlPz5fbd+vG99DKBCyQ joPm3vgCQMaTRDW8r+l2EoeZEhm+2qTmUEtS57BYUxtmSGq8poFUw7Xcx/Gry7iLC4h9 yv5yL9ITslVgKbFFz+hT+kbGbP9Q79HIWOlnKdwhOjOlw/zH6crE15wm84TTcZ4rszcq 8Ivo+7ANjVVjk9P6RuIZcwTYsNNVID3TmSd2xXuBVU5hmUxz6+6ro4qLedMILPFqt3rk urfA== X-Gm-Message-State: AOAM531Z0Y8lBfwoAJt5Ssx3P1IZk6SvkNa2oy9duFLOhEYMtDeSzHh5 cQKI0w8ywFyOxqS++lS4wbKNi/Ke3VPa6+6ha62nRQ== X-Google-Smtp-Source: ABdhPJwjlev+Zt10Pkqu14VpTVVHkmLlVD/cQ29TLqg5Wy8ANyOr/GB9Wf4L1DL+9ZM6adnp3wug9+KEMJyBO8xr1Nc= X-Received: by 2002:aa7:c756:: with SMTP id c22mr21688074eds.239.1592174609436; Sun, 14 Jun 2020 15:43:29 -0700 (PDT) MIME-Version: 1.0 References: <20191204124732.10932-1-Jerry-Ch.chen@mediatek.com> <20191204124732.10932-2-Jerry-Ch.chen@mediatek.com> <20200521171101.GA243874@chromium.org> <20200610190356.GJ201868@chromium.org> In-Reply-To: From: Ezequiel Garcia Date: Sun, 14 Jun 2020 19:43:18 -0300 Message-ID: Subject: Re: [RFC PATCH V4 1/4] media: v4l2-mem2mem: add v4l2_m2m_suspend, v4l2_m2m_resume To: Tomasz Figa X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200614_154331_703983_3C9BD034 X-CRM114-Status: GOOD ( 40.71 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-devicetree , =?UTF-8?B?U2VhbiBDaGVuZyAo6YSt5piH5byYKQ==?= , Laurent Pinchart , =?UTF-8?B?UnlubiBXdSAo5ZCz6IKy5oGpKQ==?= , zwisler@chromium.org, srv_heupstream , Jerry-ch Chen , Jerry-ch Chen , Hans Verkuil , =?UTF-8?B?SnVuZ28gTGluICjmnpfmmI7kv4op?= , Sj Huang , yuzhao@chromium.org, "moderated list:ARM/Mediatek SoC support" , Pi-Hsun Shih , =?UTF-8?B?RnJlZGVyaWMgQ2hlbiAo6Zmz5L+K5YWDKQ==?= , Matthias Brugger , =?UTF-8?B?Q2hyaXN0aWUgWXUgKOa4uOmbheaDoCk=?= , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 10 Jun 2020 at 16:26, Tomasz Figa wrote: > > On Wed, Jun 10, 2020 at 9:14 PM Ezequiel Garcia > wrote: > > > > On Wed, 10 Jun 2020 at 16:03, Tomasz Figa wrote: > > > > > > On Wed, Jun 10, 2020 at 03:52:39PM -0300, Ezequiel Garcia wrote: > > > > Hi everyone, > > > > > > > > Thanks for the patch. > > > > > > > > On Wed, 10 Jun 2020 at 07:33, Tomasz Figa wrote: > > > > > > > > > > On Wed, Jun 10, 2020 at 12:29 PM Hans Verkuil wrote: > > > > > > > > > > > > On 21/05/2020 19:11, Tomasz Figa wrote: > > > > > > > Hi Jerry, > > > > > > > > > > > > > > On Wed, Dec 04, 2019 at 08:47:29PM +0800, Jerry-ch Chen wrote: > > > > > > >> From: Pi-Hsun Shih > > > > > > >> > > > > > > >> Add two functions that can be used to stop new jobs from being queued / > > > > > > >> continue running queued job. This can be used while a driver using m2m > > > > > > >> helper is going to suspend / wake up from resume, and can ensure that > > > > > > >> there's no job running in suspend process. > > > [snip] > > > > > > > > > > > > I assume this will be part of a future patch series that calls these new functions? > > > > > > > > > > The mtk-jpeg encoder series depends on this patch as well, so I guess > > > > > it would go together with whichever is ready first. > > > > > > > > > > I would also envision someone changing the other existing drivers to > > > > > use the helpers, as I'm pretty much sure some of them don't handle > > > > > suspend/resume correctly. > > > > > > > > > > > > > This indeed looks very good. If I understood the issue properly, > > > > the change would be useful for both stateless (e.g. hantro, et al) > > > > and stateful (e.g. coda) codecs. > > > > > > > > Hantro uses pm_runtime_force_suspend, and I believe that > > > > could is enough for proper suspend/resume operation. > > > > > > Unfortunately, no. :( > > > > > > If the decoder is already decoding a frame, that would forcefully power > > > off the hardware and possibly even cause a system lockup if we are > > > unlucky to gate a clock in the middle of a bus transaction. > > > > > > > pm_runtime_force_suspend calls pm_runtime_disable, which > > says: > > > > """ > > Increment power.disable_depth for the device and if it was zero previously, > > cancel all pending runtime PM requests for the device and wait for all > > operations in progress to complete. > > """ > > > > Doesn't this mean it waits for the current job (if there is one) and > > prevents any new jobs to be issued? > > > > I'd love if the PM runtime subsystem handled job management of all the > driver subsystems automatically, but at the moment it's not aware of > any jobs. :) The description says as much as it says - it stops any > internal jobs of the PM subsystem - i.e. asynchronous suspend/resume > requests. It doesn't have any awareness of V4L2 M2M jobs. > Doh, of course. I saw "pending requests" and somehow imagined it would wait for the runtime_put. I see now that these patches are the way to go. > > > I just inspected the code now and actually found one more bug in its > > > power management handling. device_run() calls clk_bulk_enable() before > > > pm_runtime_get_sync(), but only the latter is guaranteed to actually > > > power on the relevant power domains, so we end up clocking unpowered > > > hardware. > > > > > > > How about we just move clk_enable/disable to runtime PM? > > > > Since we use autosuspend delay, it theoretically has > > some impact, which is why I was refraining from doing so. > > > > I can't decide if this impact would be marginal or significant. > > > > I'd also refrain from doing this. Clock gating corresponds to the > bigger part of the power savings from runtime power management, since > it stops the dynamic power consumption and only leaves the static > leakage. That said, the Hantro IP blocks have some internal clock > gating as well, so it might not be as pronounced, depending on the > custom vendor integration logic surrounding the Hantro hardware. > OK, I agree. We need to fix this issue then, changing the order of the calls. > Actually even if autosuspend is not used, the runtime PM subsystem has > some internal back-off mechanism based on measured power on and power > off latencies. The driver should call pm_runtime_get_sync() first and > then enable any necessary clocks. I can see that currently inside the > resume callback we have some hardware accesses. If those really need > to be there, they should be surrounded with appropriate clock enable > and clock disable calls. > Currently, it's only used by imx8mq, and it's enclosed by clk_bulk_prepare_enable/disable_unprepare. I am quite sure the prepare/unprepare usage is an oversight on our side, but it doesn't do any harm either. Moving the clock handling to hantro_runtime_resume is possible, but looks like just low-hanging fruit. > > > > > > > > I'm not seeing any code in CODA to handle this, so not sure > > > > how it's handling suspend/resume. > > > > > > > > Maybe we can have CODA as the first user, given it's a well-maintained > > > > driver and should be fairly easy to test. > > > > > > I remember checking a number of drivers using the m2m helpers randomly > > > and none of them implemented suspend/resume correctly. I suppose that > > > was not discovered because normally the userspace itself would stop the > > > operation before the system is suspended, although it's not an API > > > guarantee. > > > > > > > Indeed. Do you have any recomendations for how we could > > test this case to make sure we are handling it correctly? > > I'd say that a simple offscreen command line gstreamer/ffmpeg decode > with suspend/resume loop in another session should be able to trigger > some issues. > I can try to fix the above clk/pm issue and take this helper on the same series, if that's useful. Thanks, Ezequiel _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek