linux-mediatek.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Tomasz Figa <tfiga@chromium.org>
To: "kyrie.wu" <kyrie.wu@mediatek.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Rob Herring <robh+dt@kernel.org>, Bin Liu <bin.liu@mediatek.com>,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	Tzung-Bi Shih <tzungbi@chromium.org>,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	 linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-mediatek@lists.infradead.org, Xia.Jiang@mediatek.com,
	 maoguang.meng@mediatek.com, srv_heupstream@mediatek.com
Subject: Re: [PATCH v2,0/9] Support jpeg encode for MT8195
Date: Fri, 9 Jul 2021 19:26:31 +0900	[thread overview]
Message-ID: <CAAFQd5D+Zwh6JxJqAbyLX9XeyFdnmjUgWTpFA6GvO2qNktOxBQ@mail.gmail.com> (raw)
In-Reply-To: <1625038079-25815-1-git-send-email-kyrie.wu@mediatek.com>

Hi Kyrie,

On Wed, Jun 30, 2021 at 4:31 PM kyrie.wu <kyrie.wu@mediatek.com> wrote:
>
> add component framework to using multi-HW for MT8195 jpeg encode.
>
> kyrie.wu (9):
>   dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible
>   media: mtk-jpegenc: Add MT8195 JPEG venc driver
>   media: mtk-jpegenc: remove redundant code of irq
>   media: mtk-jpegenc: Refactor jpeg clock interface
>   media: mtk-jpegenc: Generalize jpeg encode irq interfaces
>   media: mtk-jpegenc: Generalize jpegenc HW timeout interfaces
>   media: mtk-jpegenc: Use component framework to manage each hardware
>     information
>   media: mtk-jpegenc: Generalize jpegenc HW operations interfaces
>   media: mtk-jpegenc: Refactor jpegenc device run interface
>
>  .../bindings/media/mediatek-jpeg-encoder.yaml      |   3 +
>  drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c    | 600 +++++++++++++++++----
>  drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h    |  69 ++-
>  drivers/media/platform/mtk-jpeg/mtk_jpeg_enc_hw.c  | 208 +++++++
>  4 files changed, 786 insertions(+), 94 deletions(-)
>
> ---
> This patch dependents on "dt-bindings: mediatek: convert mtk jpeg decoder/encoder to yaml"[1]
>
> Please also accept this patch together with [1].
>
> [1]https://lore.kernel.org/patchwork/patch/1445298/

Thank you for the series. However, I gave reviewing it a try and
unfortunately had a very hard time following it, because of the way
the patches are organized. Please make sure to read and understand the
kernel patch submission guide[1], adjust the series appropriately and
send a new version which I'll review.

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Best regards,
Tomasz

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

      parent reply	other threads:[~2021-07-09 10:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30  7:27 [PATCH v2,0/9] Support jpeg encode for MT8195 kyrie.wu
2021-06-30  7:27 ` [PATCH v2, 1/9] dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible kyrie.wu
2021-06-30  7:27 ` [PATCH v2,2/9] media: mtk-jpegenc: Add MT8195 JPEG venc driver kyrie.wu
2021-07-06 11:00   ` Tzung-Bi Shih
2021-06-30  7:27 ` [PATCH v2,3/9] media: mtk-jpegenc: remove redundant code of irq kyrie.wu
2021-07-06 11:00   ` Tzung-Bi Shih
2021-07-09  9:07     ` Tomasz Figa
2021-06-30  7:27 ` [PATCH v2,4/9] media: mtk-jpegenc: Refactor jpeg clock interface kyrie.wu
2021-07-06 11:00   ` Tzung-Bi Shih
2021-07-09  9:20   ` Tomasz Figa
2021-06-30  7:27 ` [PATCH v2, 5/9] media: mtk-jpegenc: Generalize jpeg encode irq interfaces kyrie.wu
2021-07-06 11:00   ` Tzung-Bi Shih
2021-07-09 10:20   ` [PATCH v2,5/9] " Tomasz Figa
2021-06-30  7:27 ` [PATCH v2, 6/9] media: mtk-jpegenc: Generalize jpegenc HW timeout interfaces kyrie.wu
2021-07-06 11:00   ` Tzung-Bi Shih
2021-06-30  7:27 ` [PATCH v2, 7/9] media: mtk-jpegenc: Use component framework to manage each hardware information kyrie.wu
2021-07-06 11:00   ` [PATCH v2,7/9] " Tzung-Bi Shih
2021-06-30  7:27 ` [PATCH v2, 8/9] media: mtk-jpegenc: Generalize jpegenc HW operations interfaces kyrie.wu
2021-07-06 11:00   ` [PATCH v2,8/9] " Tzung-Bi Shih
2021-06-30  7:27 ` [PATCH v2, 9/9] media: mtk-jpegenc: Refactor jpegenc device run interface kyrie.wu
2021-07-06 11:01   ` Tzung-Bi Shih
2021-07-06 11:00 ` [PATCH v2,0/9] Support jpeg encode for MT8195 Tzung-Bi Shih
2021-07-09  8:27   ` Tomasz Figa
2021-07-09 10:26 ` Tomasz Figa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAFQd5D+Zwh6JxJqAbyLX9XeyFdnmjUgWTpFA6GvO2qNktOxBQ@mail.gmail.com \
    --to=tfiga@chromium.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=Xia.Jiang@mediatek.com \
    --cc=bin.liu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=kyrie.wu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=maoguang.meng@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=tzungbi@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).