From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: Mark Yacoub <markyacoub@chromium.org>
Cc: "moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Sean Paul <seanpaul@chromium.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jason-JH Lin <jason-jh.lin@mediatek.com>,
tzungbi@google.com, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm/mediatek: Set default value for Panel Orientation connector prop.
Date: Mon, 3 Jan 2022 20:39:15 +0800 [thread overview]
Message-ID: <CAAOTY_9E71AfKy_poZMA7s++TvzM4=VH0H1o8ZBmDphcz9iXDw@mail.gmail.com> (raw)
In-Reply-To: <20211229184420.793234-1-markyacoub@chromium.org>
Hi, Mark:
Mark Yacoub <markyacoub@chromium.org> 於 2021年12月30日 週四 上午2:44寫道:
>
> [Why]
> Creating the prop uses UNKNOWN as the initial value, which is not a
> supported value if the prop is to be supported.
>
> [How]
> Set the panel orientation default value to NORMAL right after creating
> the prop if no DSI panel exists.
> Panels have their own orientations, and panel orientation can't be
> overriden once initialized to a value.
>
> v1:
> Set panel orientation only if DSI panel does not exist.
>
> Tested on Jacuzzi(MTK)
> Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic}
>
> Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 0ad7157660afa..9d33dd93118e0 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1040,6 +1040,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)
> goto err_cleanup_encoder;
> }
>
> + /* A drm_panel can have its own orientation. If there is no panel, set the
> + * orientation to NORMAL. */
> + if (!dsi->panel) {
Please send patch based on latest kernel version. In latest kernel
version, struct mtk_dsi{} has no member 'panel'.
Regards,
Chun-Kuang.
> + drm_connector_set_panel_orientation(
> + dsi->connector, DRM_MODE_PANEL_ORIENTATION_NORMAL);
> + }
> +
> drm_connector_attach_encoder(dsi->connector, &dsi->encoder);
>
> return 0;
> --
> 2.34.1.448.ga2b2bfdf31-goog
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-01-03 12:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 17:24 [PATCH] mediatek: Set default value for Panel Orientation connector prop Mark Yacoub
2021-10-26 1:13 ` Sean Paul
2021-12-14 15:13 ` Mark Yacoub
2021-12-15 16:14 ` Chun-Kuang Hu
2021-12-15 17:25 ` Mark Yacoub
2021-12-16 16:53 ` Chun-Kuang Hu
2021-12-16 18:29 ` Mark Yacoub
2021-12-29 18:39 ` [PATCH v2] drm/mediatek: " Mark Yacoub
2021-12-29 18:44 ` Mark Yacoub
2022-01-03 12:39 ` Chun-Kuang Hu [this message]
2022-01-05 21:23 ` [PATCH v3] " Mark Yacoub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAOTY_9E71AfKy_poZMA7s++TvzM4=VH0H1o8ZBmDphcz9iXDw@mail.gmail.com' \
--to=chunkuang.hu@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-jh.lin@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=markyacoub@chromium.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=seanpaul@chromium.org \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).