From: Chun-Kuang Hu <chunkuang.hu@kernel.org> To: Enric Balletbo i Serra <enric.balletbo@collabora.com> Cc: Nicolas Boichat <drinkcat@chromium.org>, Anders Roxell <anders.roxell@linaro.org>, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger <matthias.bgg@gmail.com>, Collabora Kernel ML <kernel@collabora.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols Date: Fri, 27 Mar 2020 22:22:18 +0800 Message-ID: <CAAOTY_9vCtr6Y3Geg3wJ7FjTdo6iPc+bdwtJKDZahJAY3Tih8Q@mail.gmail.com> (raw) In-Reply-To: <20200326182742.487026-1-enric.balletbo@collabora.com> Hi, Enric: Enric Balletbo i Serra <enric.balletbo@collabora.com> 於 2020年3月27日 週五 上午2:28寫道: > > When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see > the following error. > > ERROR: modpost: "mtk_mmsys_ddp_disconnect" > [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined! > ERROR: modpost: "mtk_mmsys_ddp_connect" > [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined! > > Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be > able to be used for other modules. > Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device") > Reported-by: Anders Roxell <anders.roxell@linaro.org> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > drivers/soc/mediatek/mtk-mmsys.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c > index 32a92ec447c5..05e322c9c301 100644 > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev, > writel_relaxed(reg, config_regs + addr); > } > } > +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect); > > void mtk_mmsys_ddp_disconnect(struct device *dev, > enum mtk_ddp_comp_id cur, > @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev, > writel_relaxed(reg, config_regs + addr); > } > } > +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect); > > static int mtk_mmsys_probe(struct platform_device *pdev) > { > -- > 2.25.1 > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply index Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-26 18:27 Enric Balletbo i Serra 2020-03-27 7:19 ` Anders Roxell 2020-03-27 14:22 ` Chun-Kuang Hu [this message] 2020-03-27 17:02 ` Matthias Brugger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAOTY_9vCtr6Y3Geg3wJ7FjTdo6iPc+bdwtJKDZahJAY3Tih8Q@mail.gmail.com \ --to=chunkuang.hu@kernel.org \ --cc=anders.roxell@linaro.org \ --cc=drinkcat@chromium.org \ --cc=enric.balletbo@collabora.com \ --cc=hsinyi@chromium.org \ --cc=kernel@collabora.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-mediatek Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mediatek/0 linux-mediatek/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mediatek linux-mediatek/ https://lore.kernel.org/linux-mediatek \ linux-mediatek@lists.infradead.org public-inbox-index linux-mediatek Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mediatek AGPL code for this site: git clone https://public-inbox.org/public-inbox.git