From: Guenter Roeck <groeck@google.com>
To: Yong Wu <yong.wu@mediatek.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
mingyuan.ma@mediatek.com, yf.wang@mediatek.com,
libo.kang@mediatek.com, chengci.xu@mediatek.com,
youlin.pei@mediatek.com, anan.sun@mediatek.com,
xueqi.zhang@mediatek.com, Guenter Roeck <groeck@chromium.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 1/4] iommu/mediatek: Use dev_err_probe to mute probe_defer err log
Date: Wed, 11 May 2022 08:24:39 -0700 [thread overview]
Message-ID: <CABXOdTcA1ERGTCMVDhz+cah6GwC3hsNR9W3PYyYZN6uGE5_Rsg@mail.gmail.com> (raw)
In-Reply-To: <20220511064920.18455-2-yong.wu@mediatek.com>
On Tue, May 10, 2022 at 11:49 PM Yong Wu <yong.wu@mediatek.com> wrote:
>
> Mute the probe defer log:
>
> [ 2.654806] mtk-iommu 14018000.iommu: mm dts parse fail(-517).
> [ 2.656168] mtk-iommu 1c01f000.iommu: mm dts parse fail(-517).
>
> Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE")
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> The Fixes tag commit-id is from linux-next.
> ---
> drivers/iommu/mtk_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index 71b2ace74cd6..0f6ec4a4d9d4 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -1198,7 +1198,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
> if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) {
> ret = mtk_iommu_mm_dts_parse(dev, &match, data);
> if (ret) {
> - dev_err(dev, "mm dts parse fail(%d).", ret);
> + dev_err_probe(dev, ret, "mm dts parse fail.");
> goto out_runtime_disable;
> }
> } else if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_INFRA) &&
> --
> 2.18.0
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-05-11 15:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 6:49 [PATCH 0/4] iommu/mediatek: Improve safety from dts Yong Wu
2022-05-11 6:49 ` [PATCH 1/4] iommu/mediatek: Use dev_err_probe to mute probe_defer err log Yong Wu
2022-05-11 8:42 ` Dan Carpenter
2022-05-11 14:53 ` AngeloGioacchino Del Regno
2022-05-11 15:24 ` Guenter Roeck [this message]
2022-05-11 6:49 ` [PATCH 2/4] iommu/mediatek: Add error path for loop of mm_dts_parse Yong Wu
2022-05-11 6:49 ` [PATCH 3/4] iommu/mediatek: Validate number of phandles associated with "mediatek, larbs" Yong Wu
2022-05-11 14:53 ` [PATCH 3/4] iommu/mediatek: Validate number of phandles associated with "mediatek,larbs" AngeloGioacchino Del Regno
2022-05-11 6:49 ` [PATCH 4/4] iommu/mediatek: Improve safety for mediatek, smi property in larb nodes Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABXOdTcA1ERGTCMVDhz+cah6GwC3hsNR9W3PYyYZN6uGE5_Rsg@mail.gmail.com \
--to=groeck@google.com \
--cc=anan.sun@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chengci.xu@mediatek.com \
--cc=dan.carpenter@oracle.com \
--cc=groeck@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=libo.kang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mingyuan.ma@mediatek.com \
--cc=will@kernel.org \
--cc=xueqi.zhang@mediatek.com \
--cc=yf.wang@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).