From: Guillaume Ranquet <granquet@baylibre.com>
To: Rex-BC Chen <rex-bc.chen@mediatek.com>,
vkoul@kernel.org, airlied@linux.ie,
angelogioacchino.delregno@collabora.com,
chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org,
ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de,
jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org,
maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com,
mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org,
tzimmermann@suse.de
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org, markyacoub@google.com
Subject: Re: [PATCH v9 16/22] drm/meditek: dpi: Add matrix_sel helper
Date: Tue, 12 Apr 2022 02:37:18 -0700 [thread overview]
Message-ID: <CABnWg9vfMJTbOTK-khgaj7RReLVSKJ3DCmJbDvgKMf+tUBwoSA@mail.gmail.com> (raw)
In-Reply-To: <736a7f6710f1ea31eff4abcc3d9c3ff79a1f0ddb.camel@mediatek.com>
On Mon, 28 Mar 2022 10:49, Rex-BC Chen <rex-bc.chen@mediatek.com> wrote:
>On Mon, 2022-03-28 at 00:39 +0200, Guillaume Ranquet wrote:
>> Add a mtk_dpi_matrix_sel() helper to update the DPI_MATRIX_SET
>> register depending on the color format.
>>
>> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
>> ---
>> drivers/gpu/drm/mediatek/mtk_dpi.c | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
>> b/drivers/gpu/drm/mediatek/mtk_dpi.c
>> index 8198d3cf23ac..82f97c687652 100644
>> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
>> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
>> @@ -385,6 +385,25 @@ static void mtk_dpi_config_disable_edge(struct
>> mtk_dpi *dpi)
>> mtk_dpi_mask(dpi, dpi->conf->reg_h_fre_con, 0,
>> EDGE_SEL_EN);
>> }
>>
>> +static void mtk_dpi_matrix_sel(struct mtk_dpi *dpi, enum
>> mtk_dpi_out_color_format format)
>> +{
>> + u32 matrix_sel = 0;
>> +
>> + switch (format) {
>> + case MTK_DPI_COLOR_FORMAT_YCBCR_422:
>> + case MTK_DPI_COLOR_FORMAT_YCBCR_422_FULL:
>> + case MTK_DPI_COLOR_FORMAT_YCBCR_444:
>> + case MTK_DPI_COLOR_FORMAT_YCBCR_444_FULL:
>> + case MTK_DPI_COLOR_FORMAT_XV_YCC:
>> + if (dpi->mode.hdisplay <= 720)
>> + matrix_sel = 0x2;
>> + break;
>> + default:
>> + break;
>> + }
>> + mtk_dpi_mask(dpi, DPI_MATRIX_SET, matrix_sel,
>> INT_MATRIX_SEL_MASK);
>> +}
>> +
>> static void mtk_dpi_config_color_format(struct mtk_dpi *dpi,
>> enum mtk_dpi_out_color_format
>> format)
>> {
>> @@ -392,6 +411,7 @@ static void mtk_dpi_config_color_format(struct
>> mtk_dpi *dpi,
>> (format == MTK_DPI_COLOR_FORMAT_YCBCR_444_FULL)) {
>> mtk_dpi_config_yuv422_enable(dpi, false);
>> mtk_dpi_config_csc_enable(dpi, true);
>> + mtk_dpi_matrix_sel(dpi, format);
>> if (dpi->conf->swap_input_support)
>> mtk_dpi_config_swap_input(dpi, false);
>> mtk_dpi_config_channel_swap(dpi,
>> MTK_DPI_OUT_CHANNEL_SWAP_BGR);
>> @@ -399,6 +419,7 @@ static void mtk_dpi_config_color_format(struct
>> mtk_dpi *dpi,
>> (format == MTK_DPI_COLOR_FORMAT_YCBCR_422_FULL)) {
>> mtk_dpi_config_yuv422_enable(dpi, true);
>> mtk_dpi_config_csc_enable(dpi, true);
>> + mtk_dpi_matrix_sel(dpi, format);
>> if (dpi->conf->swap_input_support)
>> mtk_dpi_config_swap_input(dpi, true);
>> mtk_dpi_config_channel_swap(dpi,
>> MTK_DPI_OUT_CHANNEL_SWAP_RGB);
>
>Hello Guillaume,
>
>Thanks for your patch.
>I have one question:
>Do this setting affect the dpi for previous SoCs?
>(8183, 8192, or 8186)
>If we can confirm the original register setting for this offset in
>8183/8192/8186, I think we can clarify this question.
>
I've checked in the datasheet I have (8365/8385) that this register
and setting exists.
So yes, it will affect other platforms.
>BRs,
>Rex
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-04-12 9:37 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 22:39 [PATCH 00/22] drm/mediatek: Add mt8195 DisplayPort driver Guillaume Ranquet
2022-03-27 22:39 ` [PATCH v9 01/22] dt-bindings: mediatek,dpi: Add DP_INTF compatible Guillaume Ranquet
2022-03-29 10:42 ` Matthias Brugger
2022-03-30 5:11 ` [PATCH v9 01/22] dt-bindings: mediatek, dpi: " Miles Chen
2022-04-22 10:57 ` [PATCH v9 01/22] dt-bindings: mediatek,dpi: " Maxime Ripard
2022-05-11 12:37 ` [PATCH v9 01/22] dt-bindings: mediatek, dpi: " Guillaume Ranquet
2022-03-27 22:39 ` [PATCH v9 02/22] dt-bindings: mediatek,dp: Add Display Port binding Guillaume Ranquet
2022-03-28 12:51 ` [PATCH v9 02/22] dt-bindings: mediatek, dp: " Rob Herring
2022-03-28 16:33 ` [PATCH v9 02/22] dt-bindings: mediatek,dp: " Rob Herring
2022-03-30 5:12 ` [PATCH v9 02/22] dt-bindings: mediatek, dp: " Miles Chen
2022-03-27 22:39 ` [PATCH v9 03/22] dt-bindings: mediatek, dp_phy: Add Display Port PHY binding Guillaume Ranquet
2022-03-29 22:58 ` [PATCH v9 03/22] dt-bindings: mediatek,dp_phy: " Rob Herring
2022-04-12 10:06 ` Guillaume Ranquet
2022-03-30 5:12 ` [PATCH v9 03/22] dt-bindings: mediatek, dp_phy: " Miles Chen
2022-03-27 22:39 ` [PATCH v9 04/22] drm/edid: Convert cea_sad helper struct to kernelDoc Guillaume Ranquet
2022-03-28 8:04 ` AngeloGioacchino Del Regno
2022-04-12 8:57 ` Guillaume Ranquet
2022-03-27 22:39 ` [PATCH v9 05/22] drm/edid: Add cea_sad helpers for freq/length Guillaume Ranquet
2022-03-27 22:39 ` [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP Guillaume Ranquet
2022-03-28 8:09 ` AngeloGioacchino Del Regno
2022-04-12 8:59 ` Guillaume Ranquet
2022-03-27 22:39 ` [PATCH v9 07/22] drm/mediatek: dpi: move dpi limits to SoC config Guillaume Ranquet
2022-03-28 7:18 ` Rex-BC Chen
2022-03-27 22:39 ` [PATCH v9 08/22] drm/mediatek: dpi: implement a CK/DE pol toggle in " Guillaume Ranquet
2022-03-28 7:31 ` Rex-BC Chen
2022-03-27 22:39 ` [PATCH v9 09/22] drm/mediatek: dpi: implement a swap_input " Guillaume Ranquet
2022-03-28 8:33 ` Rex-BC Chen
2022-03-27 22:39 ` [PATCH v9 10/22] drm/mediatek: dpi: move dimension mask to " Guillaume Ranquet
2022-03-28 8:33 ` Rex-BC Chen
2022-03-27 22:39 ` [PATCH v9 11/22] drm/mediatek: dpi: move hvsize_mask " Guillaume Ranquet
2022-03-28 8:34 ` Rex-BC Chen
2022-03-27 22:39 ` [PATCH v9 12/22] drm/mediatek: dpi: move swap_shift " Guillaume Ranquet
2022-03-28 8:20 ` AngeloGioacchino Del Regno
2022-03-28 8:34 ` Rex-BC Chen
2022-03-27 22:39 ` [PATCH v9 13/22] drm/mediatek: dpi: move the yuv422_en_bit " Guillaume Ranquet
2022-03-28 8:54 ` Rex-BC Chen
2022-03-27 22:39 ` [PATCH v9 14/22] drm/mediatek: dpi: move the csc_enable bit " Guillaume Ranquet
2022-03-28 8:35 ` Rex-BC Chen
2022-03-27 22:39 ` [PATCH v9 15/22] drm/mediatek: dpi: Add dpintf support Guillaume Ranquet
2022-03-28 8:38 ` Rex-BC Chen
2022-04-12 9:10 ` Guillaume Ranquet
2022-03-29 3:16 ` Rex-BC Chen
2022-04-12 9:12 ` Guillaume Ranquet
2022-03-27 22:39 ` [PATCH v9 16/22] drm/meditek: dpi: Add matrix_sel helper Guillaume Ranquet
2022-03-28 8:49 ` Rex-BC Chen
2022-04-12 9:37 ` Guillaume Ranquet [this message]
2022-03-27 22:39 ` [PATCH v9 17/22] phy: phy-mtk-dp: Add driver for DP phy Guillaume Ranquet
2022-03-28 8:20 ` AngeloGioacchino Del Regno
2022-04-12 9:04 ` Guillaume Ranquet
2022-03-27 22:39 ` [PATCH v9 18/22] drm/mediatek: Add mt8195 Embedded DisplayPort driver Guillaume Ranquet
2022-03-28 9:14 ` AngeloGioacchino Del Regno
2022-04-12 9:46 ` Guillaume Ranquet
2022-04-13 7:50 ` AngeloGioacchino Del Regno
2022-03-29 3:34 ` Rex-BC Chen
2022-04-12 9:48 ` Guillaume Ranquet
2022-03-29 5:41 ` Rex-BC Chen
2022-04-12 10:03 ` Guillaume Ranquet
2022-04-29 8:39 ` Maxime Ripard
2022-05-11 12:59 ` Guillaume Ranquet
2022-05-12 7:44 ` Maxime Ripard
2022-05-19 16:26 ` Guillaume Ranquet
2022-05-25 9:44 ` Maxime Ripard
2022-03-27 22:39 ` [PATCH v9 19/22] drm/mediatek: Add mt8195 External DisplayPort support Guillaume Ranquet
2022-03-27 22:39 ` [PATCH v9 20/22] drm/mediatek: add hpd debounce Guillaume Ranquet
2022-03-27 22:39 ` [PATCH v9 21/22] drm/mediatek: change the aux retries times when receiving AUX_DEFER Guillaume Ranquet
2022-03-28 1:46 ` Rex-BC Chen
2022-03-27 22:39 ` [PATCH v9 22/22] drm/mediatek: DP audio support for mt8195 Guillaume Ranquet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABnWg9vfMJTbOTK-khgaj7RReLVSKJ3DCmJbDvgKMf+tUBwoSA@mail.gmail.com \
--to=granquet@baylibre.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=kishon@ti.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=markyacoub@google.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).