From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3D35C47247 for ; Tue, 5 May 2020 21:46:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7642206FA for ; Tue, 5 May 2020 21:46:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rIkPqm7e"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZIoXJJra" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7642206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=COx453s2TuY9UXV7sahL6x2Y908hxVMPEWZxYgHl+as=; b=rIkPqm7e8BS+UT auhDz8cxrBJUdIgRapmroG3B8IziVWpccaEinsJiqEjY01rVZ/+/OEPLSEfDvclC+7nxzcVhoYgPK IGjWRZuxlQUkkvOrQXlw9ecyA4oRtdgBNXQTzNassQiJ94PeLJaWxmLRItHlWPB3Q6Ot/nvG6GnGK cAzBZ573Wwyrr8Oj87VgUqAmG13P/C8oHeCpuSDzw70k3HgdPdM/YhmmCWmPhJ48n+u6h6Q+PrQgj PITvNDhraUXHVcwOpFHpILURjBChvxXOM2yem9xNMMLgtMTxWdkdyv6w+ZyHal9suoSBU499qSoeQ K6lWsoqLXgFVMJn1SPTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jW5Og-0001Yp-EZ; Tue, 05 May 2020 21:46:38 +0000 Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jW5O6-0000yR-LZ; Tue, 05 May 2020 21:46:04 +0000 Received: by mail-qv1-xf43.google.com with SMTP id v18so42273qvx.9; Tue, 05 May 2020 14:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R8NCAiVQGf1RfOegGjvzJMziYyDzp2bsCSV1MaN4Voo=; b=ZIoXJJraEJVdnimMK50llvgOXi7em9HScaaU0nSq0RkeBqNWbeZeE9X/srcFx5jieX qQl4234YJtVcJNFfaHC8xj6U0z+l2yZ8R1rCmZcg7w+E2X2wmfEaZVWHPdfyqdgwLnxt rYV+cfrjp5X3UvK8pjx2n/AAfKT0Gg8JQLWs35P01KX67S/rY/Kgh4qh1j+3391E53Mg o1ukd6V1kR6sjIlXVhCQHwhLYyVXjg8I9nGLRwn04GU+DGHf4k3QYo5hHx/DwE9nEyE2 tGkgEMN4ZUb3A2ScVWZtB8f2uKK4xj3hRc7ZoKy+xi34Rwv1rn2pxYkseY2QUOUCsyeB gfXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R8NCAiVQGf1RfOegGjvzJMziYyDzp2bsCSV1MaN4Voo=; b=ZDUbxfO7RuE9hi88RFt555REt+L1+trb0kmonONZzOe68SOffWLpr0743D8NebnBcR WWh44DwPsvCMI2//F4zOox87FAzGIemnJtZcwp5ohb3/v7ZscdTJwy/0VzQWzyPMbZEZ 4gSCewiW0HiPfML8CcGiSWRoT14JsDtZJ1uwGmc1032lbqh9KxHaTEaLydqmf5p5zQad D5SZZroQhiTDQPrBaTKD6fuaNQnHzawtI3FcjRZYQ/j1rvYIYFch6Snr6QWTo2iJ8rh8 xmRAFbkHdsrvFkm5h5svIo1EKpJxu+CdAPK7wdCZAiO0l+jYwjfP/r3IYw10/zVFngKl gkLg== X-Gm-Message-State: AGi0PuYWjXlsnzQhCMMBVUblOTUNP3W5khKB2YBHvPlPJgVYmVh4H1QC 0lgrpDyLowzWXnRZoVMReR0Ix1QMPGGHD6ti0dY= X-Google-Smtp-Source: APiQypIgezGzc28P28ECC0K35WZq6bKt5h1gPnuYe/Qlr/SsV0rJJZPPlQSFwztMV/9sQnHqEoH0ghXBgjTBUwXil6M= X-Received: by 2002:a0c:ec44:: with SMTP id n4mr4828893qvq.237.1588715161652; Tue, 05 May 2020 14:46:01 -0700 (PDT) MIME-Version: 1.0 References: <20200505040048.132493-1-eizan@google.com> <20200505125042.v1.3.Ieebc5dcb6dcc116119a570f14786ba47c9007ec8@changeid> In-Reply-To: <20200505125042.v1.3.Ieebc5dcb6dcc116119a570f14786ba47c9007ec8@changeid> From: Enric Balletbo Serra Date: Tue, 5 May 2020 23:45:50 +0200 Message-ID: Subject: Re: [PATCH v1 3/5] [media] mtk-mdp: handle vpu_wdt_reg_handler() errors during probe To: Eizan Miyamoto X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200505_144602_751746_7E518DD8 X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew-CT Chen , Minghsiu Tsai , LKML , Houlong Wei , Eizan Miyamoto , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Mauro Carvalho Chehab , Linux ARM , linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Eizan, Thank you for your patch. Missatge de Eizan Miyamoto del dia dt., 5 de maig 2020 a les 6:01: > > This is a cleanup to better handle errors during MDP probe. > > Signed-off-by: eizan@chromium.org > Signed-off-by: Eizan Miyamoto Ditto > --- > > drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c > index c20ac7681c6f..f974242663dc 100644 > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c > @@ -188,8 +188,12 @@ static int mtk_mdp_probe(struct platform_device *pdev) > } > > mdp->vpu_dev = vpu_get_plat_device(pdev); > - vpu_wdt_reg_handler(mdp->vpu_dev, mtk_mdp_reset_handler, mdp, > - VPU_RST_MDP); > + ret = vpu_wdt_reg_handler(mdp->vpu_dev, mtk_mdp_reset_handler, mdp, > + VPU_RST_MDP); > + if (ret) { > + dev_err(&pdev->dev, "Failed to register reset handler\n"); > + goto err_wdt_reg; No need to introduce a new label, just goto err_m2m_register > + } > > platform_set_drvdata(pdev, mdp); > > @@ -206,6 +210,8 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > err_set_max_seg_size: > > +err_wdt_reg: > + > err_m2m_register: > v4l2_device_unregister(&mdp->v4l2_dev); > > -- > 2.26.2.526.g744177e7f7-goog > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek