From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B639C28CBC for ; Wed, 6 May 2020 15:25:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 291D220CC7 for ; Wed, 6 May 2020 15:25:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yq4uM24Y"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k1r4mxpe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 291D220CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B404kSgf5ISuA7QFbJVntRXnmyAd+Vj5weJqwYvmO0w=; b=Yq4uM24YtsJLVr g5a/NlHQEsHcVy3y0Q5o5I6x218OOiNV35Fizmf9WEqcJHlS368KgZuWDIFl3bJNPzPLf15k9awkP 8BAku1IbiP8b9LMGTAwSPVpWCc1x3JOeRiHHuDwNh0nsv7F3Msj3yV07cOSFhlVQSFuuzCYd0g7Zs cEZDEFdfTHXpEZ0KJwhF3CcAMHKrMAr3/0FmOPJWR9KCZJOoxvg+xYoh2b71IT9oHUJbiC72OczWc F4K10Zpu+Svf1sBiQkqXmE8f2Jw1KZzmtspO7sRpCi/rU6LZO3JmubtEU7KUhAvCRtyM3pJ7OTqvM AFcKwWnl63tQRfzIcYmQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWLv4-00068A-72; Wed, 06 May 2020 15:25:10 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWLv1-0005QP-6K; Wed, 06 May 2020 15:25:08 +0000 Received: by mail-qk1-x741.google.com with SMTP id k81so2328101qke.5; Wed, 06 May 2020 08:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2rKUJoVCstS8j+217iqzpL0arUK/6LFCBfMeZ1DLw34=; b=k1r4mxpeI+EmP8nUVlONZx45dwe25zNrS7sa/tPEShURitcx+P1p2e9KLZOugr4Dmn LFSdKpg6yKHiXk3XWmkdLRd71m7BeSD0HQHpmGjEk/0IRVrFkIHMJ9ucnyih7SJgpfnf 6hGB0lTi6BzYjHtv+ByIqvryFbllvlshoWpqVDaoPnF6l0hNRwPT5yqdSfj4n4XW/nio L7e2gguZj/8WBw9++jwHEZXh/nui9vo9UbwLjsDIsuPEZPcfpVnEkGEjHxBklXOIEt1s 8zN9jL2f1PFcF67Bijq6NXSHeL24FVl2bxBxPG8D4U1AcywcVLCjl94k40aYI5wE0ylE 60hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2rKUJoVCstS8j+217iqzpL0arUK/6LFCBfMeZ1DLw34=; b=l2iOFX511rzZ5PpMfAlZePJUT2Dv+7x25iOpwrtiCIE+v+cMfA0p+9aNMLCuqdTxqO Io90RO5WXxMZoPBw4+1rhSrH5/vF12RQnztFvp1KUoUY7jm3729sL2DYHcD6BoXkyQJ3 RY+xNIxJPhUhTqcIxn0Dnv51o8VGmsbgUxgA4VjJFy3d0x203avl7P/59H7kzpuY+WuU 8GKV4cJCm7f0ZfqVoPpNQJyF2slBSqLxgwPPIpOr1cD0NdLQBM/NtCKFXh9xT/WiiRiV Rynb2T1bOKd9VfUMHOIA7U1YYlvfoZsrUv1Q2nkNum2/fGjlocRkb6FREqwjExjrblZJ yo6A== X-Gm-Message-State: AGi0PubnwRkSaAkfKA0IZ7XL6USCvxM2G4EuuZYQxCYHwXBdbqDFal4D ys76nbAU1N4UcbB15+cu6YSsDmcJeJMhN0cdClw= X-Google-Smtp-Source: APiQypLN8pqWxzhOjoSavD/Blq7jrlAhL4/SdXZMluNjCSenj8jZiR8ivhrWbzxp8MtF270/m2d7r/XhrXZQ+gkQYrk= X-Received: by 2002:a37:6c81:: with SMTP id h123mr9142170qkc.290.1588778706429; Wed, 06 May 2020 08:25:06 -0700 (PDT) MIME-Version: 1.0 References: <20200506054920.109738-1-eizan@chromium.org> <20200506154832.v2.3.Ia8efd7905e2fcfc81f547e27a51f06373624b3da@changeid> In-Reply-To: <20200506154832.v2.3.Ia8efd7905e2fcfc81f547e27a51f06373624b3da@changeid> From: Enric Balletbo Serra Date: Wed, 6 May 2020 17:24:55 +0200 Message-ID: Subject: Re: [PATCH v2 3/5] [media] mtk-mdp: handle vpu_wdt_reg_handler() errors during probe To: Eizan Miyamoto X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200506_082507_263703_AAB2B441 X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew-CT Chen , Minghsiu Tsai , LKML , Houlong Wei , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Mauro Carvalho Chehab , Linux ARM , linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Eizan, Thank you for your patch. Missatge de Eizan Miyamoto del dia dc., 6 de maig 2020 a les 7:51: > > This is a cleanup to better handle errors during MDP probe. > > Signed-off-by: eizan@chromium.org ditto, remove the above line. > Signed-off-by: Eizan Miyamoto > --- Other than that: Reviewed-by: Enric Balletbo i Serra > > Changes in v1: > - remove unnecessary error handling labels in favor of err_m2m_register > > drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c > index 9b24b8d46eb7..17d155219ba2 100644 > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c > @@ -188,8 +188,12 @@ static int mtk_mdp_probe(struct platform_device *pdev) > } > > mdp->vpu_dev = vpu_get_plat_device(pdev); > - vpu_wdt_reg_handler(mdp->vpu_dev, mtk_mdp_reset_handler, mdp, > - VPU_RST_MDP); > + ret = vpu_wdt_reg_handler(mdp->vpu_dev, mtk_mdp_reset_handler, mdp, > + VPU_RST_MDP); > + if (ret) { > + dev_err(&pdev->dev, "Failed to register reset handler\n"); > + goto err_m2m_register; > + } > > platform_set_drvdata(pdev, mdp); > > -- > 2.26.2.526.g744177e7f7-goog > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek