From: Enric Balletbo Serra <eballetbo@gmail.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver
Date: Tue, 21 Sep 2021 10:36:39 +0200 [thread overview]
Message-ID: <CAFqH_53M2OO8DpkPa3L7cwppVRYiUgEDjrLjK7JJNgKgxnQpVA@mail.gmail.com> (raw)
In-Reply-To: <CAAOTY_9LstZegE_Gyibov5tLo5eEqiPfoAcnyj_uoS=8xLLhnA@mail.gmail.com>
Hi Chun-Kuang,
(again without html format, sorry for the noise)
Missatge de Chun-Kuang Hu <chunkuang.hu@kernel.org> del dia dj., 12
d’ag. 2021 a les 2:13:
>
> Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2021年8月9日 週一 上午7:47寫道:
> >
> > These refinements include using standard mailbox callback interface,
> > timeout detection, and a fixed cmdq_handle.
>
> For this series, applied to mediatek-drm-next [1].
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
>
These patches seem to break the display on the Acer Chromebook R 13
(MT8173) in the current mainline. After running a bisection it pointed
me to the following commit
commit f4be17cd5b14dd73545b0e014a63ebe9ab5ef837
Author: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date: Sun Jul 4 15:36:48 2021 +0800
drm/mediatek: Remove struct cmdq_client
Reverting this patch alone is not trivial, so I ended up reverting the
full series, and I can confirm that reverting the full series makes
the display work again.
Unfortunately, after the merge window, different things broke for this
device, and I didn't finish isolating them, and it is not clear to me
yet whether the logs I'm getting are useful for this specific issue or
not. Basically with this series merged the kernel seems to be stuck,
and the display is not working. Latest message is
[ 12.329173] mtk-iommu 10205000.iommu: Partial TLB flush timed out,
falling back to full flush
Without the series, the kernel goes far and display works, however
there are other issues affecting the cros-ec, but I think that's
another issue.
I'll try to dig a bit more, but, meanwhile, if you have any idea
please let me know.
Thanks,
Enric
> Regards,
> Chun-Kuang.
>
> >
> > Changes in v2:
> > 1. Define mtk_drm_cmdq_pkt_create() and mtk_drm_cmdq_pkt_destroy()
> > when CONFIG_MTK_CMDQ is reachable.
> >
> > Chun-Kuang Hu (4):
> > drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb
> > drm/mediatek: Remove struct cmdq_client
> > drm/mediatek: Detect CMDQ execution timeout
> > drm/mediatek: Add cmdq_handle in mtk_crtc
> >
> > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 110 ++++++++++++++++++++----
> > 1 file changed, 91 insertions(+), 19 deletions(-)
> >
> > --
> > 2.25.1
> >
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-09-21 8:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 23:47 [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver Chun-Kuang Hu
2021-08-08 23:47 ` [PATCH v2 1/4] drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb Chun-Kuang Hu
2021-08-08 23:47 ` [PATCH v2 2/4] drm/mediatek: Remove struct cmdq_client Chun-Kuang Hu
2021-08-08 23:47 ` [PATCH v2 3/4] drm/mediatek: Detect CMDQ execution timeout Chun-Kuang Hu
2021-08-08 23:47 ` [PATCH v2 4/4] drm/mediatek: Add cmdq_handle in mtk_crtc Chun-Kuang Hu
2021-08-12 0:13 ` [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver Chun-Kuang Hu
2021-09-21 8:36 ` Enric Balletbo Serra [this message]
2021-09-21 13:14 ` Chun-Kuang Hu
2021-09-23 16:36 ` Enric Balletbo Serra
2021-09-23 23:43 ` Chun-Kuang Hu
2021-09-29 14:25 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFqH_53M2OO8DpkPa3L7cwppVRYiUgEDjrLjK7JJNgKgxnQpVA@mail.gmail.com \
--to=eballetbo@gmail.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).