From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3436C35242 for ; Tue, 11 Feb 2020 20:09:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D47C20708 for ; Tue, 11 Feb 2020 20:09:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kKWapGvz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="iKL3T3KT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D47C20708 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3jNgd4S5sfs4hFW64MhiHsdgxUNtkDvJUL3El55bOf0=; b=kKWapGvz9lN5Ut /BBm6omG6speP9xO6rZjyyRL5+KyHQaS65Uscgex8ZIbW2inbhOcbw+2UPzTgV+M7AxldrKSrUUKC XVlnOwsvkhkTfoSGDoKjbXIsoF6xScb6zjEo5fMrA/kcSdBSW2hTQXcSlKaNLcvtRqKqsFBfs6bf6 Kk1aXBz9FeQdGFxPOZUhpf8MucSqAdYrS9Zt+EwhUnvB0rW/5SKgAAPQ/mxHh4rJYzWdxw2OVe8jj /goimWmbbEuYOM0nVxSgkZZAfxhSBkrVY6xpLx34QkOazhAluIhkGk44OFkUokUmfrOMJCp5IWH87 CIF/aObBMXhcWst003rQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1bqd-0006HD-Sl; Tue, 11 Feb 2020 20:09:31 +0000 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1bqa-0006Fv-Rr for linux-mediatek@lists.infradead.org; Tue, 11 Feb 2020 20:09:30 +0000 Received: by mail-oi1-x241.google.com with SMTP id c16so14079337oic.3 for ; Tue, 11 Feb 2020 12:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d79/juOKGQ3xhEKgN8cqkrkeeX6KR3FsfafPiPWnTjk=; b=iKL3T3KT/E0Iwsb3fnUfmhLupejJLrt0Xw5IOfw8B/SqKyHuAmgD6b5kRaiIeb6uQi 4hqOAy9ePuT7GdoTUwr87pkUzlBm0LRqEEFiWmTJS7vLwJwDvOy2UWIrGEpnJS5HNg6L UJ3OcYCcXDup4hmac0c8ZAtTXuIBB4C4CC3djbwDvtd6WU9keMA7joMyqQ4WttYi8EBN vrOINTqg3CqyMUDW8SXtRJMA5A2vJY60W9spolclj6hO3pOdiey4rg0CUIfOnXDULfGo s6RA3SPhR9ow2ObUxJ9XLAnHJ3VD73fdhMjBf6otQbBS3osn2sT48zUHMkQ908wokOCL r57w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d79/juOKGQ3xhEKgN8cqkrkeeX6KR3FsfafPiPWnTjk=; b=nBawI+jEn/v1HVFS5MIvNdvfXPB9+aWO294LtBEvB8AVrrEQw3TQuFkgTz5nNxKjuQ z1FOIM6tBSZEL5tEMCJtRbyk5FFhLIDOefpsVbvdlDIJ+iz8pAEAU1jZWYPKLj0S8KUT RvnUE4PjurMDYFAznah2EncdQTzrZtkprSuvI4My3plC5YNvJcxPROQinnR5pTxpBt++ Byaru8eoR7SEn7nK/hpU7RIgrKMQpgRXum6ctq9b1GdJymMR9zPbuY+cgvpP1IhCNwge 9TQq0hLc6WgCusaQNIhSiF6enIN1vmO5cd6djfy5LgLZu6SzuQd/F3YIQNYWdQBEu1jQ EaQA== X-Gm-Message-State: APjAAAWqyZpA8mbWStt9z+wcyt41PYwKhIzyL6YixuE7r4T0rsvpyjnu 66VcsnBmTszteBSP8bRin6GuprvfGv8UXvUCuzPH6w== X-Google-Smtp-Source: APXvYqzxjGO2mFbbESSI+X8wqwDLJmq3XqFdPvI31wvyICH6y7/2J3dCeN49E5XfR2n7WblRYhIvydxmmpi6MKoWH0c= X-Received: by 2002:aca:ea43:: with SMTP id i64mr4107524oih.30.1581451761048; Tue, 11 Feb 2020 12:09:21 -0800 (PST) MIME-Version: 1.0 References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-6-drinkcat@chromium.org> In-Reply-To: From: Saravana Kannan Date: Tue, 11 Feb 2020 12:08:44 -0800 Message-ID: Subject: Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_120928_905801_DC56CC95 X-CRM114-Status: GOOD ( 29.29 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ulf Hansson , Nicolas Boichat , Tomeu Vizoso , Greg Kroah-Hartman , David Airlie , "linux-kernel@vger.kernel.org" , Liam Girdwood , dri-devel , Steven Price , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Daniel Vetter , Hsin-Yi Wang , Matthias Brugger , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Feb 11, 2020 at 11:44 AM Rob Herring wrote: > > +Saravana > > On Thu, Feb 6, 2020 at 11:27 PM Nicolas Boichat wrote: > > > > When there is a single power domain per device, the core will > > ensure the power domain is switched on (so it is technically > > equivalent to having not power domain specified at all). > > > > However, when there are multiple domains, as in MT8183 Bifrost > > GPU, we need to handle them in driver code. > > > > Signed-off-by: Nicolas Boichat > > > > --- > > > > The downstream driver we use on chromeos-4.19 currently uses 2 > > additional devices in device tree to accomodate for this [1], but > > I believe this solution is cleaner. > > > > [1] https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads/chromeos-4.19/drivers/gpu/arm/midgard/platform/mediatek/mali_kbase_runtime_pm.c#31 > > > > v4: > > - Match the exact power domain names as specified in the compatible > > struct, instead of just matching the number of power domains. > > [Review: Ulf Hansson] > > - Dropped print and reordered function [Review: Steven Price] > > - nits: Run through latest version of checkpatch: > > - Use WARN instead of BUG_ON. > > - Drop braces for single expression if block. > > v3: > > - Use the compatible matching data to specify the number of power > > domains. Note that setting 0 or 1 in num_pm_domains is equivalent > > as the core will handle these 2 cases in the exact same way > > (automatically, without driver intervention), and there should > > be no adverse consequence in this case (the concern is about > > switching on only some power domains and not others). > > > > drivers/gpu/drm/panfrost/panfrost_device.c | 97 ++++++++++++++++++++-- > > drivers/gpu/drm/panfrost/panfrost_device.h | 11 +++ > > drivers/gpu/drm/panfrost/panfrost_drv.c | 2 + > > 3 files changed, 102 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c > > index 3720d50f6d9f965..8136babd3ba9935 100644 > > --- a/drivers/gpu/drm/panfrost/panfrost_device.c > > +++ b/drivers/gpu/drm/panfrost/panfrost_device.c > > @@ -5,6 +5,7 @@ > > #include > > #include > > #include > > +#include > > #include > > > > #include "panfrost_device.h" > > @@ -120,6 +121,79 @@ static void panfrost_regulator_fini(struct panfrost_device *pfdev) > > pfdev->regulators); > > } > > > > +static void panfrost_pm_domain_fini(struct panfrost_device *pfdev) > > +{ > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(pfdev->pm_domain_devs); i++) { > > + if (!pfdev->pm_domain_devs[i]) > > + break; > > + > > + if (pfdev->pm_domain_links[i]) > > + device_link_del(pfdev->pm_domain_links[i]); > > + > > + dev_pm_domain_detach(pfdev->pm_domain_devs[i], true); > > + } > > +} > > + > > +static int panfrost_pm_domain_init(struct panfrost_device *pfdev) > > +{ > > + int err; > > + int i, num_domains; > > + > > + num_domains = of_count_phandle_with_args(pfdev->dev->of_node, > > + "power-domains", > > + "#power-domain-cells"); > > + > > + /* > > + * Single domain is handled by the core, and, if only a single power > > + * the power domain is requested, the property is optional. > > + */ > > + if (num_domains < 2 && pfdev->comp->num_pm_domains < 2) > > + return 0; > > + > > + if (num_domains != pfdev->comp->num_pm_domains) { > > + dev_err(pfdev->dev, > > + "Incorrect number of power domains: %d provided, %d needed\n", > > + num_domains, pfdev->comp->num_pm_domains); > > + return -EINVAL; > > + } > > + > > + if (WARN(num_domains > ARRAY_SIZE(pfdev->pm_domain_devs), > > + "Too many supplies in compatible structure.\n")) > > + return -EINVAL; > > + > > + for (i = 0; i < num_domains; i++) { > > + pfdev->pm_domain_devs[i] = > > + dev_pm_domain_attach_by_name(pfdev->dev, > > + pfdev->comp->pm_domain_names[i]); > > + if (IS_ERR_OR_NULL(pfdev->pm_domain_devs[i])) { > > + err = PTR_ERR(pfdev->pm_domain_devs[i]) ? : -ENODATA; > > + pfdev->pm_domain_devs[i] = NULL; > > + dev_err(pfdev->dev, > > + "failed to get pm-domain %s(%d): %d\n", > > + pfdev->comp->pm_domain_names[i], i, err); > > + goto err; > > + } > > + > > + pfdev->pm_domain_links[i] = device_link_add(pfdev->dev, > > + pfdev->pm_domain_devs[i], DL_FLAG_PM_RUNTIME | > > + DL_FLAG_STATELESS | DL_FLAG_RPM_ACTIVE); > > We're in the process of adding device links based on DT properties. > Shouldn't we add power domains to that? See drivers/of/property.c for > what's handled. Rob, drivers/of/property.c doesn't enable the RPM_ACTIVE AND PM_RUNTIME flags. Wanted to start off conservative. But adding command line ops to change the default flags shouldn't be difficult. But before I do that, I want to change of_devlink to fw_devlink=. May be I can extend that to "disabled, permissive, suspend, runtime". Nicholas, And the adding and removing of device links for power domains will be a 2 line change. I've been meaning to add a few more bindings like hwspinlocks and pinctrl. I can roll power domains support into that if you want. -Saravana _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek