From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 878C1C77B7A for ; Wed, 31 May 2023 04:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AIhKyHH3M7cbke7yuigX6jBzwG52Hnh4pfVGqCJbh2E=; b=FbgtFlheWgOha4VHelkcMH87Qm ewzi8ZeeiuyQ1ejNlnyUdSqZCAFk9W2gH27FFeRULEaX0dYWxJpCcU8mpZRsyMAkhN68ghZ1lVTEN yJ8nEKWQ+m93nd/yrBzhRadxUy1aZUsBpT4I3u2+cP9BEnqwR2C4oURwWyerfjRb9+VQYgqIcdUCC W4zHpByR15ixestyASbbGxgrnF7kqswQ7HzFq5lvhFN31gDqzMXbZ3gfL9oP2Teo1RyiG52VHj/vh K6gFKlV4AVWW7gqlBjZ6ielfwEcJsw3vyueJKprYs/025RudyEvmliP8qdZf3jTWYyHKXYyd6Rwz8 fCNU8w5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4Dmc-00G5Bs-0D; Wed, 31 May 2023 04:50:02 +0000 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4DmX-00G59o-1d for linux-mediatek@lists.infradead.org; Wed, 31 May 2023 04:50:00 +0000 Received: by mail-qt1-x82f.google.com with SMTP id d75a77b69052e-3f81396e435so23485311cf.0 for ; Tue, 30 May 2023 21:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685508595; x=1688100595; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AIhKyHH3M7cbke7yuigX6jBzwG52Hnh4pfVGqCJbh2E=; b=HdOhh3avnmm0A0X2CKBtkWj8n2mTjkJRDj54EC/L41Z3fBgA9z+7gs5CQheZrYp+o/ HVmBUDma0iAod0p7zCGEMYvaBp4y0h/cMXXqxw9sYKFjL4/OCDrVIkmAJQ6hNqRynki4 i76WOp31bxaF+BNXRXsitsveSOZcPHGqnEs4U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685508595; x=1688100595; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AIhKyHH3M7cbke7yuigX6jBzwG52Hnh4pfVGqCJbh2E=; b=UYhtHxpyDkM/qjy5RyB8kgYjHngMGmI8EDfiMtPLQaW489zB+rsp2AQUaWvfcXhpPA VUGnLAcQiv8h/FP6TCvi2U6Cwi0aCbrjJViMjuAKuY3ycNSIeIkmuJxVDr10VDMxkPuj o5oJHqDQo35suGmQhjoKg6uCVYmAs1mQ4bi8FyUOXVu9x5gLrvIFztjC9Mazy8m+nuKK 2wLvDcliXDUcFIO0jxOuLbmpPlmpI7s+39xaRpyCluOIUZpJ6z9nnBb9fyf+YaXtXdnR JP6SWEwDyApXm/4sKrpjPFN518PmbhhzKJW65caGJr9Rvaz39ekitodCyLp9KLtJlGvu bqZg== X-Gm-Message-State: AC+VfDy6R6jNwk6u+6F1lyq8I07JDO+tj23t5im2U9D63bMQ4ldhWXCq F0XH+RYIdwcsj9Gx1wP5QLF5x+NDYlovnmUYpGJrIw== X-Google-Smtp-Source: ACHHUZ59KzB24IVnct48XOmbgp0HaBygejoFOdaodm4dgQC79KaZmYJr8htlEBsi9gDXYnmpG1Slgn3o9UH1CCtdjvo= X-Received: by 2002:ac8:5c43:0:b0:3f6:a760:2487 with SMTP id j3-20020ac85c43000000b003f6a7602487mr119062qtj.59.1685508594852; Tue, 30 May 2023 21:49:54 -0700 (PDT) MIME-Version: 1.0 References: <20230530195132.2286163-1-bero@baylibre.com> In-Reply-To: <20230530195132.2286163-1-bero@baylibre.com> From: Chen-Yu Tsai Date: Wed, 31 May 2023 12:49:43 +0800 Message-ID: Subject: Re: [PATCH v4 0/5] Add LVTS support for mt8192 To: =?UTF-8?Q?Bernhard_Rosenkr=C3=A4nzer?= , nfraprado@collabora.com Cc: daniel.lezcano@linaro.org, angelogioacchino.delregno@collabora.com, rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, rdunlap@infradead.org, ye.xingchen@zte.com.cn, p.zabel@pengutronix.de, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, james.lo@mediatek.com, rex-bc.chen@mediatek.com, abailon@baylibre.com, amergnat@baylibre.com, khilman@baylibre.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_214957_545985_FE004DB7 X-CRM114-Status: GOOD ( 19.08 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, May 31, 2023 at 3:51=E2=80=AFAM Bernhard Rosenkr=C3=A4nzer wrote: > > From: Balsam CHIHI > > Add full LVTS support (MCU thermal domain + AP thermal domain) to MediaTe= k MT8192 SoC. > Also, add Suspend and Resume support to LVTS Driver (all SoCs), > and update the documentation that describes the Calibration Data Offsets. > > Changelog: > v4 : > - Shrink the lvts_ap thermal sensor I/O range to 0xc00 to make > room for SVS support, pointed out by > AngeloGioacchino Del Regno > > v3 : > - Rebased : > base-commit: 6a3d37b4d885129561e1cef361216f00472f7d2e > - Fix issues in v2 pointed out by N=C3=ADcolas F. R. A. Prado : > Use filtered mode to make sure threshold interrupts are trigger= ed, I'm seeing sensor readout (either through sysfs/thermal//temp or hwmon) fail frequently on MT8192. If I run `sensors` (lm-sensors), at least a coup= le of the LVTS sensors would be N/A. Not sure if this is related to this chang= e. ChenYu > protocol documentation, cosmetics > - I (bero@baylibre.com) will be taking care of this patchset > from now on, since Balsam has left BayLibre. Thanks for > getting it almost ready, Balsam! > > v2 : > - Based on top of thermal/linux-next : > base-commit: 7ac82227ee046f8234471de4c12a40b8c2d3ddcc > - Squash "add thermal zones and thermal nodes" and > "add temperature mitigation threshold" commits together to fo= rm > "arm64: dts: mediatek: mt8192: Add thermal nodes and thermal = zones" commit. > - Add Suspend and Resume support to LVTS Driver. > - Update Calibration Data documentation. > - Fix calibration data offsets for mt8192 > (Thanks to "Chen-Yu Tsai" and "N=C3=ADcolas F. R. A. Prado"). > https://lore.kernel.org/all/20230425133052.199767-1-bchihi@baylib= re.com/ > Tested-by: Chen-Yu Tsai > > v1 : > - The initial series "Add LVTS support for mt8192" : > "https://lore.kernel.org/all/20230307163413.143334-1-bchihi@b= aylibre.com/". > > Balsam CHIHI (5): > dt-bindings: thermal: mediatek: Add LVTS thermal controller definition > for mt8192 > thermal/drivers/mediatek/lvts_thermal: Add suspend and resume > thermal/drivers/mediatek/lvts_thermal: Add mt8192 support > arm64: dts: mediatek: mt8192: Add thermal nodes and thermal zones > thermal/drivers/mediatek/lvts_thermal: Update calibration data > documentation > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 454 ++++++++++++++++++ > drivers/thermal/mediatek/lvts_thermal.c | 160 +++++- > .../thermal/mediatek,lvts-thermal.h | 19 + > 3 files changed, 631 insertions(+), 2 deletions(-) > > base-commit: 8c33787278ca8db73ad7d23f932c8c39b9f6e543 > -- > 2.41.0.rc2 >