From: Rob Herring <robh+dt@kernel.org>
To: Phil Chang <phil.chang@mediatek.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Alix Wu <alix.wu@mediatek.com>, DTML <devicetree@vger.kernel.org>,
YJ Chiang <yj.chiang@mediatek.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Joe Liu <joe.liu@mediatek.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions
Date: Mon, 5 Oct 2020 13:57:20 -0500 [thread overview]
Message-ID: <CAL_JsqJQcWsguwfehAoaRf4o-2VqXxSzKzTqg7s4+N1bp=6V5Q@mail.gmail.com> (raw)
In-Reply-To: <1601918237.17256.3.camel@mtksdccf07>
On Mon, Oct 5, 2020 at 12:17 PM Phil Chang <phil.chang@mediatek.com> wrote:
>
> Hi Chun-Kuang
Please don't top post to the lists.
> Sorry for typo. In fact, the dts of new SoC is not upstream yet. I'm so
> sorry for couldn't show the detail now.
Don't have to have the dts upstream. Can you point to a downstream dts
or post a snippet of the reserved memory?
> How about the configurable MAX_RESERVED_REGIONS size like this patch?
> https://patchwork.kernel.org/patch/10692101/
No, as I already said in that patch. But glad you found what's needed
to make it dynamic. But even for dynamic, I want to understand the
use.
Rob
>
>
> On Sun, 2020-10-04 at 21:05 +0800, Chun-Kuang Hu wrote:
> > Hi, Phil:
> >
> > Phil Chang <phil.chang@mediatek.com> 於 2020年10月4日 週日 下午1:51寫道:
> > >
> > > Certain SoCs need to support large amount of reserved memory
> > > regions, especially to follow the GKI rules from Google.
> > > In MTK new SoC requires more than 68 regions of reserved memory
> > > for each IP's usage, such as load firmware to specific sapce,
> >
> > space
> >
> > > so that need to reserve more regisions
> >
> > regions.
> >
> > I guess this requirement is from Mediatek SoC, but I find below device
> > tree and just find one reserved memory region,
> >
> > arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > arch/arm64/boot/dts/mediatek/mt8516.dtsi
> >
> > Could you show me the 68 regions?
> >
> > Regards,
> > Chun-Kuang.
> >
> > >
> > > Signed-off-by: Joe Liu <joe.liu@mediatek.com>
> > > Signed-off-by: YJ Chiang <yj.chiang@mediatek.com>
> > > Signed-off-by: Alix Wu <alix.wu@mediatek.com>
> > > Signed-off-by: Phil Chang <phil.chang@mediatek.com>
> > > ---
> > > drivers/of/of_reserved_mem.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> > > index 46b9371c8a33..595f0741dcef 100644
> > > --- a/drivers/of/of_reserved_mem.c
> > > +++ b/drivers/of/of_reserved_mem.c
> > > @@ -22,7 +22,7 @@
> > > #include <linux/slab.h>
> > > #include <linux/memblock.h>
> > >
> > > -#define MAX_RESERVED_REGIONS 64
> > > +#define MAX_RESERVED_REGIONS 128
> > > static struct reserved_mem reserved_mem[MAX_RESERVED_REGIONS];
> > > static int reserved_mem_count;
> > >
> > > --
> > > 2.18.0
> > > _______________________________________________
> > > Linux-mediatek mailing list
> > > Linux-mediatek@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-10-05 18:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 5:50 [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions Phil Chang
2020-10-04 13:05 ` Chun-Kuang Hu
2020-10-05 17:17 ` Phil Chang
2020-10-05 18:57 ` Rob Herring [this message]
2020-10-05 23:16 ` Chun-Kuang Hu
2020-10-05 13:44 ` Rob Herring
2020-10-05 15:12 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJQcWsguwfehAoaRf4o-2VqXxSzKzTqg7s4+N1bp=6V5Q@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=alix.wu@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=joe.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=phil.chang@mediatek.com \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).