From: Rob Herring <robh@kernel.org>
To: Biao Huang <biao.huang@mediatek.com>
Cc: srv_heupstream <srv_heupstream@mediatek.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
David Miller <davem@davemloft.net>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>,
netdev <netdev@vger.kernel.org>,
dkirjanov@suse.de,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Macpaul Lin <macpaul.lin@mediatek.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
devicetree@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next v10 6/6] net: dt-bindings: dwmac: add support for mt8195
Date: Tue, 11 Jan 2022 17:36:55 -0600 [thread overview]
Message-ID: <CAL_JsqLo7z-KWtwFx+Kng2aQuCpQwJaO6mHnyBzmCKCJDK5n+Q@mail.gmail.com> (raw)
In-Reply-To: <be023f9d2fb2a8f947bd0075e8732ba07cfd7b89.camel@mediatek.com>
On Thu, Dec 16, 2021 at 8:06 PM Biao Huang <biao.huang@mediatek.com> wrote:
>
> Dear Rob,
> Thanks for your comments~
>
> For mt8195, the eth device node will look like:
> eth: ethernet@11021000 {
> compatible = "mediatek,mt8195-gmac", "snps,dwmac-5.10a";
> ...
> clock-names = "axi",
> "apb",
> "mac_cg",
> "mac_main",
> "ptp_ref",
> "rmii_internal";
> clocks = <&pericfg_ao CLK_PERI_AO_ETHERNET>,
> <&pericfg_ao CLK_PERI_AO_ETHERNET_BUS>,
> <&pericfg_ao CLK_PERI_AO_ETHERNET_MAC>,
> <&topckgen CLK_TOP_SNPS_ETH_250M>,
> <&topckgen CLK_TOP_SNPS_ETH_62P4M_PTP>,
> <&topckgen CLK_TOP_SNPS_ETH_50M_RMII>;
> ...
> }
>
> 1. "rmii_internal" is a special clock only required for
> RMII phy interface, dwmac-mediatek.c will enable clocks
> invoking clk_bulk_prepare_enable(xx, 6) for RMII,
> and clk_bulk_prepare_enable(xx, 5) for other phy interfaces.
> so, mt2712/mt8195 all put "rmii_internal" clock to the
> end of clock list to simplify clock handling.
>
> If I put mac_cg as described above, a if condition is required
> for clocks description in dt-binding, just like what I do in v7 send:
> - if:
> properties:
> compatible:
> contains:
> enum:
> - mediatek,mt2712-gmac
>
> then:
> properties:
> clocks:
> minItems: 5
> items:
> - description: AXI clock
> - description: APB clock
> - description: MAC Main clock
> - description: PTP clock
> - description: RMII reference clock provided by MAC
>
> clock-names:
> minItems: 5
> items:
> - const: axi
> - const: apb
> - const: mac_main
> - const: ptp_ref
> - const: rmii_internal
>
> - if:
> properties:
> compatible:
> contains:
> enum:
> - mediatek,mt8195-gmac
>
> then:
> properties:
> clocks:
> minItems: 6
> items:
> - description: AXI clock
> - description: APB clock
> - description: MAC clock gate
> - description: MAC Main clock
> - description: PTP clock
> - description: RMII reference clock provided by MAC
>
> This introduces some duplicated description.
>
> 2. If I put "mac_cg" to the end of clock list,
> the dt-binding file can be simple just like
> what we do in this v10 patch(need fix warnings reported by "make
> DT_CHECKER_FLAGS=-m dt_binding_check").
>
> But for mt8195:
> the eth node in dts should be modified,
I hope you are defining the binding before you use it... That's not
good practice and not a valid argument.
> and eth driver clock handling will be complex;
How so?
Rob
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-01-11 23:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 5:53 [PATCH net-next v10 0/6] MediaTek Ethernet Patches on MT8195 Biao Huang
2021-12-16 5:53 ` [PATCH net-next v10 1/6] stmmac: dwmac-mediatek: add platform level clocks management Biao Huang
2021-12-16 5:53 ` [PATCH net-next v10 2/6] stmmac: dwmac-mediatek: Reuse more common features Biao Huang
2021-12-16 5:53 ` [PATCH net-next v10 3/6] arm64: dts: mt2712: update ethernet device node Biao Huang
2021-12-16 5:53 ` [PATCH net-next v10 4/6] net: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema Biao Huang
2021-12-16 13:53 ` Rob Herring
2021-12-16 16:01 ` Rob Herring
2021-12-17 1:26 ` Biao Huang
2021-12-16 5:53 ` [PATCH net-next v10 5/6] stmmac: dwmac-mediatek: add support for mt8195 Biao Huang
2021-12-16 5:53 ` [PATCH net-next v10 6/6] net: dt-bindings: dwmac: " Biao Huang
2021-12-16 13:53 ` Rob Herring
2021-12-17 2:05 ` Biao Huang
2022-01-11 23:36 ` Rob Herring [this message]
2022-01-14 5:38 ` Biao Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLo7z-KWtwFx+Kng2aQuCpQwJaO6mHnyBzmCKCJDK5n+Q@mail.gmail.com \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=biao.huang@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dkirjanov@suse.de \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).