From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71A94C432C3 for ; Wed, 27 Nov 2019 20:38:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C20921741 for ; Wed, 27 Nov 2019 20:38:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GdNb1cv2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C20921741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5WgXWlwH5+xBS+Dufds7+C8MBHZ2210rMSkIFtRaDK0=; b=GdNb1cv2K1CqJw ansdcNkVbRP5cjgxCD02MHDEboGXwCRNw4aCyUB9A0Vz2FjrOhLhnL9rrevWQSZSkHmKKdoI6ORi/ R8DY6KZ41nYoluLfYBlRPofaE9ZCfSxRkl8Ubqis2Ncny5lnm7SGgKZiEVOL00rRVtZOlpLsbf/aT Dw5xwbvBRy0quyd8n1tqpJXfjFxiAlMtrqXli7gqjfplXJA72jdqcwUUFDfxyiTmzdONrZV8GjmqC FJiaRKT5j/l+gAkaAqC8+LaMsaye3tsiK21jqGtanBztjszDWiO+yuqSvtCOtWLXhv8POvlmKDyKt D3FY+Q7o2rD/5/ANom1A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ia44j-0005Af-6m; Wed, 27 Nov 2019 20:38:13 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ia44Y-00051Q-RJ; Wed, 27 Nov 2019 20:38:04 +0000 Received: by mail-ot1-f68.google.com with SMTP id w11so20335705ote.1; Wed, 27 Nov 2019 12:37:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=14vyCpwlco5dNMekZ671HzsQ/qD/jZMl32Sz5ULoC/U=; b=TbtDokcVXJefsEWMvSaPzEh5dIurBybvR0zu9LHr6h97ze16YLVDTrniApvEHX06bu o8q2SjPfXxkcJ73egrrskyTQmQidaOmFymWFwAkswfexeNUUNsiY4X8VVBvTZAUPthSx Vr2J4heSrCrGcb9rWOGO7KIMPAcTr5bpG7cZy97P2ql3dlkuUfNY2KAsWwm7FM2Ys439 lVe9Ne+MSmsg9hzAWISygWYfiGR/DnIW6EtGRxJHQGj90On1447mNZysvgDHQM4+LyOR 2WWyBF+Daq5/bJRNS9o509EJDWU7zKjDn/uS2Mx8oFBzSlOscPo22RooaQjLYzgKJtEP BMUQ== X-Gm-Message-State: APjAAAVbBPxsG0cWg6QsyelVd31pUSkx0Hp7utOslIEF5TYMr6zbv7Dc igc1HLekxy+YvLfGy3Mt4twQA/550CYg44kzG+I= X-Google-Smtp-Source: APXvYqyekyFnyyTzxDAaVF4lh76x3pVg0AJcETDtG/R5UDB8kyib7ugeAakdgVvr7ZJMAAkTJwIUv0P5kqimosEUmPw= X-Received: by 2002:a9d:2073:: with SMTP id n106mr5117337ota.145.1574887078997; Wed, 27 Nov 2019 12:37:58 -0800 (PST) MIME-Version: 1.0 References: <5a7ed2e4b58ba7ff2f0638a2435a3a1e1c62c9f6.1574871463.git.nishadkamdar@gmail.com> In-Reply-To: <5a7ed2e4b58ba7ff2f0638a2435a3a1e1c62c9f6.1574871463.git.nishadkamdar@gmail.com> From: Geert Uytterhoeven Date: Wed, 27 Nov 2019 21:37:47 +0100 Message-ID: Subject: Re: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier To: Nishad Kamdar X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191127_123802_882710_FFC7754A X-CRM114-Status: GOOD ( 14.32 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , Geert Uytterhoeven , Greg Kroah-Hartman , Kevin Hilman , Linus Walleij , Sean Wang , Linux Kernel Mailing List , linux-stm32@st-md-mailman.stormreply.com, Linux-Renesas , Joe Perches , "open list:GPIO SUBSYSTEM" , linux-mediatek@lists.infradead.org, Maxime Coquelin , Manivannan Sadhasivam , Matthias Brugger , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , "open list:ARM/Amlogic Meson..." , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Nishad, On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar wrote: > This patch corrects the SPDX License Identifier style in > header files related to Reneses Soc pinctrl driver. > It assigns explicit block comment for the SPDX License Identifier. Is it incorrect to not have an explicit block comment? Other recommendations have been to integrate the SPDX comment line into an existing comment header, if it exists.... > Changes made by using a script provided by Joe Perches here: > https://lkml.org/lkml/2019/2/7/46. > > Suggested-by: Joe Perches > Signed-off-by: Nishad Kamdar > --- > drivers/pinctrl/sh-pfc/core.h | 4 ++-- > drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/sh-pfc/core.h b/drivers/pinctrl/sh-pfc/core.h > index b5b1d163e98a..5ad0ab8f9e14 100644 > --- a/drivers/pinctrl/sh-pfc/core.h > +++ b/drivers/pinctrl/sh-pfc/core.h > @@ -1,5 +1,5 @@ > -/* SPDX-License-Identifier: GPL-2.0 > - * > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > * SuperH Pin Function Controller support. > * > * Copyright (C) 2012 Renesas Solutions Corp. > diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h > index 640d2a4cb838..fff9cbb7a0f8 100644 > --- a/drivers/pinctrl/sh-pfc/sh_pfc.h > +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h > @@ -1,5 +1,5 @@ > -/* SPDX-License-Identifier: GPL-2.0 > - * > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > * SuperH Pin Function Controller Support > * > * Copyright (c) 2008 Magnus Damm Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek