From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 749FDC43331 for ; Tue, 12 Nov 2019 06:43:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46E3C214E0 for ; Tue, 12 Nov 2019 06:43:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Rknatyvg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LDDUyvLA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46E3C214E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FJrPHfajJGaFpj2ZgUUcAAdcMdf1GhPr9fxhfvYLQZw=; b=RknatyvgMunez5 ae4S41rNLo4O6X54O24Muafr2hc6vh8/8Jp2iPL66GpGBBJc7KqYCg4k8yrEdZDWhEIZzWGEGaFWG RFiKpWWdL+C5e08ta9UZOjqSHNai9/R799FvJ/LTuyNvumdwwfLD4pmnm90+O/lN5wVZ0GoMMrneQ jvsEK52Z0yJwOSatCU598f9tp8UxCfgqSMIXN28eUecGKgvocyQkLEFXN5cR9Xxbq/D0uCXH3BZOT Q8YFW+Oz+xY4enffsUOpW+eLsrrji2YZsY8y6AnMTRA3zzPKIPlg+hVixxpsWTAjQYpB01Z2Yc/7z hmuS0m8qfltjJJlf7I6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUPtm-0007xg-6b; Tue, 12 Nov 2019 06:43:34 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUPte-0007pJ-3B for linux-mediatek@lists.infradead.org; Tue, 12 Nov 2019 06:43:27 +0000 Received: by mail-ed1-x542.google.com with SMTP id a24so10336074edt.0 for ; Mon, 11 Nov 2019 22:43:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6gu94hk6ViXZU/1pF57c89Mz0JcKl1j3IzzPZmTPjtQ=; b=LDDUyvLAAr/FgJFV0ODv1fscc3tceNs7i1JvEsFi9SbeCOxeMyJWafdRgYIlNqWV49 ro79eCq++su+3IaTvSt6MwgL4SEwWPUZp7cEzIY5lMEh0+Vi4K+fFmiFNMR56+eI/hDL YUlIauWUKVBysNq/DieSbYjanJaQapqZXiAkA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6gu94hk6ViXZU/1pF57c89Mz0JcKl1j3IzzPZmTPjtQ=; b=ZosyFDiFfXLftVZAIhs7Rw4G0MNJLYlrnrg2L8pVF1ieu38AZpx5NgTokiYBXrl31S jdTgYjnImu5DRGgJ0FamOCcuwBauHqTCXY2Uz7ihWhNzfcXS0S7YGnRw7BJsNRWveIt7 RusMptrdVJFQBeYu6qvMbF7pHtLvveFYxMxh8BrrNb2PW8JDpvk0JDYvf2SlBldBD5k2 9gIvzYT6HtzIWudsV0Bmd6rcXOTYrHzjNrIOBzDsKjFvk3KOIMCxfDycCr23djjNYqZ3 jqLLv5NxIHA/TnoOKkBJx1NP/n0GRBPaY66tzBWQworRHX3gVyjErOjfjQ5aOK6Pyx3Z ITmQ== X-Gm-Message-State: APjAAAVXx5MOPKtOekPCtjLCxq78nd4dGU9Oo0b/r0oKdEXRY2MqN7nT G+mHaUXyx2bff1RKSwJoTminYz30eaAPR76KCy0eSA== X-Google-Smtp-Source: APXvYqyMbA5YJasNK6lBrgNGRtM92Nacpnn0WpqptPvJ7NjQkzN/92o6yJP/Cb/7QkIhQbV5cTyTR309VkTgVeCpFuI= X-Received: by 2002:a17:906:1d19:: with SMTP id n25mr25947734ejh.151.1573541003705; Mon, 11 Nov 2019 22:43:23 -0800 (PST) MIME-Version: 1.0 References: <20191014075812.181942-1-pihsun@chromium.org> <20191014075812.181942-4-pihsun@chromium.org> <20191111231023.GD3108315@builder> In-Reply-To: <20191111231023.GD3108315@builder> From: Pi-Hsun Shih Date: Tue, 12 Nov 2019 14:42:47 +0800 Message-ID: Subject: Re: [PATCH v20 3/4] rpmsg: add rpmsg support for mt8183 SCP. To: Bjorn Andersson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_224326_161833_10D16EF0 X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben-Cohen , "open list:REMOTE PROCESSOR \(REMOTEPROC\) SUBSYSTEM" , open list , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Thanks for the review, I'll address them in the next version. Some inline comment below. On Tue, Nov 12, 2019 at 7:10 AM Bjorn Andersson wrote: > > On Mon 14 Oct 00:58 PDT 2019, Pi-Hsun Shih wrote: > > > Add a simple rpmsg support for mt8183 SCP, that use IPI / IPC directly. > > > > Hi Pi-Hsun, > > Sorry for not reviewing this in a timely manner! This looks good, just > some very minor comments below. > > > Signed-off-by: Pi-Hsun Shih > [..] > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > > index f2e5e70a58f2..7896cefb2dc0 100644 > > --- a/drivers/remoteproc/mtk_scp.c > > +++ b/drivers/remoteproc/mtk_scp.c > > @@ -15,6 +15,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "mtk_common.h" > > #include "remoteproc_internal.h" > > @@ -407,6 +408,31 @@ static void scp_unmap_memory_region(struct mtk_scp *scp) > > of_reserved_mem_device_release(scp->dev); > > } > > > > +static struct mtk_rpmsg_info mtk_scp_rpmsg_info = { > > + .send_ipi = scp_ipi_send, > > + .register_ipi = scp_ipi_register, > > + .unregister_ipi = scp_ipi_unregister, > > These are exported symbols, so unless you see a need to support > alternative implementations in the near future just skip the function > pointers and call them directly. > Yes there is request from MTK that they do want to reuse the mtk_rpmsg driver for things other than mtk_scp, so there's a need to support alternative implementations for this. > > + struct rpmsg_device *rpdev, rpmsg_rx_cb_t cb, void *priv, > > + u32 id) > > +{ > > Regards, > Bjorn Regards, Pi-Hsun _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek