From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC6E6C352A4 for ; Mon, 10 Feb 2020 07:51:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9290620733 for ; Mon, 10 Feb 2020 07:51:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X5VS1Hpp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QsC4PDi5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9290620733 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mapn77BbwoiV5J8LjxOv5kA7kjo+s2YSnByob2M075Q=; b=X5VS1HppHEsC+0 6jIcR0C9f36aPZ4dacaBMkFH7Cvg1KgFjvcL6erGTwDk7TZU08g6ypOmAzm101BtPuZdSO6YpkLnz hZueXSwbcJ0NJQJOjp0VGPpBKrkfV09MNPgjzJcxpOHEkF6iPVbdmbNgBLfK53jD9qrw5CK5DhxV6 nDK+8vcVksbjsUMmf5oioOpQ07jFuZi+4II86I/Fqt/2NdZKs2NVPPSitAIhcD5TQ6NPv8nCS6EjX DzNLv72gA1Vp7pMOs/v5ydKrKChAkogcnp8YBnGFFr0VIXVlC0r/RPD+/tXNv9EsFqSDqM96e3bJm 6IhAkBuqvcc7NihOTgmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j13qe-0001oF-Db; Mon, 10 Feb 2020 07:51:16 +0000 Received: from mail-vs1-xe44.google.com ([2607:f8b0:4864:20::e44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j13qW-0001i2-ML for linux-mediatek@lists.infradead.org; Mon, 10 Feb 2020 07:51:10 +0000 Received: by mail-vs1-xe44.google.com with SMTP id k188so3491082vsc.8 for ; Sun, 09 Feb 2020 23:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u3O+szgfwEJKuo4yzEkWiTVNHGumVBlqNQZE9NfjV7I=; b=QsC4PDi5ZlYbAjfw6pBUa0KPphhE/VVoGj6kVK1MAL7QZqo9wjmEBLb9Ikbb7Fp770 o5u/R5ApawhiT5Waee9rnPrac69HShLMufZLupjUjI/CMI3snfnPnH5LdDWGPL7q39dr Evp1CxZoX8gCVNOonqGfUiXeiuwNtbZ+WegCEVukUffQd+2gilW7icSVWUk6sIYv749b slMXTUuMoGaFUwlQwE/ldzraKsne3DiELel3X/Jp70Dz80496OwgjZdM776TADILQLuO yAjl54QHAMbG0F+Y6cIXjrS11+kCEVl5NN47dW7kpuL4QC9qVts5HHxcSN5tLZgx3jY5 Purg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u3O+szgfwEJKuo4yzEkWiTVNHGumVBlqNQZE9NfjV7I=; b=mWh/R4BKfgcTiOjCDEuZktLNeLZzg8hPmahm+APf1v1/Q0J0orp7RgF5b/UoyP4oWv OOgr3eXB+uvXPaDOgbpcIhh9IZnWR/ddzm+iBURUR0HOe3U9oBr9J3SIZVO0hBUykX4J 1rRwfEp3HfkL1xTuVqX/CTvevH87Wi9TmR2pMplD+rjsGWUYeLrDkBlCVEf0A11O8FPe rdQeozObV/Xt9bH9HzJL3bWWB9qI667bkmwHiohw5klzyvwc/en+SWi9U3Davb6FCyZK WHh45UEzUGo/e6ZGs2wHBc1se1C5HWvFHazGj07dCi5/j8jdXzUhugSxdYV0A3sDOIgn n/cA== X-Gm-Message-State: APjAAAVhjirzi0U0Ws6XcX0L95tSWjZZF1FHEYEVdexy29sFqmA9dqSc vqrLd+Wqt7UI6B1kRoxGWw7UpUSuZKa2N4DVuaBTpQ== X-Google-Smtp-Source: APXvYqypbI21Yfdn+EA6ub6ed50JBoiEO60Ni/AfECIKY1ZvJ0o8EXmbyp6DUzxmNBzjRT7iyDPYhJySfgC8H0ANL9s= X-Received: by 2002:a67:ee02:: with SMTP id f2mr5601456vsp.165.1581321061313; Sun, 09 Feb 2020 23:51:01 -0800 (PST) MIME-Version: 1.0 References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-6-drinkcat@chromium.org> In-Reply-To: From: Ulf Hansson Date: Mon, 10 Feb 2020 08:50:25 +0100 Message-ID: Subject: Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains To: Nicolas Boichat X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200209_235108_763592_0BD1DCD4 X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , Tomeu Vizoso , David Airlie , Linux Kernel Mailing List , Mark Brown , Liam Girdwood , dri-devel , Steven Price , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Daniel Vetter , Hsin-Yi Wang , Matthias Brugger , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sun, 9 Feb 2020 at 13:50, Nicolas Boichat wrote: > > On Fri, Feb 7, 2020 at 10:26 PM Ulf Hansson wrote: > > > > On Fri, 7 Feb 2020 at 06:27, Nicolas Boichat wrote: > > > > > > When there is a single power domain per device, the core will > > > ensure the power domain is switched on (so it is technically > > > equivalent to having not power domain specified at all). > > > > > > However, when there are multiple domains, as in MT8183 Bifrost > > > GPU, we need to handle them in driver code. > > > > > > Signed-off-by: Nicolas Boichat > > > > Besides a minor nitpick, feel free to add: > > > > Reviewed-by: Ulf Hansson > > > > Kind regards > > Uffe > > > > [snip] > > > +static int panfrost_pm_domain_init(struct panfrost_device *pfdev) > > > +{ > > > + int err; > > > + int i, num_domains; > > > + > > > + num_domains = of_count_phandle_with_args(pfdev->dev->of_node, > > > + "power-domains", > > > + "#power-domain-cells"); > > > + > > > + /* > > > + * Single domain is handled by the core, and, if only a single power > > > + * the power domain is requested, the property is optional. > > > + */ > > > + if (num_domains < 2 && pfdev->comp->num_pm_domains < 2) > > > + return 0; > > > + > > > + if (num_domains != pfdev->comp->num_pm_domains) { > > > + dev_err(pfdev->dev, > > > + "Incorrect number of power domains: %d provided, %d needed\n", > > > + num_domains, pfdev->comp->num_pm_domains); > > > + return -EINVAL; > > > + } > > > + > > > + if (WARN(num_domains > ARRAY_SIZE(pfdev->pm_domain_devs), > > > + "Too many supplies in compatible structure.\n")) > > > > Nitpick: > > Not sure this deserves a WARN. Perhaps a regular dev_err() is sufficient. > > Ah well I had a BUG_ON before so presumably this is already a little better ,-) > > You can only reach there if you set pfdev->comp->num_pm_domains > > MAX_PM_DOMAINS in the currently matched struct panfrost_compatible > (pfdev->comp->num_pm_domains == num_domains, and see below too), so > the kernel code would actually be actually broken (not the device > tree, nor anything that could be probed). So I'm wondering if the > loudness of a WARN is better in this case? Arguable ,-) I see. It's not a big a deal, so feel free to keep as is. [...] Kind regards Uffe _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek