From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DF3C35250 for ; Sun, 9 Feb 2020 07:49:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D950207FF for ; Sun, 9 Feb 2020 07:49:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DrQw7onj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="Xdf7emLA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="KyX/AKCi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D950207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zqj7f3lNL7AM7wfH7zfi7175BQctzQcmFbz4hGdNb1w=; b=DrQw7onjJlZWtB F5HImBbQttrxzLAD8UdQcn0AmXYIfg90JiKcYSdLxtJavjawFl1/ftCBoGOVUe/PliFQjFeMd5NX4 TyPfd/Gvlb0JvyOf0S6knCP30w6Tn/Mkg7VpMjzeu9x09bPf4VCTwpD+x4GNEvYRBNuqkGCPmcZ5m IXEKgy2BtiITEwgs7Sj1nw8i/74po9HocyvB6+H/YE7woPtypRV34UomS2DwFHVREiiHPqtZx60Id +/abqPVAPSsxhJ5234/2EqJDwJ3cR8ax35V8wVnkznvIelfOSs235/dPxh6lDrnblL2MTcpo4bEzT v61CTUS/XZzCTm3yIoAQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j0hKs-0004d8-2q; Sun, 09 Feb 2020 07:48:58 +0000 Received: from esa2.hgst.iphmx.com ([68.232.143.124]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j0hKk-0004YV-PO; Sun, 09 Feb 2020 07:48:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1581234551; x=1612770551; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=At9kaU6dhvsAg8nH3p10caC+DBQibDul+NDdCuPbgWk=; b=Xdf7emLADl82n7VL1VoQF/a2PJ8eJ2toMPo42xsHGql0AW6R1foUScXe s0O67tCpNxFK3PrFCyqMzxQmuhLW5IGTsS+hy6j3WTwiRosmWzbX/Q2Ni 8TuYW8a030J95lZegHKxKkMORfnbEu9XBeo7k+Z7tiagrCv2uYTCsV7BJ u3xgbTwxzpY4Ysiqvmm6oVQwe1JH8B/ooXULWknzx/f7UQk7ReOWWRzVT YMpEGTly2AVog4ZrNekOPARVUEltpNM0Jr9TCrRbrGfelgAVqD5KLXshq haJeWB3o/6P9q0p5K3rj9DYttDkmMAw68dvDi8CGgQkoOumeyle0zGgCd w==; IronPort-SDR: gGtsDolP0TGrEwxIr6HUpTE5yD1U8yv8M43ylMSS1x09rCYdulEhxLVRfDtAMzKwhiEh0DyAZ0 owb95LrAbkqr4Xg6Rq1SFf+XOXiWklIYODebkZn1pebcn2kIT5tH0cWbV7OPuS9nJbZCIPjT6e RC98bnlAauheN4JhM6+TqNEVIG14HOTkPGpmcgm4GZv8zzD7Btgy0ZbGmE82d7s2Bbbccwd9Og u2hA4Qz9quE6EANIqBxx7yx7VsmWNuCVNiP2HCf3lvVU6Np0RRptf+wDPg/9wKeJ9080TVznkg q2M= X-IronPort-AV: E=Sophos;i="5.70,420,1574092800"; d="scan'208";a="231219297" Received: from mail-bn7nam10lp2109.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.109]) by ob1.hgst.iphmx.com with ESMTP; 09 Feb 2020 15:48:55 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ND/DEUcT7pQBN894IVly6txf+I8fm73a6uJtMthhkwneX1K4vpUgILqk5B9VHot42vJs5Z64qdXMzzF/dORErV9TV1vMj2/dutkZNE/UlxaXIp2MwuXICTBq6qNcFerfRnBY2S7an/CZXW7fb1W5WBBfoUxeyL9KWBYjthZh+cC9Tr0b7RMstThKgVEE4EyXjJ8hQNQPTRI2S4FLrU6uy4bSXDvkERDZQ+jdC6w6fOxWd5pxI3V0VXw3VcltGtpw/GcGA6uqQNPzkRTgmbeC+R0kKSIrEr0/vefeNRuqo2yLB0V/9wRlEf3OhWsKzwcdvAe1BV+tLRE1r0InESyB/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AGESSIVYuSZhh1/v9pO5zFVMaqah/JUohDbv7uUfDhs=; b=QBru3cryp9Z5/sOTBZCxR09UEPwRFH9cWvxfzsnvVgvhf7FaaE4FskLx++aF/ZdETF9WVt945dKXKWMDgTWUFkx5mER5JPL48qMA4Dou1/nOAIWaQMVt+fpztQKG91aBQqty4uY1mmWhrcq5ApKE/X1j+KXEqzLtXj8JsoV1zKNGwS3Od3xOZhfn7QbLb5d//KkVpBgrgsZ8n/X4zHI/zyLM6VP/xJn7J6Eupeg1KiidfKowXfZEcDOzXtnjUsLwlhunIeRsaZ1iype7uMjtHIzLAkS/PNVn67MmqKHEHed9xUuh3XBqrDt6ZLX9VR9UNUc6RjbRXJJ+DG+fdxqS3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AGESSIVYuSZhh1/v9pO5zFVMaqah/JUohDbv7uUfDhs=; b=KyX/AKCiZGRblSSVVt86d2PVEznknpRom54/671ppjyeO9sUBCSNy536JOdDI8tcy0gAOSWU+35eChYi0/oA3vUOfP1vx9smwcF4cZnczBtI3pXUUl9mHp1D2NIUdJA5uOCt+Bfi/e5hG9U05WnjZszy/L8AVufHgiGK1zOgqq8= Received: from MN2PR04MB6991.namprd04.prod.outlook.com (10.186.144.209) by MN2PR04MB5726.namprd04.prod.outlook.com (20.179.21.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.24; Sun, 9 Feb 2020 07:48:37 +0000 Received: from MN2PR04MB6991.namprd04.prod.outlook.com ([fe80::3885:5fac:44af:5de7]) by MN2PR04MB6991.namprd04.prod.outlook.com ([fe80::3885:5fac:44af:5de7%7]) with mapi id 15.20.2707.028; Sun, 9 Feb 2020 07:48:37 +0000 From: Avri Altman To: Can Guo , "asutoshd@codeaurora.org" , "nguyenb@codeaurora.org" , "hongwus@codeaurora.org" , "rnayak@codeaurora.org" , "linux-scsi@vger.kernel.org" , "kernel-team@android.com" , "saravanak@google.com" , "salyzyn@google.com" Subject: RE: [PATCH 5/7] scsi: ufs: Fix ufshcd_hold() caused scheduling while atomic Thread-Topic: [PATCH 5/7] scsi: ufs: Fix ufshcd_hold() caused scheduling while atomic Thread-Index: AQHV3hnmgATiAPkOBk2rW7eA93U0SKgSfjAg Date: Sun, 9 Feb 2020 07:48:36 +0000 Message-ID: References: <1581123030-12023-1-git-send-email-cang@codeaurora.org> <1581123030-12023-6-git-send-email-cang@codeaurora.org> In-Reply-To: <1581123030-12023-6-git-send-email-cang@codeaurora.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Avri.Altman@wdc.com; x-originating-ip: [212.25.79.133] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f822112a-e7d7-4444-e322-08d7ad3478c9 x-ms-traffictypediagnostic: MN2PR04MB5726: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0308EE423E x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(366004)(396003)(376002)(136003)(346002)(39860400002)(199004)(189003)(8676002)(6506007)(33656002)(478600001)(26005)(54906003)(110136005)(8936002)(316002)(76116006)(66446008)(64756008)(66556008)(66476007)(66946007)(186003)(81156014)(81166006)(9686003)(86362001)(2906002)(71200400001)(55016002)(5660300002)(7416002)(52536014)(7696005)(4326008); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR04MB5726; H:MN2PR04MB6991.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HcM50yhcU3R1FXDxt7ACLfAyV22qIUlTF9MQyi3/hkeFB4M3dK2ASJh8zqbIpOdn+7fXutfCSvojRgw5FvR1IYdI9txYBd1EWJ/ipjywLELjo6t1522CBaAHL4GuE6zqWCy+icgOIYM9lvR7xmvaQfpuaKWpUh6p2gQ0VwbQk5QM+aehDdSEgZ2SPjFAiVOeobHFvCFvwCLjwCxFW4vle4OtrFJ7RD1l3dUhagYFo04GpVR1YKrzbrX7iyOYAAY5yS19q3EQonaSZsHZnv4bTX+rhjrdWrESPZ8J2u5izm0KMZ/n5UD060fcjv6QdfC2JEikVEdtDUhXwDRCjEzwVPI7IGcW1ySSZUsJ7fO9nB3bajLNBH440hclSeJWDJGPpSiJwLRmSomSaGMQ3yq5GeGqfbAaMQEBnyJHu9Ki9qMhbJwm7k3PfctQfd3vum3c x-ms-exchange-antispam-messagedata: JxiZLUeFm+9dFRGtRAXTjyQZNTuUpc7B5I8Kc1VunK/YFY/p+Ubp6VIZIBRQNEzYPYxr271NwBrbFLtgZen8zmYLeQGcKwNXUUsHNFwnJkcw6PPa22BpdZuu52D20lGes8aJq9V6EeNrsx05+v/m6Q== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: f822112a-e7d7-4444-e322-08d7ad3478c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2020 07:48:36.8752 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dI5cE8FmZagzBaGQ35IXmAFWNbKZl3R6Sj34BPJzgwZPVVNTaIqF/Nv45FvkHiCf7ExCdKxJVqZZOfGzbzl6AA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5726 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200208_234850_887274_8C0BAA66 X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bart Van Assche , "Martin K. Petersen" , Venkat Gopalakrishnan , "James E.J. Bottomley" , open list , "moderated list:ARM/Mediatek SoC support" , Alim Akhtar , Matthias Brugger , Tomas Winkler , Stanley Chu , "moderated list:ARM/Mediatek SoC support" , Bean Huo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org You didn't address any of my comments to this patch. Thanks, Avri > > The async version of ufshcd_hold(async == true), which is only called > in queuecommand path as for now, is expected to work in atomic context, > thus it should not sleep or schedule out. When it runs into the condition > that clocks are ON but link is still in hibern8 state, it should bail out > without flushing the clock ungate work. > > Signed-off-by: Can Guo > Reviewed-by: Hongwu Su > Reviewed-by: Asutosh Das > Reviewed-by: Bean Huo > Reviewed-by: Stanley Chu > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index bbc2607..e8f7f9d 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -1518,6 +1518,11 @@ int ufshcd_hold(struct ufs_hba *hba, bool async) > */ > if (ufshcd_can_hibern8_during_gating(hba) && > ufshcd_is_link_hibern8(hba)) { > + if (async) { > + rc = -EAGAIN; > + hba->clk_gating.active_reqs--; > + break; > + } > spin_unlock_irqrestore(hba->host->host_lock, flags); > flush_work(&hba->clk_gating.ungate_work); > spin_lock_irqsave(hba->host->host_lock, flags); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum, > a Linux Foundation Collaborative Project _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek