From: Mark Brown <broonie@kernel.org>
To: Alexandre Mergnat <amergnat@baylibre.com>
Cc: krzysztof.kozlowski@linaro.org, chen.zhong@mediatek.com,
devicetree@vger.kernel.org, dmitry.torokhov@gmail.com,
fparent@baylibre.com, krzysztof.kozlowski+dt@linaro.org,
lee@kernel.org, lgirdwood@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
robh+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 3/5] dt-bindings: regulator: Add binding schema for mt6357 regulators
Date: Tue, 11 Oct 2022 11:36:10 +0100 [thread overview]
Message-ID: <Y0VHGh/GavvuZY2A@sirena.org.uk> (raw)
In-Reply-To: <972ba839-2fd3-2b45-3477-0c7e3d32f149@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
On Tue, Oct 11, 2022 at 11:30:58AM +0200, Alexandre Mergnat wrote:
> > Why enforcing particular name of the regulator?
> The regulator names are forced to match with the datasheet names.
> I think it's a good practice to increase visibility between HW & SW.
> Also, that keep consistency with other Mediatek PMIC schema.
No, this is bad practice which completely misses the point of what the
names are for and the other Mediatek drivers are broken.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-11 10:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 14:57 [PATCH v2 0/5] Add MediaTek MT6357 PMIC support Alexandre Mergnat
2022-10-05 14:57 ` [PATCH v2 1/5] dt-bindings: mfd: mt6397: add binding for MT6357 Alexandre Mergnat
2022-10-24 12:51 ` Lee Jones
2022-10-05 14:57 ` [PATCH v2 2/5] dt-bindings: input: mtk-pmic-keys: add binding for MT6357 PMIC Alexandre Mergnat
2022-10-10 18:03 ` Dmitry Torokhov
2022-10-05 14:57 ` [PATCH v2 3/5] dt-bindings: regulator: Add binding schema for mt6357 regulators Alexandre Mergnat
2022-10-05 16:02 ` Krzysztof Kozlowski
2022-10-11 9:30 ` Alexandre Mergnat
2022-10-11 10:36 ` Mark Brown [this message]
2022-10-11 12:03 ` Krzysztof Kozlowski
2022-10-05 14:57 ` [PATCH v2 4/5] regulator: add mt6357 regulator Alexandre Mergnat
2022-10-05 15:09 ` Mark Brown
2022-10-06 10:12 ` AngeloGioacchino Del Regno
2022-10-05 14:57 ` [PATCH v2 5/5] Input: mtk-pmic-keys: add MT6357 support Alexandre Mergnat
2022-10-06 7:40 ` Mattijs Korpershoek
2022-10-06 10:12 ` AngeloGioacchino Del Regno
2022-10-10 18:04 ` Dmitry Torokhov
2022-10-24 12:50 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0VHGh/GavvuZY2A@sirena.org.uk \
--to=broonie@kernel.org \
--cc=amergnat@baylibre.com \
--cc=chen.zhong@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fparent@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).