From: Rob Herring <robh@kernel.org>
To: Zhiyong Tao <zhiyong.tao@mediatek.com>
Cc: linus.walleij@linaro.org, mark.rutland@arm.com,
matthias.bgg@gmail.com, sean.wang@kernel.org,
srv_heupstream@mediatek.com, hui.liu@mediatek.com,
eddie.huang@mediatek.com, light.hsieh@mediatek.com,
biao.huang@mediatek.com, hongzhou.yang@mediatek.com,
sean.wang@mediatek.com, seiya.wang@mediatek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v11 2/4] dt-bindings: pinctrl: mt8195: change pull up/down description
Date: Tue, 31 Aug 2021 17:13:00 -0500 [thread overview]
Message-ID: <YS6pbO4hmNyX//tP@robh.at.kernel.org> (raw)
In-Reply-To: <20210830003603.31864-3-zhiyong.tao@mediatek.com>
On Mon, Aug 30, 2021 at 08:36:01AM +0800, Zhiyong Tao wrote:
> Change pull up/down description
Every commit is a 'change'. Your commit msg should explain 'why', not
what the diff is.
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> ---
> .../bindings/pinctrl/pinctrl-mt8195.yaml | 32 +++++++++++++++++--
> 1 file changed, 29 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> index 2f12ec59eee5..a341ed9f0095 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> @@ -85,9 +85,35 @@ patternProperties:
> 2/4/6/8/10/12/14/16mA in mt8195.
> enum: [0, 1, 2, 3, 4, 5, 6, 7]
>
> - bias-pull-down: true
> -
> - bias-pull-up: true
> + bias-pull-down:
> + description: |
> + For pull down type is normal, it don't need add RSEL & R1R0 define
> + and resistance value.
> + For pull down type is PUPD/R0/R1 type, it can add R1R0 define to
> + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" &
> + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11"
> + define in mt8195.
> + For pull down type is RSEL, it can add RSEL define & resistance value(ohm)
> + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" &
> + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" &
> + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" &
> + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm)
> + "75000" & "5000" in mt8195.
Sounds like constraints on the values. Please write a schema.
> +
> + bias-pull-up:
> + description: |
> + For pull up type is normal, it don't need add RSEL & R1R0 define
> + and resistance value.
> + For pull up type is PUPD/R0/R1 type, it can add R1R0 define to
> + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" &
> + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11"
> + define in mt8195.
> + For pull up type is RSEL, it can add RSEL define & resistance value(ohm)
> + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" &
> + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" &
> + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" &
> + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm)
> + "1000" & "1500" & "2000" & "3000" & "4000" & "5000" & "10000" & "75000" in mt8195.
>
> bias-disable: true
>
> --
> 2.18.0
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-08-31 22:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 0:35 [PATCH v11 0/4] Mediatek pinctrl patch on mt8195 Zhiyong Tao
2021-08-30 0:36 ` [PATCH v11 1/4] dt-bindings: pinctrl: mt8195: add rsel define Zhiyong Tao
2021-08-31 22:09 ` Rob Herring
2021-09-01 4:35 ` Chen-Yu Tsai
2021-09-02 2:54 ` zhiyong.tao
2021-09-02 3:35 ` Chen-Yu Tsai
2021-09-04 8:40 ` zhiyong.tao
2021-09-06 8:20 ` Chen-Yu Tsai
2021-09-09 6:46 ` zhiyong.tao
2021-09-14 12:27 ` zhiyong.tao
2021-09-15 3:25 ` Chen-Yu Tsai
2021-08-30 0:36 ` [PATCH v11 2/4] dt-bindings: pinctrl: mt8195: change pull up/down description Zhiyong Tao
2021-08-31 22:13 ` Rob Herring [this message]
2021-09-01 2:00 ` zhiyong.tao
2021-09-01 10:21 ` Chen-Yu Tsai
2021-09-02 3:31 ` zhiyong.tao
2021-08-30 0:36 ` [PATCH v11 3/4] pinctrl: mediatek: mt8195: Add pm_ops Zhiyong Tao
2021-08-31 7:53 ` Chen-Yu Tsai
2021-08-31 9:11 ` zhiyong.tao
2021-08-30 0:36 ` [PATCH v11 4/4] pinctrl: mediatek: add rsel setting on MT8195 Zhiyong Tao
2021-09-01 10:10 ` Chen-Yu Tsai
2021-09-06 3:17 ` zhiyong.tao
2021-09-06 10:09 ` Chen-Yu Tsai
2021-09-09 7:46 ` zhiyong.tao
2021-09-16 9:31 ` zhiyong.tao
2021-09-16 9:40 ` Chen-Yu Tsai
2021-09-17 2:10 ` zhiyong.tao
2021-09-19 19:33 ` Linus Walleij
2021-09-22 1:47 ` zhiyong.tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS6pbO4hmNyX//tP@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=biao.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=hongzhou.yang@mediatek.com \
--cc=hui.liu@mediatek.com \
--cc=light.hsieh@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).