From: Greg KH <gregkh@linuxfoundation.org>
To: DENG Qingfang <dqfext@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Matthias Brugger <matthias.bgg@gmail.com>,
"open list:MEDIATEK SWITCH DRIVER" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 4.19.y] net: dsa: mt7530: disable learning on standalone ports
Date: Fri, 27 Aug 2021 12:19:23 +0200 [thread overview]
Message-ID: <YSi8Ky3GqBjnxbhC@kroah.com> (raw)
In-Reply-To: <CALW65ja3hYGmEqcWZzifP2-0WsJOnxcUXsey2ZH5vDbD0-nDeQ@mail.gmail.com>
On Tue, Aug 24, 2021 at 11:57:53PM +0800, DENG Qingfang wrote:
> Hi Sasha,
>
> On Tue, Aug 24, 2021 at 11:29 PM Sasha Levin <sashal@kernel.org> wrote:
> > What's the reasoning behind:
> >
> > 1. Backporting this patch?
>
> Standalone ports should have address learning disabled, according to
> the documentation:
> https://www.kernel.org/doc/html/v5.14-rc7/networking/dsa/dsa.html#bridge-layer
> dsa_switch_ops on 5.10 or earlier does not have .port_bridge_flags
> function so it has to be done differently.
>
> I've identified an issue related to this.
What issue is that? Where was it reported?
> > 2. A partial backport of this patch?
>
> The other part does not actually fix anything.
Then why is it not ok to just take the whole thing?
When backporting not-identical-patches, something almost always goes
wrong, so we prefer to take the original commit when ever possible.
thanks,
greg k-h
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-08-27 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 5:55 [PATCH 4.19.y] net: dsa: mt7530: disable learning on standalone ports DENG Qingfang
2021-08-24 15:29 ` Sasha Levin
2021-08-24 15:57 ` DENG Qingfang
2021-08-27 10:19 ` Greg KH [this message]
2021-09-02 5:36 ` DENG Qingfang
2021-09-02 5:58 ` Greg KH
2021-09-03 9:14 ` DENG Qingfang
2021-09-07 15:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSi8Ky3GqBjnxbhC@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=stable@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).