Re: [PATCH v10 1/3] dt-binding: mt8183: add Mediatek MDP3 dt-bindings

From: Rob Herring <robh@kernel.org>
To: Moudy Ho <moudy.ho@mediatek.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	 Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	 Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	 Rob Landley <rob@landley.net>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	 linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	 linux-kernel@vger.kernel.org,
	Alexandre Courbot <acourbot@chromium.org>,
	tfiga@chromium.org,  drinkcat@chromium.org, pihsun@chromium.org,
	hsinyi@google.com,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	 Maoguang Meng <maoguang.meng@mediatek.com>,
	daoyuan huang <daoyuan.huang@mediatek.com>,
	 Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
	menghui.lin@mediatek.com, sj.huang@mediatek.com,
	 allen-kh.cheng@mediatek.com, randy.wu@mediatek.com,
	jason-jh.lin@mediatek.com,  roy-cw.yeh@mediatek.com,
	river.cheng@mediatek.com,  srv_heupstream@mediatek.com
Subject: Re: [PATCH v10 1/3] dt-binding: mt8183: add Mediatek MDP3 dt-bindings
Date: Fri, 10 Dec 2021 12:17:21 -0600	[thread overview]
Message-ID: <YbOZsd+zNmwOpB4x@robh.at.kernel.org> (raw)
In-Reply-To: <20211202062733.20338-2-moudy.ho@mediatek.com>

On Thu, Dec 02, 2021 at 02:27:31PM +0800, Moudy Ho wrote:
> This patch adds DT binding document for Media Data Path 3 (MDP3)
> a unit in multimedia system used for scaling and color format convert.
> 
> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> ---
>  .../bindings/media/mediatek,mdp3-rsz.yaml     |  65 ++++++
>  .../bindings/media/mediatek,mdp3-wrot.yaml    |  67 ++++++
>  .../bindings/soc/mediatek/mediatek,ccorr.yaml |  57 +++++
>  .../bindings/soc/mediatek/mediatek,rdma.yaml  | 216 ++++++++++++++++++
>  .../bindings/soc/mediatek/mediatek,wdma.yaml  |  68 ++++++
>  5 files changed, 473 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
>  create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,ccorr.yaml
>  create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,rdma.yaml
>  create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,wdma.yaml

I'm not a fan of bindings/soc/ either. Put everything in 
bindings/media/. What's the difference between these blocks here and 
the version used for display? If they are the same h/w, then the binding 
needs to be the same. How they get used is the kernel's problem. 

It looks like the display ccorr, rdma, and wdma aren't documented. Fix 
that before you add new stuff.

> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
> new file mode 100644
> index 000000000000..d7f104a0f165
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek,mdp3-rsz.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek Resizer
> +
> +maintainers:
> +  - Matthias Brugger <matthias.bgg@gmail.com>
> +
> +description: |
> +  One of Media Data Path 3 (MDP3) components used to do frame resizing.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - mediatek,mt8183-mdp3-rsz
> +
> +  mediatek,mdp3-id:
> +    description: There may be multiple components with the same function but
> +      different addresses in MDP3. The MDP3 driver can select one or zero of
> +      them and connect other components in series according to the current
> +      application to form one or more data paths. This property indicate the
> +      selection order of the same components.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [0, 1, 2, 3]

Again, an index nor an alias is the right approach for this. Use DT 
graph like others do. 'It's too complicated' is not a reason unless you 
show how and why it won't work.

Rob

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek