linux-mediatek.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Paul Walmsley <paul.walmsley@sifive.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
	"pgaikwad@nvidia.com" <pgaikwad@nvidia.com>,
	"heiko@sntech.de" <heiko@sntech.de>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"chunhui.dai@mediatek.com" <chunhui.dai@mediatek.com>,
	Yangtao Li <tiny.windzz@gmail.com>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
	"nsekhar@ti.com" <nsekhar@ti.com>,
	"tomasz.figa@gmail.com" <tomasz.figa@gmail.com>,
	"rfontana@redhat.com" <rfontana@redhat.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	"weiyongjun1@huawei.com" <weiyongjun1@huawei.com>,
	"krzk@kernel.org" <krzk@kernel.org>,
	"s.nawrocki@samsung.com" <s.nawrocki@samsung.com>,
	"manivannan.sadhasivam@linaro.org"
	<manivannan.sadhasivam@linaro.org>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"emilio@elopez.com.ar" <emilio@elopez.com.ar>,
	"linux-realtek-soc@lists.infradead.org"
	<linux-realtek-soc@lists.infradead.org>,
	"allison@lohutok.net" <allison@lohutok.net>,
	Fabien DESSENNE <fabien.dessenne@st.com>,
	"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
	"cw00.choi@samsung.com" <cw00.choi@samsung.com>,
	"wens@csie.org" <wens@csie.org>,
	"agross@kernel.org" <agross@kernel.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"Eugeniy.Paltsev@synopsys.com" <Eugeniy.Paltsev@synopsys.com>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"swinslow@gmail.com" <swinslow@gmail.com>,
	"john@phrozen.org" <john@phrozen.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	Paul Walmsley <paul@pwsan.com>, James Tai <james.tai@realtek.com>,
	Cheng-Yu Lee <cylee12@realtek.com>,
	"jcmvbkbc@gmail.com" <jcmvbkbc@gmail.com>,
	"sboyd@kernel.org" <sboyd@kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"pdeschrijver@nvidia.com" <pdeschrijver@nvidia.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"t-kristo@ti.com" <t-kristo@ti.com>,
	"dinguyen@kernel.org" <dinguyen@kernel.org>,
	"kgene@kernel.org" <kgene@kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"wangyan.wang@mediatek.com" <wangyan.wang@mediatek.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>
Subject: Re: [PATCH 08/17] clk: imx: convert to devm_platform_ioremap_resource
Date: Wed, 11 Dec 2019 14:49:06 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.21.9999.1912111411120.73923@viisi.sifive.com> (raw)
In-Reply-To: <76d72777-b144-0679-1f4c-1136496a5f06@suse.de>

[-- Attachment #1: Type: text/plain, Size: 1758 bytes --]

On Wed, 11 Dec 2019, Andreas Färber wrote:

> Blocks do have names, but they don't always group registers of the same
> kind, as Linux expects it

Linux does not expect that all of the registers in the same IP block are 
of the same kind.  That's part of the reason why Linux frameworks exist.  
To consider clocks as the present example, you're welcome to register 
local IP block clock control registers in the local IP block driver via 
the clock framework.  There's no need for a separate clock driver with an 
overlapping address range, or anything like that.

This is nothing new with Realtek.  IP blocks that contain many different 
kinds of registers have had Linux driver support without requiring 
overlapping register address ranges long before Realtek ARM SoCs 
appeared.

> Just please accept that hardware does not always allow for unique 
> contiguous memory reservations

Hardware designs do in fact mandate unique contiguous memory reservations, 
otherwise address decoding would be indeterministic.  What they don't 
mandate is that all of the registers in that region be all of one kind. 
It's certainly possible to have an SoC with one giant IP block with all 
registers mixed together.  Even in that case, it is still incorrect to 
have multiple DT entries with overlapping register address ranges.

It sounds like you're thinking of the difficulties of figuring out how to 
structure the software driver support for those mixed IP block as a Linux 
driver: where it would fit in the tree, what frameworks it would need to 
register with, and who would maintain it.  Those issues certainly merit 
careful thought and consideration.  They aren't related to multiple 
overlapping address ranges.


- Paul

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2019-12-11 22:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 19:57 [PATCH 01/17] clk: sunxi: sunxi-ng: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-09 19:57 ` [PATCH 02/17] clk: qcom: " Yangtao Li
2019-12-09 19:57 ` [PATCH 03/17] clk: samsung: " Yangtao Li
2019-12-10  2:10   ` Chanwoo Choi
2019-12-09 19:57 ` [PATCH 04/17] clk: mediatek: " Yangtao Li
2019-12-09 19:57 ` [PATCH 05/17] clk: hisilicon: " Yangtao Li
2019-12-09 19:57 ` [PATCH 06/17] clk: tegra: " Yangtao Li
2019-12-11  9:49   ` Peter De Schrijver
2019-12-09 19:57 ` [PATCH 07/17] clk: mvebu: " Yangtao Li
2019-12-09 19:57 ` [PATCH 08/17] clk: imx: " Yangtao Li
2019-12-09 20:44   ` Leonard Crestez
2019-12-10 13:21     ` Thierry Reding
2019-12-10 14:57       ` Andreas Färber
2019-12-10 15:10         ` mripard
2019-12-11 17:57         ` Paul Walmsley
2019-12-11 19:54           ` Andreas Färber
2019-12-11 22:49             ` Paul Walmsley [this message]
2019-12-12  5:38               ` Andreas Färber
2019-12-12  6:40                 ` Thierry Reding
2019-12-11 17:51       ` Paul Walmsley
2019-12-11 18:38         ` Leonard Crestez
2019-12-10 20:37     ` Frank Lee
2019-12-09 19:57 ` [PATCH 09/17] clk: sifive: " Yangtao Li
2019-12-09 19:57 ` [PATCH 10/17] clk: axi-clkgen: " Yangtao Li
2019-12-09 19:57 ` [PATCH 11/17] clk: milbeaut: " Yangtao Li
2019-12-09 19:57 ` [PATCH 12/17] clk: socfpga: " Yangtao Li
2019-12-16 20:20   ` Dinh Nguyen
2019-12-09 19:57 ` [PATCH 13/17] clk: gemini: " Yangtao Li
2019-12-09 19:57 ` [PATCH 14/17] clk: axm5516: " Yangtao Li
2019-12-09 19:57 ` [PATCH 15/17] clk: bm1880: " Yangtao Li
2019-12-09 19:57 ` [PATCH 16/17] clk: actions: " Yangtao Li
2019-12-09 19:57 ` [PATCH 17/17] ARC: clk: " Yangtao Li
2019-12-13  8:05 ` [PATCH 01/17] clk: sunxi: sunxi-ng: " Chen-Yu Tsai
2020-01-31  1:06 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.9999.1912111411120.73923@viisi.sifive.com \
    --to=paul.walmsley@sifive.com \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=afaerber@suse.de \
    --cc=agross@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=allison@lohutok.net \
    --cc=chunhui.dai@mediatek.com \
    --cc=cw00.choi@samsung.com \
    --cc=cylee12@realtek.com \
    --cc=daniel.baluta@nxp.com \
    --cc=dinguyen@kernel.org \
    --cc=emilio@elopez.com.ar \
    --cc=fabien.dessenne@st.com \
    --cc=festevam@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=james.tai@realtek.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=john@phrozen.org \
    --cc=jonathanh@nvidia.com \
    --cc=kernel@pengutronix.de \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-realtek-soc@lists.infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=matthias.bgg@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=nsekhar@ti.com \
    --cc=paul@pwsan.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=rfontana@redhat.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=swinslow@gmail.com \
    --cc=t-kristo@ti.com \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=tiny.windzz@gmail.com \
    --cc=tomasz.figa@gmail.com \
    --cc=wangyan.wang@mediatek.com \
    --cc=weiyongjun1@huawei.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).