From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C627AC55186 for ; Thu, 23 Apr 2020 01:21:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92A8E2075A for ; Thu, 23 Apr 2020 01:21:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AN0tLy/5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92A8E2075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pZen7Pfm2vQoWVPhxudiOR86UYZ5iFVVEYg973n8xl8=; b=AN0tLy/5OP+zjjhngz/1V4ZQV wMSRSLkP+/lLhRaNzT1nqoEExg+itIqhwYXle6HCFtqq/wyaDeFQKKpbT1gK6Z4ahJuUawCkJ1tpj BU28EXxKDTLCxEb39P1OIz05qzWbeO7YZfGWa97723iczufpCfXXYPMD+JiwJP8zOhm36EdFZ+v5V kljEeLmYEhulL/XYhsQUhnT4A9ys5hYG8B6pYXGFkrzNCDaawInBDBjLQNfe8eU6usF7rAESd+fdy Tmvh17R63ls5eZysXI9jjWr/YipHwOslzNMAxhJBqAQEZnBynMSFwEto8T0PjwA8k2FIRWMIxtESt Ia6h95l7Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRQYL-0007Cz-4N; Thu, 23 Apr 2020 01:21:21 +0000 Received: from mail-pg1-f194.google.com ([209.85.215.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRQYI-0007BL-CE; Thu, 23 Apr 2020 01:21:19 +0000 Received: by mail-pg1-f194.google.com with SMTP id x26so2030042pgc.10; Wed, 22 Apr 2020 18:21:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HuA0hxQTe90PJtZs9WSSy8kDWUbxSlnvi9VsPza7S2Y=; b=ZDTujw6fZ5jY3XQ65wjFG3v3OifNL8dO72xLpax9866UPGEHX+COqqw8MbkahcsvKK +YsqnpA8Ehg+MZn+MG5eYsYvN5OsFOBCjiedGHVCXf4UKWL5NxqksXplCpV3Zc5x7OMa NRONt1Ytv3x8F4tiCbsBGVvEDTdGr4+iS2c7Fu+HkLzQzARQCTzqcjsXaXRvbmAoRajw ITyL8J4FoZ6XgaTCUKjOEkCmIOoHocqNy6GAYEdz3atKIJxKKM7ZzdbQFOtaa7U+acbB UUe2UZwurfNkZ35YUBl9Y6Vw9p7kGHy3h26j7F0bm9fKXT8cZWwxE4/HdhLvtamz5qBq Y0Hw== X-Gm-Message-State: AGi0PuZrSeekER0SbnDA//1TTcYQFU/GcTgR55vmu4fibCDU12yAJpJu j+1X7JfhuGmqtyIMIzspyxs= X-Google-Smtp-Source: APiQypKxBlGRT0F6vEFPhi5oneOUM697xMXU65q00ggKMra7UIbFqy/Kx++vjPJ34SrVHIxn8OpClA== X-Received: by 2002:aa7:80cf:: with SMTP id a15mr1441540pfn.124.1587604876968; Wed, 22 Apr 2020 18:21:16 -0700 (PDT) Received: from [100.124.12.67] ([104.129.198.222]) by smtp.gmail.com with ESMTPSA id n23sm471545pjq.18.2020.04.22.18.21.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2020 18:21:16 -0700 (PDT) Subject: Re: [PATCH v2] stacktrace: cleanup inconsistent variable type To: Walter Wu , Matthias Brugger , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , Josh Poimboeuf , Andrew Morton References: <20200421013511.5960-1-walter-zh.wu@mediatek.com> From: Bart Van Assche Message-ID: Date: Wed, 22 Apr 2020 18:21:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200421013511.5960-1-walter-zh.wu@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200422_182118_418106_091EF4D1 X-CRM114-Status: GOOD ( 11.39 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mm@kvack.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wsd_upstream Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 4/20/20 6:35 PM, Walter Wu wrote: > Modify the variable type of 'skip' member of struct stack_trace. > In theory, the 'skip' variable type should be unsigned int. > There are two reasons: > - The 'skip' only has two situation, 1)Positive value, 2)Zero > - The 'skip' of struct stack_trace has inconsistent type with struct > stack_trace_data, it makes a bit confusion in the relationship between > struct stack_trace and stack_trace_data. Reviewed-by: Bart Van Assche _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek