From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB61AC17447 for ; Wed, 13 Nov 2019 09:54:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C07A120818 for ; Wed, 13 Nov 2019 09:54:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rGIchx3x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C07A120818 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nwC7j82t+2Nb4XhYQIkBG2G6u0lHTlVz6xRPsp6Rbv0=; b=rGIchx3xHx8MOz QC6iCkCduNOYZYdN07LPT+r/kJxWQuUZUs2g0rQeGQG9r2rN2D8uIpiZd0HmC6tbamWOseMCCr5h9 AoRtOptS2+MhFN8Pp5foBFenG5zzmF92o4uMhBmRUFIHviiILuSmcI3ImgheMvTkBAMQLZvVARcZg MurI9CDAJZxMMn1pcqOtjow1ku6JHk+EvCl6sbJmbVCWhxGsS+g5aCceLLhDYGxo1a90szVf/b0MY UO5sKhuXYe7yvLeqvU39V13iufIhrxFuoMUJQixh5iHhK99R6FoYBC5Gun/yoANGlkipeC3F0iOJ8 YQDpH3HjzTGfeU9a6W3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUpLT-0005qO-0M; Wed, 13 Nov 2019 09:53:51 +0000 Received: from mailgate1.rohmeurope.com ([178.15.145.194]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUpLI-0005jF-7H; Wed, 13 Nov 2019 09:53:41 +0000 X-AuditID: c0a8fbf4-199ff70000001fa6-4f-5dcbd29e1ef3 Received: from smtp.reu.rohmeu.com (will-cas002.reu.rohmeu.com [192.168.251.178]) by mailgate1.rohmeurope.com (Symantec Messaging Gateway) with SMTP id AB.1A.08102.E92DBCD5; Wed, 13 Nov 2019 10:53:35 +0100 (CET) Received: from WILL-MAIL002.REu.RohmEu.com ([fe80::e0c3:e88c:5f22:d174]) by WILL-CAS002.REu.RohmEu.com ([fe80::fc24:4cbc:e287:8659%12]) with mapi id 14.03.0439.000; Wed, 13 Nov 2019 10:53:30 +0100 From: "Vaittinen, Matti" To: "linus.walleij@linaro.org" Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION Thread-Topic: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION Thread-Index: AQHVmWQOgs5cHlsmlU+Vdtkf5ZbC06eIlAaAgAAGWoCAAC7LgIAAA7CA Date: Wed, 13 Nov 2019 09:53:29 +0000 Message-ID: References: <20191112141819.GA22076@localhost.localdomain> <201911131438.KT6pnFZ7%lkp@intel.com> In-Reply-To: Accept-Language: en-US, de-DE Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [213.255.186.46] Content-ID: <8D9C4E9DDE4F5A4F822964BEFBCFD58A@de.rohmeurope.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA01Tf0wbVRzPu7tejx9HjlLggc7EJjrdwubijG/JtkD8dTNmGS7GOK14kxsl 9gdpiykaYxmbpCVuA4mGrgxdgZF16NYyYQQHtMjqaq1rpYiUbAU2KWYlMyqpQ/BuZYO/3ue9 z6/vH99H4bJr0kKqUmvk9VpOrSDTiaGuu66itpBf+VTITaCfZu4SqD7RKUUXZv0ABac8OOr+ 9HsC+QcTBBqqDQP0b2JEilpPNgFk76pBK9N/SFBte5hAgYYIQM1LZzDkmolIUONgQIrcbUsA hfvtJArXXQPIn3Ti6GI8gaE/b6zgqHHyvBRZI7MSNF83TaK57nEJOnzkaWTv8BHo1H/dEuQ5 9ibqdX+FI7tvDKDjjhCBbra4SZRwzgL02dd70EKyBF3xWXCU9ASx4o3s4YVRkl349aiUPXXu Q9Z2PUCyzlA9yZ6fdkrYxkARe8k2JWUdrkGSbbMsYqxjII6xrrMWkjUPBQk2Ghkg2YaTywTr bv94X96BjJ0HOeP7+ysrtFt3v5OhCnsvkFXRXFP41gJuBs25VpBGQWY7XL4RwKwgnZIxYwC6 I52rFx+ArZ1uYAUURTI7oXVCKhrkzA7o9dkJEeNMUzac9z4h4hxmF5z8JESKcjmzG7p7MlLy F2FzkwUTMcE8BtvPJO7F0Mxe2OYYlaSq7gA4PncTiEQaUwq/tZvv5QNmA7SYE1iqKx+6bi1K UkMzsH0giKdwLozPLK++K+B3yRghzoAzT8Jv+remYDH83AFTKY/C5obY6gjZ8IeWWeIEyLOt K7CtmW1rZts6s22d+UsgOQughqtUV3BGftsWPV+9Ra9TaYTjXZ3GBVIr+lcfWPHs8QCMAh5Q QGGKXLq3zq+UZR3UldeoOIOqTF+t5g0eAClcIaf7TD6ljC7naj7g9br71EMUocinN8YalTJG 7HqP56t4/X32YYpSQPqFESE0W89X8KZDlWrjGo1RaWJ4eqHcwGvLeT1XbVSVictRZhC2Q6Qy hd6JnwU7bajiNMJrynoVbKZOxFtP49RIa8dpXEZodVq+MJ8uFaWMKFVVax8UzYN8Cihy6O6g wGYK//RBzrxQgQkVR7xXxQojt0YVmkHWI75XN/32z2uFw8+WevYnc+Z+p3+JXZ45Gl0aL4km zT9qPzKNqt/qTy8nlDvennzl+ERM/1LDF8NO9+X+kucUB5r6ZNc3345SFwfleduvPNPz8uPF BWneiZzhor1jmcOu1y/1ZD0/ZDr0RkHvbY1uV0d9X+056bE7yrhnQ9dUy9+L9UkFYVBx2zbh egP3P0by8N9kBAAA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191113_015340_415003_897A1C8A X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "andrew@lunn.ch" , "alexandre.belloni@bootlin.com" , "heiko@sntech.de" , "geert+renesas@glider.be" , "narmstrong@baylibre.com" , "patrice.chotard@st.com" , "paul@crapouillou.net" , "eric@anholt.net" , "linux-stm32@st-md-mailman.stormreply.com" , "jason@lakedaemon.net" , "f.fainelli@gmail.com" , "lkp@intel.com" , "gregory.clement@bootlin.com" , "ludovic.desroches@microchip.com" , "linux-rockchip@lists.infradead.org" , "wens@csie.org" , "agross@kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "rjui@broadcom.com" , "sebastian.hesselbarth@gmail.com" , "alexandre.torgue@st.com" , "mazziesaccount@gmail.com" , "linux-arm-msm@vger.kernel.org" , "nicolas.ferre@microchip.com" , "linux-gpio@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-rpi-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "bjorn.andersson@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "kbuild-all@lists.01.org" , "sbranden@broadcom.com" , "sean.wang@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "wahrenst@gmx.net" , "mcoquelin.stm32@gmail.com" , "linux-oxnas@groups.io" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hello Linus, On Wed, 2019-11-13 at 10:40 +0100, Linus Walleij wrote: > On Wed, Nov 13, 2019 at 7:52 AM Vaittinen, Matti > wrote: > > On Wed, 2019-11-13 at 14:30 +0800, kbuild test robot wrote: > > > Hi Matti, > > > > > > Thank you for the patch! Perhaps something to improve: > > > > > > [auto build test WARNING on > > > 70d97e099bb426ecb3ad4bf31e88dbf2ef4b2e4c] > > > > > > 480 static int wmt_gpio_get_direction(struct gpio_chip > > > *chip, unsigned offset) > > > 481 { > > > 482 struct wmt_pinctrl_data *data = > > > gpiochip_get_data(chip); > > > 483 u32 bank = WMT_BANK_FROM_PIN(offset); > > > 484 u32 bit = WMT_BIT_FROM_PIN(offset); > > > 485 u32 reg_dir = data->banks[bank].reg_dir; > > > 486 u32 val; > > > 487 > > > 488 val = readl_relaxed(data->base + reg_dir); > > > 489 if (val & BIT(bit)) > > > > 490 GPIO_LINE_DIRECTION_OUT; > > > > Right. Return is missing. I think I already fixed this - I guess I > > sent > > wrong version... Sorry guys. I'll do v3 with only this return added It appears I didn't send wrong patch. The whole wmt was left uncompiled as the folder was excluded from my build by arch and I didn't spot that. So I'll humbly raise my arm as a sign of an error ;) > > - > > and I'll send it to limited amount of recipients as I think most of > > you > > guys may not be interested. Probably to Linus W, Geert and GPIO > > list > > only. Let me know if you want to see the v3 (or other subsequent > > patches) > > I think I already merged it, just send a new patch on top fixing the > problem. Hmmm. I don't think I received notification about the patch being applied... But in that case, please ignore v2 I sent some time ago - I'll do a fix patch on top of the already applied one then. I'll send it out soon(ish). Br, Matti _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek