From: Matthias Brugger <matthias.bgg@gmail.com>
To: Maxim Kutnij <gtk3@inbox.ru>, Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: mediatek: dts: activate SMP for mt6582
Date: Fri, 31 Dec 2021 16:51:20 +0100 [thread overview]
Message-ID: <dda186e0-38e0-4061-f60e-e297441d9fed@gmail.com> (raw)
In-Reply-To: <20211230155152.48715-2-gtk3@inbox.ru>
On 12/30/21 16:51, Maxim Kutnij wrote:
> This patch adds nodes mt6589-smp, pmu and arm,armv7-timer.
>
> Signed-off-by: Maxim Kutnij <gtk3@inbox.ru>
> ---
> arch/arm/boot/dts/mt6582.dtsi | 35 ++++++++++++++++++++++++++++++-----
> 1 file changed, 30 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/mt6582.dtsi b/arch/arm/boot/dts/mt6582.dtsi
> index 4263371784c..5efcbf43325 100644
> --- a/arch/arm/boot/dts/mt6582.dtsi
> +++ b/arch/arm/boot/dts/mt6582.dtsi
> @@ -15,29 +15,43 @@ / {
> cpus {
> #address-cells = <1>;
> #size-cells = <0>;
> + enable-method = "mediatek,mt6589-smp";
>
> - cpu@0 {
> + cpu0: cpu@0 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x0>;
> + clock-frequency = <1300000000>;
What do we need the clock-frequency for? I wasn't able to figure that
out right now.
Other then that patches look good.
Regards,
Matthias
> };
> - cpu@1 {
> + cpu1: cpu@1 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x1>;
> + clock-frequency = <1300000000>;
> };
> - cpu@2 {
> + cpu2: cpu@2 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x2>;
> + clock-frequency = <1300000000>;
> };
> - cpu@3 {
> + cpu3: cpu@3 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x3>;
> + clock-frequency = <1300000000>;
> };
> };
>
> + pmu {
> + compatible = "arm,cortex-a7-pmu";
> + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 5 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 6 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
> + };
> +
> system_clk: dummy13m {
> compatible = "fixed-clock";
> clock-frequency = <13000000>;
> @@ -56,7 +70,18 @@ uart_clk: dummy26m {
> #clock-cells = <0>;
> };
>
> - timer: timer@11008000 {
> + timer {
> + compatible = "arm,armv7-timer";
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> + clock-frequency = <13000000>;
> + arm,cpu-registers-not-fw-configured;
> + };
> +
> + timer: timer@10008000 {
> compatible = "mediatek,mt6577-timer";
> reg = <0x10008000 0x80>;
> interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_LOW>;
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-12-31 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 15:51 [PATCH 1/2] ARM: mediatek: add smp bringup code for MT6582 Maxim Kutnij
2021-12-30 15:51 ` [PATCH 2/2] ARM: mediatek: dts: activate SMP for mt6582 Maxim Kutnij
2021-12-31 15:51 ` Matthias Brugger [this message]
2022-01-01 13:05 ` [PATCH 1/2] ARM: mediatek: add smp bringup code for MT6582 Maxim Kutnij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dda186e0-38e0-4061-f60e-e297441d9fed@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gtk3@inbox.ru \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).