From: "Trevor Wu (吳文良)" <Trevor.Wu@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"tiwai@suse.com" <tiwai@suse.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 12/12] dt-bindings: mediatek: mt8188: add mt8188-mt6359 document
Date: Thu, 6 Oct 2022 02:38:26 +0000 [thread overview]
Message-ID: <e96ef77f007f66f883f8dca86d1206cd1b5a767a.camel@mediatek.com> (raw)
In-Reply-To: <20221003163851.GA2414624-robh@kernel.org>
On Mon, 2022-10-03 at 11:38 -0500, Rob Herring wrote:
> On Fri, Sep 30, 2022 at 10:57:01PM +0800, Trevor Wu wrote:
> > Add document for mt8188 board with mt6359.
> >
> > Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
> > ---
> > .../bindings/sound/mt8188-mt6359.yaml | 70
> > +++++++++++++++++++
> > 1 file changed, 70 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/mt8188-
> > mt6359.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/mt8188-
> > mt6359.yaml b/Documentation/devicetree/bindings/sound/mt8188-
> > mt6359.yaml
> > new file mode 100644
> > index 000000000000..57c7c5ceef8a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml
> > @@ -0,0 +1,70 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mt8188-mt6359.yaml*__;Iw!!CTRNKA9wMg0ARbw!wMc6I2aXRzI45UPQTEAzU4ZujV6VaiFGkiKBy18A_5DlQehTxU00u1QSpiOzgAgKtA$
> >
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!wMc6I2aXRzI45UPQTEAzU4ZujV6VaiFGkiKBy18A_5DlQehTxU00u1QSpiMSKPWbtQ$
> >
> > +
> > +title: MediaTek MT8188 ASoC sound card driver
> > +
> > +maintainers:
> > + - Trevor Wu <trevor.wu@mediatek.com>
> > +
> > +description:
> > + This binding describes the MT8188 sound card.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt8188-sound
> > +
> > + model:
> > + $ref: /schemas/types.yaml#/definitions/string
> > + description: User specified audio sound card name
> > +
> > + audio-routing:
> > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> > + description:
> > + A list of the connections between audio components. Each
> > entry is a
> > + sink/source pair of strings. Valid names could be the input
> > or output
> > + widgets of audio components, power supplies, MicBias of
> > codec and the
> > + software switch.
> > +
> > + mediatek,platform:
> > + $ref: "/schemas/types.yaml#/definitions/phandle"
>
> Don't need quotes.
Hi Rob,
Which one are you expected?
1. remove the line
2. $ref: /schemas/types.yaml#/definitions/phandle
>
> > + description: The phandle of MT8188 ASoC platform.
> > +
> > + mediatek,dptx-codec:
> > + $ref: "/schemas/types.yaml#/definitions/phandle"
> > + description: The phandle of MT8188 Display Port Tx codec node.
> > +
> > + mediatek,hdmi-codec:
> > + $ref: "/schemas/types.yaml#/definitions/phandle"
> > + description: The phandle of MT8188 HDMI codec node.
> > +
> > + mediatek,dai-link:
> > + $ref: /schemas/types.yaml#/definitions/string-array
> > + description:
> > + A list of the desired dai-links in the sound card. Each
> > entry is a
> > + name defined in the machine driver.
>
> Names have to be defined here.
>
OK, I will add enum here for listing all available dai-links.
Thanks,
Trevor
> > +
> > +additionalProperties: false
> > +
> > +required:
> > + - compatible
> > + - mediatek,platform
> > +
> > +examples:
> > + - |
> > +
> > + sound: mt8188-sound {
> > + compatible = "mediatek,mt8188-sound";
> > + mediatek,platform = <&afe>:
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&aud_pins_default>;
> > + audio-routing =
> > + "Headphone", "Headphone L",
> > + "Headphone", "Headphone R",
> > + "AIN1", "Headset Mic";
> > + };
> > +
> > +...
> > --
> > 2.18.0
> >
> >
next prev parent reply other threads:[~2022-10-06 2:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 14:56 [PATCH 00/12] ASoC: mediatek: Add support for MT8188 SoC Trevor Wu
2022-09-30 14:56 ` [PATCH 01/12] ASoC: mediatek: common: add SMC ops ID Trevor Wu
2022-09-30 14:56 ` [PATCH 02/12] ASoC: mediatek: mt8188: add common header Trevor Wu
2022-09-30 14:56 ` [PATCH 03/12] ASoC: mediatek: mt8188: support audsys clock Trevor Wu
2022-09-30 14:56 ` [PATCH 04/12] ASoC: mediatek: mt8188: support adda in platform driver Trevor Wu
2022-10-04 9:37 ` AngeloGioacchino Del Regno
2022-10-05 7:14 ` Trevor Wu (吳文良)
2022-09-30 14:56 ` [PATCH 05/12] ASoC: mediatek: mt8188: support etdm " Trevor Wu
2022-09-30 14:56 ` [PATCH 06/12] ASoC: mediatek: mt8188: support pcmif " Trevor Wu
2022-09-30 14:56 ` [PATCH 07/12] ASoC: mediatek: mt8188: support audio clock control Trevor Wu
2022-09-30 14:56 ` [PATCH 08/12] ASoC: mediatek: mt8188: add platform driver Trevor Wu
2022-10-01 9:17 ` kernel test robot
2022-10-05 6:50 ` Trevor Wu (吳文良)
2022-10-05 10:59 ` Mark Brown
2022-10-06 3:13 ` Trevor Wu (吳文良)
2022-10-04 9:36 ` AngeloGioacchino Del Regno
2022-10-06 2:48 ` Trevor Wu (吳文良)
2022-10-15 2:27 ` Trevor Wu (吳文良)
2022-09-30 14:56 ` [PATCH 09/12] ASoC: mediatek: mt8188: add control for timing select Trevor Wu
2022-09-30 14:56 ` [PATCH 10/12] dt-bindings: mediatek: mt8188: add audio afe document Trevor Wu
2022-09-30 22:05 ` Rob Herring
2022-10-05 3:57 ` Trevor Wu (吳文良)
2022-10-28 23:46 ` Krzysztof Kozlowski
2022-10-03 16:30 ` Rob Herring
2022-10-05 10:12 ` Trevor Wu (吳文良)
2022-09-30 14:57 ` [PATCH 11/12] ASoC: mediatek: mt8188: add machine driver with mt6359 Trevor Wu
2022-09-30 14:57 ` [PATCH 12/12] dt-bindings: mediatek: mt8188: add mt8188-mt6359 document Trevor Wu
2022-10-03 16:38 ` Rob Herring
2022-10-06 2:38 ` Trevor Wu (吳文良) [this message]
2022-10-21 8:54 ` Trevor Wu (吳文良)
2022-10-21 8:58 ` Trevor Wu (吳文良)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e96ef77f007f66f883f8dca86d1206cd1b5a767a.camel@mediatek.com \
--to=trevor.wu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).