From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB3FFC74A5B for ; Fri, 17 Mar 2023 20:39:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230198AbjCQUi7 (ORCPT ); Fri, 17 Mar 2023 16:38:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230146AbjCQUi6 (ORCPT ); Fri, 17 Mar 2023 16:38:58 -0400 Received: from sender4-op-o10.zoho.com (sender4-op-o10.zoho.com [136.143.188.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16C9F2D6D; Fri, 17 Mar 2023 13:38:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679085506; cv=none; d=zohomail.com; s=zohoarc; b=Xw/JmgIpXeWcbao/wk4KwQ4Jquj/5Ho6qfNyIdO4Ur9aMayyP5TrN4EJzDccCEWYKoi4giSEwrW8C7YmlUOx5lLKRARF5SvcfAOUPlUqOtzkuvyJxE0ICjHeIj6/XOEN0YueD64oXSDgmxlcsfdP12Ve3Tut9SiH7UwHypfT2tI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679085506; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=WjIwrwxKeq5Ld9Ij9H2Gbwf8PRvgEpDh113K4y969wE=; b=LMni3nsGFnG2FVnh6j6xH22hvSZ6yIBCrpnLHfsA/dr1HxdNGBW3iVIQHTXhOVPzKYUuycLznExUjo8h5UKKTL/SF/44yWFqQpXVvYb5NDnuILezptc2szB91vBW92Xc0Q/ToflYp23Z/AovR6QALoXUAsa/VJTtN1VCOY34Cnc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=arinc9.com; spf=pass smtp.mailfrom=arinc.unal@arinc9.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1679085506; s=zmail; d=arinc9.com; i=arinc.unal@arinc9.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=WjIwrwxKeq5Ld9Ij9H2Gbwf8PRvgEpDh113K4y969wE=; b=h2jZZs7IRiH7FdUfBugzOWe/DM0kpKGcr02Mcdb8/PX8HJ9rm3kNyMUqKb9N9t/b oYooBgEjewh5KXrq5ufHqBSB8F1msv9f8aEqaMtg8Eu518AB6iU0gnkQrohkv1nRhQp 8vPyCEZaBehcCPGd5eKq36itLWJWYLFZ757aLLkI= Received: from [10.10.10.3] (149.91.1.15 [149.91.1.15]) by mx.zohomail.com with SMTPS id 1679085504453905.0224911165027; Fri, 17 Mar 2023 13:38:24 -0700 (PDT) Message-ID: <022c66f3-75d4-5ab4-4a4d-e8260fd70904@arinc9.com> Date: Fri, 17 Mar 2023 23:38:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 20/21] dt-bindings: pinctrl: mediatek: mt7620: split binding To: Rob Herring Cc: Linus Walleij , Krzysztof Kozlowski , William Dean , Sean Wang , Andy Teng , Del Regno , Daniel Golle , Hui Liu , Zhiyong Tao , =?UTF-8?Q?Bernhard_Rosenkr=c3=a4nzer?= , Sergio Paracuellos , Daniel Santos , Luiz Angelo Daros de Luca , Frank Wunderlich , Landen Chao , DENG Qingfang , Sean Wang , erkin.bozoglu@xeront.com, Matthias Brugger , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org References: <20230313205921.35342-1-arinc.unal@arinc9.com> <20230313205921.35342-21-arinc.unal@arinc9.com> <20230317190331.GA2628708-robh@kernel.org> Content-Language: en-US From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: <20230317190331.GA2628708-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 17.03.2023 22:03, Rob Herring wrote: > On Mon, Mar 13, 2023 at 11:59:20PM +0300, arinc9.unal@gmail.com wrote: >> From: Arınç ÜNAL >> >> The MT7628 and MT7688 SoCs contain different pin muxing information, >> therefore, should be split. This can be done now that there are compatible >> strings to distinguish them from other SoCs. >> >> Split the schema out to mediatek,mt76x8-pinctrl.yaml. >> >> Remove mediatek,mt76x8-pinctrl from mt7620. >> >> Signed-off-by: Arınç ÜNAL >> --- >> .../pinctrl/mediatek,mt7620-pinctrl.yaml | 379 +-------------- >> .../pinctrl/mediatek,mt76x8-pinctrl.yaml | 450 ++++++++++++++++++ >> 2 files changed, 459 insertions(+), 370 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml >> index 808dd8bd276f..591bc0664ec6 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml >> @@ -11,15 +11,13 @@ maintainers: >> - Sergio Paracuellos >> >> description: | >> - MediaTek MT7620 pin controller for MT7620, MT7628 and MT7688 SoCs. >> + MediaTek MT7620 pin controller for MT7620 SoC. > > Saying MT7620 twice is redundant. Otherwise, > > Reviewed-by: Rob Herring It's not always a one to one relation so I'd rather explicitly point the SoC out like on other schemas like MT7621. Thanks for reviewing! Arınç