From: "Hawa, Hanna" <hhhawa@amazon.com>
To: Robert Richter <rric@kernel.org>
Cc: <thor.thayer@linux.intel.com>, <bp@alien8.de>,
<mchehab@kernel.org>, <james.morse@arm.com>,
<morbidrsa@gmail.com>, <ralf@linux-mips.org>,
<david.daney@cavium.com>, <andy.gross@linaro.org>,
<david.brown@linaro.org>, <ckadabi@codeaurora.org>,
<vnkgutta@codeaurora.org>, <jglauber@cavium.com>,
<khuong@os.amperecomputing.com>, <dwmw@amazon.co.uk>,
<benh@amazon.com>, <ronenk@amazon.com>, <talel@amazon.com>,
<jonnyc@amazon.com>, <hanochu@amazon.com>,
<linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mips@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
Subject: Re: [RFC 1/1] edac: Add a counter parameter for edac_device_handle_ue/ce()
Date: Thu, 1 Aug 2019 17:30:59 +0300 [thread overview]
Message-ID: <045bb0dd-6a88-36ba-203f-d0dcb9ae5b62@amazon.com> (raw)
In-Reply-To: <20190801141701.bmcken464mrqwhdg@rric.localdomain>
On 8/1/2019 5:17 PM, Robert Richter wrote:
>> Don't you think it'll be confused to have different APIs between EDAC_MC and
>> EDAC_DEVICE?
>> (in MC the count passed as part of edac_mc_handle_error())
> I don't think edac_mc_handle_error() with 11 function arguments is a
> good reference for somethin we want to adopt. For the majority of
> drivers you just introduce another useless argument with the following
> pattern:
>
> edac_device_handle_ce(edac_dev, 1, 0, 0, edac_dev_name);
>
> IMO, the api should be improved when touching it.
Got it, I'll update the patch as you suggested.
Thanks,
Hanna
>
> -Robert
prev parent reply other threads:[~2019-08-01 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 10:53 [RFC 1/1] edac: Add a counter parameter for edac_device_handle_ue/ce() Hanna Hawa
2019-07-17 12:06 ` Jan Glauber
2019-07-17 14:45 ` Hawa, Hanna
2019-07-25 18:36 ` Mauro Carvalho Chehab
2019-07-28 9:34 ` [UNVERIFIED SENDER] " Hawa, Hanna
2019-08-01 11:35 ` Robert Richter
2019-08-01 12:29 ` Hawa, Hanna
2019-08-01 14:17 ` Robert Richter
2019-08-01 14:30 ` Hawa, Hanna [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=045bb0dd-6a88-36ba-203f-d0dcb9ae5b62@amazon.com \
--to=hhhawa@amazon.com \
--cc=andy.gross@linaro.org \
--cc=benh@amazon.com \
--cc=bp@alien8.de \
--cc=ckadabi@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=david.daney@cavium.com \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=james.morse@arm.com \
--cc=jglauber@cavium.com \
--cc=jonnyc@amazon.com \
--cc=khuong@os.amperecomputing.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=morbidrsa@gmail.com \
--cc=ralf@linux-mips.org \
--cc=ronenk@amazon.com \
--cc=rric@kernel.org \
--cc=talel@amazon.com \
--cc=thor.thayer@linux.intel.com \
--cc=vnkgutta@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).