From: Nadav Amit <namit@vmware.com>
To: Yicong Yang <yangyicong@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>, X86 ML <x86@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Peter Zijlstra <peterz@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
"punit.agrawal@bytedance.com" <punit.agrawal@bytedance.com>,
kernel list <linux-kernel@vger.kernel.org>,
"darren@os.amperecomputing.com" <darren@os.amperecomputing.com>,
"yangyicong@hisilicon.com" <yangyicong@hisilicon.com>,
"huzhanyuan@oppo.com" <huzhanyuan@oppo.com>,
"lipeifeng@oppo.com" <lipeifeng@oppo.com>,
"zhangshiming@oppo.com" <zhangshiming@oppo.com>,
"guojian@oppo.com" <guojian@oppo.com>,
"realmz6@gmail.com" <realmz6@gmail.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"openrisc@lists.librecores.org" <openrisc@lists.librecores.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Barry Song <21cnbao@gmail.com>,
"wangkefeng.wang@huawei.com" <wangkefeng.wang@huawei.com>,
haoxin <xhao@linux.alibaba.com>,
"prime.zeng@hisilicon.com" <prime.zeng@hisilicon.com>,
Barry Song <v-songbaohua@oppo.com>, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH v6 2/2] arm64: support batched/deferred tlb shootdown during page reclamation
Date: Tue, 15 Nov 2022 23:38:32 +0000 [thread overview]
Message-ID: <0D3A45FE-5367-40CD-A035-37F6EE98B25E@vmware.com> (raw)
In-Reply-To: <20221115031425.44640-3-yangyicong@huawei.com>
On Nov 14, 2022, at 7:14 PM, Yicong Yang <yangyicong@huawei.com> wrote:
> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
> index 8a497d902c16..5bd78ae55cd4 100644
> --- a/arch/x86/include/asm/tlbflush.h
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -264,7 +264,8 @@ static inline u64 inc_mm_tlb_gen(struct mm_struct *mm)
> }
>
> static inline void arch_tlbbatch_add_mm(struct arch_tlbflush_unmap_batch *batch,
> - struct mm_struct *mm)
> + struct mm_struct *mm,
> + unsigned long uaddr)
Logic-wise it looks fine. I notice the “v6", and it should not be blocking,
but I would note that the name "arch_tlbbatch_add_mm()” does not make much
sense once the function also takes an address.
It could’ve been something like arch_set_tlb_ubc_flush_pending() but that’s
too long. I’m not very good with naming, but the current name is not great.
next prev parent reply other threads:[~2022-11-15 23:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 3:14 [PATCH v6 0/2] arm64: support batched/deferred tlb shootdown during page reclamation Yicong Yang
2022-11-15 3:14 ` [PATCH v6 1/2] mm/tlbbatch: Introduce arch_tlbbatch_should_defer() Yicong Yang
2022-11-15 6:44 ` haoxin
2022-11-15 3:14 ` [PATCH v6 2/2] arm64: support batched/deferred tlb shootdown during page reclamation Yicong Yang
2022-11-15 6:35 ` haoxin
2022-11-15 23:38 ` Nadav Amit [this message]
2022-11-16 1:50 ` Yicong Yang
2022-11-16 1:56 ` Nadav Amit
2022-11-16 2:51 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0D3A45FE-5367-40CD-A035-37F6EE98B25E@vmware.com \
--to=namit@vmware.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=darren@os.amperecomputing.com \
--cc=guojian@oppo.com \
--cc=huzhanyuan@oppo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lipeifeng@oppo.com \
--cc=mgorman@suse.de \
--cc=openrisc@lists.librecores.org \
--cc=peterz@infradead.org \
--cc=prime.zeng@hisilicon.com \
--cc=punit.agrawal@bytedance.com \
--cc=realmz6@gmail.com \
--cc=v-songbaohua@oppo.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xhao@linux.alibaba.com \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).