Linux-MIPS Archive on lore.kernel.org
 help / color / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
	hauke@hauke-m.de, zajec5@gmail.com, tsbogend@alpha.franken.de,
	robh+dt@kernel.org, jonas.gorski@gmail.com,
	bcm-kernel-feedback-list@broadcom.com,
	linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] soc: bcm: add BCM63xx power domain driver
Date: Tue, 9 Jun 2020 19:19:33 -0700
Message-ID: <13cc694b-c643-0f68-e510-062df5352eaa@gmail.com> (raw)
In-Reply-To: <20200609105244.4014823-3-noltari@gmail.com>



On 6/9/2020 3:52 AM, Álvaro Fernández Rojas wrote:
> BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
> to enable/disable certain components in order to save power.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  drivers/soc/bcm/Kconfig         |   8 +
>  drivers/soc/bcm/Makefile        |   1 +
>  drivers/soc/bcm/bcm63xx-power.c | 374 ++++++++++++++++++++++++++++++++

I would create drivers/soc/bcm/bcm63xx because there are likely going to
be more changes for BCM63xx DSL SOCs in the future that would land
there, for instance the BCM63138 and newer SoCs have an entirely
different reset controller using the on-chip micro controller that would
be landing there.

Can you also make sure that the MAINTAINERS file still matches that
location?

With respect to the code, given that you have defined #reset-cells = <1>
in the Device Tree binding, I would expect that you create a header
under include/dt-bindings/ which defines constants for the various SoCs
which you are then using within your power domain provider driver.
bcm2835-power.c is a good example of how this works for instance.
-- 
Florian

  reply index

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 10:52 [PATCH 0/4] bmips: add BCM63xx power domain controller Álvaro Fernández Rojas
2020-06-09 10:52 ` [PATCH 1/4] dt-bindings: soc: brcm: add BCM63xx power domain binding Álvaro Fernández Rojas
2020-06-10  1:15   ` Florian Fainelli
2020-06-10  6:03     ` Álvaro Fernández Rojas
2020-06-09 10:52 ` [PATCH 2/4] soc: bcm: add BCM63xx power domain driver Álvaro Fernández Rojas
2020-06-10  2:19   ` Florian Fainelli [this message]
2020-06-09 10:52 ` [PATCH 3/4] mips: bmips: dts: add BCM6328 power domain support Álvaro Fernández Rojas
2020-06-10  1:12   ` Florian Fainelli
2020-06-09 10:52 ` [PATCH 4/4] mips: bmips: dts: add BCM6362 " Álvaro Fernández Rojas
2020-06-10  2:21   ` Florian Fainelli
2020-06-10  2:27   ` Florian Fainelli
2020-06-10 16:32 ` [PATCH v2 0/6] bmips: add BCM63xx power domain controller Álvaro Fernández Rojas
2020-06-10 16:32   ` [PATCH v2 1/6] dt-bindings: soc: brcm: add BCM63xx power domain binding Álvaro Fernández Rojas
2020-06-10 16:44     ` Florian Fainelli
2020-06-10 16:32   ` [PATCH v2 2/6] soc: bcm: add BCM63xx power domain driver Álvaro Fernández Rojas
2020-06-10 16:49     ` Florian Fainelli
2020-06-10 16:32   ` [PATCH v2 3/6] mips: bmips: dts: add BCM6328 power domain support Álvaro Fernández Rojas
2020-06-10 16:32   ` [PATCH v2 4/6] mips: bmips: dts: add BCM6362 " Álvaro Fernández Rojas
2020-06-10 16:33   ` [PATCH v2 5/6] mips: bmips: dts: add BCM63268 " Álvaro Fernández Rojas
2020-06-10 16:33   ` [PATCH v2 6/6] mips: bmips: add BCM6318 power domain definitions Álvaro Fernández Rojas
2020-06-10 16:49   ` [PATCH v2 0/6] bmips: add BCM63xx power domain controller Florian Fainelli
2020-06-10 17:16   ` [PATCH v3 0/9] " Álvaro Fernández Rojas
2020-06-10 17:16     ` [PATCH v3 1/9] dt-bindings: soc: brcm: add BCM63xx power domain binding Álvaro Fernández Rojas
2020-06-12 21:55       ` Rob Herring
2020-06-12 21:56       ` Rob Herring
2020-06-10 17:16     ` [PATCH v3 2/9] mips: bmips: dts: add BCM6328 power domain definitions Álvaro Fernández Rojas
2020-06-10 17:16     ` [PATCH v3 3/9] mips: bmips: dts: add BCM6362 " Álvaro Fernández Rojas
2020-06-10 17:16     ` [PATCH v3 4/9] mips: bmips: dts: add BCM63268 " Álvaro Fernández Rojas
2020-06-10 17:16     ` [PATCH v3 5/9] mips: bmips: add BCM6318 " Álvaro Fernández Rojas
2020-06-10 17:16     ` [PATCH v3 6/9] soc: bcm: add BCM63xx power domain driver Álvaro Fernández Rojas
2020-06-10 17:16     ` [PATCH v3 7/9] mips: bmips: dts: add BCM6328 power domain support Álvaro Fernández Rojas
2020-06-10 17:16     ` [PATCH v3 8/9] mips: bmips: dts: add BCM6362 " Álvaro Fernández Rojas
2020-06-10 17:16     ` [PATCH v3 9/9] mips: bmips: dts: add BCM63268 " Álvaro Fernández Rojas
2020-06-13  8:21     ` [PATCH v4 0/9] bmips: add BCM63xx power domain controller Álvaro Fernández Rojas
2020-06-13  8:21       ` [PATCH v4 1/9] dt-bindings: soc: brcm: add BCM63xx power domain binding Álvaro Fernández Rojas
2020-07-09 22:59         ` Rob Herring
2020-06-13  8:21       ` [PATCH v4 2/9] mips: bmips: add BCM6328 power domain definitions Álvaro Fernández Rojas
2020-06-14  4:45         ` Florian Fainelli
2020-07-09 23:00         ` Rob Herring
2020-06-13  8:21       ` [PATCH v4 3/9] mips: bmips: add BCM6362 " Álvaro Fernández Rojas
2020-06-14  4:46         ` Florian Fainelli
2020-07-09 23:00         ` Rob Herring
2020-06-13  8:21       ` [PATCH v4 4/9] mips: bmips: add BCM63268 " Álvaro Fernández Rojas
2020-06-14  4:46         ` Florian Fainelli
2020-07-09 23:01         ` Rob Herring
2020-06-13  8:21       ` [PATCH v4 5/9] mips: bmips: add BCM6318 " Álvaro Fernández Rojas
2020-06-14  4:46         ` Florian Fainelli
2020-07-09 23:01         ` Rob Herring
2020-06-13  8:21       ` [PATCH v4 6/9] soc: bcm: add BCM63xx power domain driver Álvaro Fernández Rojas
2020-06-14  4:48         ` Florian Fainelli
2020-06-13  8:21       ` [PATCH v4 7/9] mips: bmips: dts: add BCM6328 power domain support Álvaro Fernández Rojas
2020-07-23  9:10         ` Thomas Bogendoerfer
2020-06-13  8:21       ` [PATCH v4 8/9] mips: bmips: dts: add BCM6362 " Álvaro Fernández Rojas
2020-07-23  9:10         ` Thomas Bogendoerfer
2020-06-13  8:21       ` [PATCH v4 9/9] mips: bmips: dts: add BCM63268 " Álvaro Fernández Rojas
2020-06-14  4:48         ` Florian Fainelli
2020-07-23  9:10         ` Thomas Bogendoerfer
2020-07-24 22:15       ` [PATCH v4 0/9] bmips: add BCM63xx power domain controller Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13cc694b-c643-0f68-e510-062df5352eaa@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hauke@hauke-m.de \
    --cc=jonas.gorski@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=noltari@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-MIPS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \
		linux-mips@vger.kernel.org
	public-inbox-index linux-mips

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git