linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-mips@linux-mips.org
Cc: ralf@linux-mips.org, cernekee@gmail.com, jaedon.shin@gmail.com,
	justinpopo6@gmail.com, tglx@linuxtronix.de, marc.zyngier@arm.com,
	jason@lakedaemon.net, linux-kernel@vger.kernel.org,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH 2/2] MIPS: BMIPS: Migrate interrupts during bmips_cpu_disable
Date: Mon, 31 Oct 2016 14:16:47 -0700	[thread overview]
Message-ID: <1477948607-12899-3-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1477948607-12899-1-git-send-email-f.fainelli@gmail.com>

While we properly disabled the per-CPU timer interrupt, we also need to
make sure that all interrupts that can possibly have this CPU in their
smp_affinity mask also have a chance to see this interrupt migrated to a
CPU not being taken offline.

Fixes: 230b6ff57552 ("MIPS: BMIPS: Mask off timer IRQs when hot-unplugging a CPU")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/mips/kernel/smp-bmips.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c
index 6d0f1321e084..37dffda8f16b 100644
--- a/arch/mips/kernel/smp-bmips.c
+++ b/arch/mips/kernel/smp-bmips.c
@@ -365,6 +365,8 @@ static int bmips_cpu_disable(void)
 	set_cpu_online(cpu, false);
 	calculate_cpu_foreign_map();
 	cpumask_clear_cpu(cpu, &cpu_callin_map);
+
+	irq_cpu_offline();
 	clear_c0_status(IE_IRQ5);
 
 	local_flush_tlb_all();
-- 
2.7.4

  parent reply	other threads:[~2016-10-31 21:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31 21:16 [PATCH 0/2] MIPS: BMIPS: Fix interrupt affinity migration Florian Fainelli
2016-10-31 21:16 ` [PATCH 1/2] irqchip/bcm7038-l1: Implement irq_cpu_offline Florian Fainelli
2016-10-31 21:16 ` Florian Fainelli [this message]
2016-11-11 18:18 ` [PATCH 0/2] MIPS: BMIPS: Fix interrupt affinity migration Florian Fainelli
2016-10-31 21:17 Florian Fainelli
2016-10-31 21:17 ` [PATCH 2/2] MIPS: BMIPS: Migrate interrupts during bmips_cpu_disable Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477948607-12899-3-git-send-email-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=cernekee@gmail.com \
    --cc=jaedon.shin@gmail.com \
    --cc=jason@lakedaemon.net \
    --cc=justinpopo6@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=marc.zyngier@arm.com \
    --cc=ralf@linux-mips.org \
    --cc=tglx@linuxtronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).