linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Murray <andrew.murray@arm.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, Ralf Baechle <ralf@linux-mips.org>,
	Paul Burton <paul.burton@mips.com>,
	James Hogan <jhogan@kernel.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	"David S . Miller" <davem@davemloft.net>,
	sparclinux@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-s390@vger.kernel.org, linux-mips@linux-mips.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-alpha@vger.kernel.org
Subject: [PATCH v2 03/20] perf/core: add PERF_PMU_CAP_EXCLUDE for exclusion capable PMUs
Date: Mon, 26 Nov 2018 11:12:19 +0000	[thread overview]
Message-ID: <1543230756-15319-4-git-send-email-andrew.murray@arm.com> (raw)
In-Reply-To: <1543230756-15319-1-git-send-email-andrew.murray@arm.com>

Many PMU drivers do not have the capability to exclude counting events
that occur in specific contexts such as idle, kernel, guest, etc. These
drivers indicate this by returning an error in their event_init upon
testing the events attribute flags. This approach is error prone and
often inconsistent.

Let's instead allow PMU drivers to advertise their ability to exclude
based on context via a new capability: PERF_PMU_CAP_EXCLUDE. This
allows the perf core to reject requests for exclusion events where
there is no support in the PMU.

Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
 include/linux/perf_event.h | 1 +
 kernel/events/core.c       | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index b2e806f..69b3d65 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -244,6 +244,7 @@ struct perf_event;
 #define PERF_PMU_CAP_EXCLUSIVE			0x10
 #define PERF_PMU_CAP_ITRACE			0x20
 #define PERF_PMU_CAP_HETEROGENEOUS_CPUS		0x40
+#define PERF_PMU_CAP_EXCLUDE			0x80
 
 /**
  * struct pmu - generic performance monitoring unit
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 5a97f34..9afb33c 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9743,6 +9743,15 @@ static int perf_try_init_event(struct pmu *pmu, struct perf_event *event)
 	if (ctx)
 		perf_event_ctx_unlock(event->group_leader, ctx);
 
+	if (!ret) {
+		if (!(pmu->capabilities & PERF_PMU_CAP_EXCLUDE) &&
+				event_has_any_exclude_flag(event)) {
+			if (event->destroy)
+				event->destroy(event);
+			ret = -EINVAL;
+		}
+	}
+
 	if (ret)
 		module_put(pmu->module);
 
-- 
2.7.4

  parent reply	other threads:[~2018-11-26 11:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26 11:12 [PATCH v2 00/20] perf/core: Generalise event exclusion checking Andrew Murray
2018-11-26 11:12 ` [PATCH v2 01/20] perf/doc: update design.txt for exclude_{host|guest} flags Andrew Murray
2018-11-26 18:22   ` Suzuki K Poulose
2018-11-26 11:12 ` [PATCH v2 02/20] perf/core: add function to test for event exclusion flags Andrew Murray
2018-11-26 11:12 ` Andrew Murray [this message]
2018-11-26 14:10   ` [PATCH v2 03/20] perf/core: add PERF_PMU_CAP_EXCLUDE for exclusion capable PMUs Robin Murphy
2018-11-26 14:55     ` Andrew Murray
2018-11-26 11:12 ` [PATCH v2 04/20] perf/hw_breakpoint: perf/core: advertise PMU exclusion capability Andrew Murray
2018-11-26 11:12 ` [PATCH v2 05/20] alpha: perf/core: remove unnecessary checks for exclusion Andrew Murray
2018-11-26 11:12 ` [PATCH v2 06/20] arc: perf/core: advertise PMU exclusion capability Andrew Murray
2018-11-26 11:12 ` [PATCH v2 07/20] arm: perf: conditionally " Andrew Murray
2018-11-26 11:12 ` [PATCH v2 08/20] arm: perf/core: remove unnecessary checks for exclusion Andrew Murray
2018-11-26 11:12 ` [PATCH v2 09/20] drivers/perf: " Andrew Murray
2018-11-26 11:12 ` [PATCH v2 10/20] " Andrew Murray
2018-11-26 11:12 ` [PATCH v2 11/20] drivers/perf: perf/core: advertise PMU exclusion capability Andrew Murray
2018-11-26 11:12 ` [PATCH v2 12/20] mips: " Andrew Murray
2018-11-26 11:12 ` [PATCH v2 13/20] powerpc: " Andrew Murray
2018-11-26 11:12 ` [PATCH v2 14/20] powerpc: perf/core: remove unnecessary checks for exclusion Andrew Murray
2018-11-26 11:12 ` [PATCH v2 15/20] s390: perf/events: advertise PMU exclusion capability Andrew Murray
2018-11-27  8:19   ` Hendrik Brueckner
2018-11-26 11:12 ` [PATCH v2 16/20] sparc: perf/core: " Andrew Murray
2018-11-26 18:00   ` David Miller
2018-11-26 11:12 ` [PATCH v2 17/20] x86: perf/core: remove unnecessary checks for exclusion Andrew Murray
2018-11-26 11:12 ` [PATCH v2 18/20] x86: perf/core " Andrew Murray
2018-11-26 11:12 ` [PATCH v2 19/20] x86: perf/core: advertise PMU exclusion capability Andrew Murray
2018-11-26 11:12 ` [PATCH v2 20/20] perf/core: remove unused perf_flags Andrew Murray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1543230756-15319-4-git-send-email-andrew.murray@arm.com \
    --to=andrew.murray@arm.com \
    --cc=acme@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=bp@alien8.de \
    --cc=davem@davemloft.net \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jhogan@kernel.org \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=paul.burton@mips.com \
    --cc=peterz@infradead.org \
    --cc=ralf@linux-mips.org \
    --cc=s.hauer@pengutronix.de \
    --cc=schwidefsky@de.ibm.com \
    --cc=shawnguo@kernel.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).