From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFCEEC282C6 for ; Thu, 24 Jan 2019 22:53:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 892CF2082C for ; Thu, 24 Jan 2019 22:53:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="EszSNie7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728043AbfAXWxg (ORCPT ); Thu, 24 Jan 2019 17:53:36 -0500 Received: from outils.crapouillou.net ([89.234.176.41]:39188 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbfAXWxf (ORCPT ); Thu, 24 Jan 2019 17:53:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1548370412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HzkXkAyH1kqLw9/6RBJizZepKB6BSCSHMgzg+v6bZGA=; b=EszSNie7zFWRaAODQk8Z4T0Bv1jDmdZvFVPv5aerTqtJtAM+hCP2w165IbtMjS+Zc2Xr69 IwSKCP4DUwLFefm/PPH+ZcsDikpoUeL+shTDNmn0gntoeCHK60DW8lYEVPZWR40rcMudF0 6UYnQPkZQsvdysK1nGGhJcrY7gn8qOw= Date: Thu, 24 Jan 2019 19:53:08 -0300 From: Paul Cercueil Subject: Re: [PATCH v8 05/26] clocksource: Add driver for the Ingenic JZ47xx OST To: Stephen Boyd Cc: Guenter Roeck , Mathieu Malaterre , Thierry Reding , Rob Herring , Mark Rutland , Daniel Lezcano , Thomas Gleixner , Ralf Baechle , Paul Burton , James Hogan , Jonathan Corbet , Ezequiel Garcia , PrasannaKumar Muralidharan , linux-pwm@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , linux-watchdog@vger.kernel.org, linux-mips@vger.kernel.org, linux-doc@vger.kernel.org, linux-clk@vger.kernel.org, od@zcrc.me, Maarten ter Huurne Message-Id: <1548370388.3881.2@crapouillou.net> In-Reply-To: <154836998080.136743.17683029101430122926@swboyd.mtv.corp.google.com> References: <20181212220922.18759-1-paul@crapouillou.net> <20181212220922.18759-6-paul@crapouillou.net> <128675a5-7ede-4114-a649-89a536346dc8@roeck-us.net> <1548264353.3173.1@crapouillou.net> <20190123180155.GB9781@roeck-us.net> <154835808767.136743.14531363127962557756@swboyd.mtv.corp.google.com> <1548362788.3881.0@crapouillou.net> <154836998080.136743.17683029101430122926@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Le jeu. 24 janv. 2019 =E0 19:46, Stephen Boyd a=20 =E9crit : > Quoting Paul Cercueil (2019-01-24 12:46:28) >>=20 >>=20 >> Le jeu. 24 janv. 2019 =E0 16:28, Stephen Boyd a >> =E9crit : >> > Quoting Guenter Roeck (2019-01-23 10:01:55) >> >> On Wed, Jan 23, 2019 at 02:25:53PM -0300, Paul Cercueil wrote: >> >> > Hi, >> >> > >> >> > Le mer. 23 janv. 2019 =C3 11:31, Guenter Roeck >> >> a =C3=A9crit : >> >> > >On 1/23/19 4:58 AM, Mathieu Malaterre wrote: >> >> > >>On Wed, Dec 12, 2018 at 11:09 PM Paul Cercueil >> >> >> >> > >>wrote: >> >> > >>> >> >> > >>>From: Maarten ter Huurne >> >> > >>> >> >> > >>>OST is the OS Timer, a 64-bit timer/counter with buffered >> >> reading. >> >> > >>> >> >> > >>>SoCs before the JZ4770 had (if any) a 32-bit OST; the=20 >> JZ4770 >> >> and >> >> > >>>JZ4780 have a 64-bit OST. >> >> > >>> >> >> > >>>This driver will register both a clocksource and a=20 >> sched_clock >> >> to the >> >> > >>>system. >> >> > >>> >> >> > >>>Signed-off-by: Maarten ter Huurne >> >> > >>>Signed-off-by: Paul Cercueil >> >> > >>>--- >> >> > >>> >> >> > >>>Notes: >> >> > >>> v5: New patch >> >> > >>> >> >> > >>> v6: - Get rid of SoC IDs; pass pointer to >> >> ingenic_ost_soc_info >> >> > >>>as >> >> > >>> devicetree match data instead. >> >> > >>> - Use device_get_match_data() instead of the of_* >> >> variant >> >> > >>> - Handle error of dev_get_regmap() properly >> >> > >>> >> >> > >>> v7: Fix section mismatch by using >> >> > >>>builtin_platform_driver_probe() >> >> > >>> >> >> > >>> v8: builtin_platform_driver_probe() does not work >> >> anymore in >> >> > >>> 4.20-rc6? The probe function won't be called.=20 >> Work >> >> around >> >> > >>>this >> >> > >>> for now by using late_initcall. >> >> > >>> >> >> > > >> >> > >Did anyone notice this ? Either something is wrong with the >> >> driver, or >> >> > >with the kernel core. Hacking around it seems like the worst >> >> possible >> >> > >"solution". >> >> > >> >> > I can confirm it still happens on 5.0-rc3. >> >> > >> >> > Just to explain what I'm doing: >> >> > >> >> > My ingenic-timer driver probes with=20 >> builtin_platform_driver_probe >> >> (this >> >> > works), >> >> > and then calls of_platform_populate to probe its children.=20 >> This >> >> driver, >> >> > ingenic-ost, is one of them, and will fail to probe with >> >> > builtin_platform_driver_probe. >> >> > >> >> >> >> The big question is _why_ it fails to probe. >> >> >> > >> > Are you sharing the device tree node between a 'normal' platform >> > device >> > driver and something more low level DT that marks the device's=20 >> backing >> > DT node as OF_POPULATED early on? That's my only guess why it's=20 >> not >> > working. >>=20 >> I do, but I clear the OF_POPULATED flag so that it is then probed=20 >> as a >> normal platform device, and it's not on this driver's node but its >> parent. >>=20 >=20 > Where do you clear the OF_POPULATED flag? >=20 In the ingenic-timer driver introduced in patch [04/26], inside the=20 probe function. =