From: Paolo Bonzini <pbonzini@redhat.com>
To: "Sean Christopherson" <sean.j.christopherson@intel.com>,
"James Hogan" <jhogan@kernel.org>,
"Paul Mackerras" <paulus@ozlabs.org>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Marc Zyngier" <maz@kernel.org>
Cc: David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
Marc Zyngier <Marc.Zyngier@arm.com>,
Paul Mackerras <paulus@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH v2 00/15] KVM: Dynamically size memslot arrays
Date: Tue, 22 Oct 2019 15:59:23 +0200 [thread overview]
Message-ID: <15624ac3-6a43-29c8-8d07-23779454f9e6@redhat.com> (raw)
In-Reply-To: <20191022003537.13013-1-sean.j.christopherson@intel.com>
On 22/10/19 02:35, Sean Christopherson wrote:
> The end goal of this series is to dynamically size the memslot array so
> that KVM allocates memory based on the number of memslots in use, as
> opposed to unconditionally allocating memory for the maximum number of
> memslots. On x86, each memslot consumes 88 bytes, and so with 2 address
> spaces of 512 memslots, each VM consumes ~90k bytes for the memslots.
> E.g. given a VM that uses a total of 30 memslots, dynamic sizing reduces
> the memory footprint from 90k to ~2.6k bytes.
>
> The changes required to support dynamic sizing are relatively small,
> e.g. are essentially contained in patches 12/13 and 13/13. Patches 1-11
> clean up the memslot code, which has gotten quite crusy, especially
> __kvm_set_memory_region(). The clean up is likely not strictly necessary
> to switch to dynamic sizing, but I didn't have a remotely reasonable
> level of confidence in the correctness of the dynamic sizing without first
> doing the clean up.
>
> Testing, especially non-x86 platforms, would be greatly appreciated. The
> non-x86 changes are for all intents and purposes untested, e.g. I compile
> tested pieces of the code by copying them into x86, but that's it. In
> theory, the vast majority of the functional changes are arch agnostic, in
> theory...
>
> v2:
> - Split "Drop kvm_arch_create_memslot()" into three patches to move
> minor functional changes to standalone patches [Janosch].
> - Rebase to latest kvm/queue (f0574a1cea5b, "KVM: x86: fix ...")
> - Collect an Acked-by and a Reviewed-by
>
> Sean Christopherson (15):
> KVM: Reinstall old memslots if arch preparation fails
> KVM: Don't free new memslot if allocation of said memslot fails
> KVM: PPC: Move memslot memory allocation into prepare_memory_region()
> KVM: x86: Allocate memslot resources during prepare_memory_region()
> KVM: Drop kvm_arch_create_memslot()
> KVM: Explicitly free allocated-but-unused dirty bitmap
> KVM: Refactor error handling for setting memory region
> KVM: Move setting of memslot into helper routine
> KVM: Move memslot deletion to helper function
> KVM: Simplify kvm_free_memslot() and all its descendents
> KVM: Clean up local variable usage in __kvm_set_memory_region()
> KVM: Provide common implementation for generic dirty log functions
> KVM: Ensure validity of memslot with respect to kvm_get_dirty_log()
> KVM: Terminate memslot walks via used_slots
> KVM: Dynamically size memslot array based on number of used slots
>
> arch/mips/include/asm/kvm_host.h | 2 +-
> arch/mips/kvm/mips.c | 68 +---
> arch/powerpc/include/asm/kvm_ppc.h | 14 +-
> arch/powerpc/kvm/book3s.c | 22 +-
> arch/powerpc/kvm/book3s_hv.c | 36 +-
> arch/powerpc/kvm/book3s_pr.c | 20 +-
> arch/powerpc/kvm/booke.c | 17 +-
> arch/powerpc/kvm/powerpc.c | 13 +-
> arch/s390/include/asm/kvm_host.h | 2 +-
> arch/s390/kvm/kvm-s390.c | 21 +-
> arch/x86/include/asm/kvm_page_track.h | 3 +-
> arch/x86/kvm/page_track.c | 15 +-
> arch/x86/kvm/x86.c | 100 ++---
> include/linux/kvm_host.h | 48 +--
> virt/kvm/arm/arm.c | 47 +--
> virt/kvm/arm/mmu.c | 18 +-
> virt/kvm/kvm_main.c | 546 ++++++++++++++++----------
> 17 files changed, 467 insertions(+), 525 deletions(-)
>
Christian, Marc, Paul, can you help testing patches 1-13?
Thanks,
next prev parent reply other threads:[~2019-10-22 13:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 0:35 [PATCH v2 00/15] KVM: Dynamically size memslot arrays Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 01/15] KVM: Reinstall old memslots if arch preparation fails Sean Christopherson
2019-10-23 9:29 ` Christoffer Dall
2019-10-22 0:35 ` [PATCH v2 02/15] KVM: Don't free new memslot if allocation of said memslot fails Sean Christopherson
2019-10-23 9:29 ` Christoffer Dall
2019-10-22 0:35 ` [PATCH v2 03/15] KVM: PPC: Move memslot memory allocation into prepare_memory_region() Sean Christopherson
2019-10-24 11:55 ` kbuild test robot
2019-10-22 0:35 ` [PATCH v2 04/15] KVM: x86: Allocate memslot resources during prepare_memory_region() Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 05/15] KVM: Drop kvm_arch_create_memslot() Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 06/15] KVM: Explicitly free allocated-but-unused dirty bitmap Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 07/15] KVM: Refactor error handling for setting memory region Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 08/15] KVM: Move setting of memslot into helper routine Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 09/15] KVM: Move memslot deletion to helper function Sean Christopherson
2019-10-23 9:29 ` Christoffer Dall
2019-10-22 0:35 ` [PATCH v2 10/15] KVM: Simplify kvm_free_memslot() and all its descendents Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 11/15] KVM: Clean up local variable usage in __kvm_set_memory_region() Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 12/15] KVM: Provide common implementation for generic dirty log functions Sean Christopherson
2019-10-23 9:29 ` Christoffer Dall
2019-10-24 10:28 ` kbuild test robot
2019-10-22 0:35 ` [PATCH v2 13/15] KVM: Ensure validity of memslot with respect to kvm_get_dirty_log() Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots Sean Christopherson
2019-10-22 14:04 ` Paolo Bonzini
2019-10-22 15:28 ` Sean Christopherson
2019-10-22 15:30 ` Paolo Bonzini
2019-10-22 15:52 ` Sean Christopherson
2019-10-22 15:53 ` Paolo Bonzini
2019-10-24 19:38 ` Sean Christopherson
2019-10-24 19:42 ` Sean Christopherson
2019-10-24 20:24 ` Paolo Bonzini
2019-10-24 20:48 ` Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 15/15] KVM: Dynamically size memslot array based on number of used slots Sean Christopherson
2019-10-22 14:04 ` Paolo Bonzini
2019-10-22 15:22 ` Sean Christopherson
2019-10-22 13:59 ` Paolo Bonzini [this message]
2019-10-23 18:56 ` [PATCH v2 00/15] KVM: Dynamically size memslot arrays Christian Borntraeger
2019-10-22 14:04 ` Paolo Bonzini
2019-10-23 9:39 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15624ac3-6a43-29c8-8d07-23779454f9e6@redhat.com \
--to=pbonzini@redhat.com \
--cc=Marc.Zyngier@arm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=james.morse@arm.com \
--cc=jhogan@kernel.org \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maz@kernel.org \
--cc=paulus@ozlabs.org \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=suzuki.poulose@arm.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).