From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08598C76191 for ; Fri, 26 Jul 2019 00:10:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D474F22CBA for ; Fri, 26 Jul 2019 00:10:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="EjeAwp0Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727061AbfGZAKK (ORCPT ); Thu, 25 Jul 2019 20:10:10 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:37318 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726942AbfGZAKK (ORCPT ); Thu, 25 Jul 2019 20:10:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1564099806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gFaFrhEeyihyNbT3NtUBxEN4a+tGXeK6Vj+6otZDbtA=; b=EjeAwp0Z/Iz3JRj9xNi/OYWvP2qoXOXLR2kbAZQ7FDIMPuZOSiF0qc+SgEr+9qWUDz7njx 9fSJSmwLBKrpzZNSM2vLDDU9dSKZqz4/qtlXGm6qm9sWN7tSWyprI05k88rU07mM/u+DSu bZeGz0/dkH6Ou3QGiuwrGDsK3pWy2rI= Date: Thu, 25 Jul 2019 20:09:41 -0400 From: Paul Cercueil Subject: Re: [PATCH 02/11] MIPS: qi_lb60: Migrate to devicetree To: Paul Burton Cc: Ralf Baechle , James Hogan , Rob Herring , Mark Rutland , Vinod Koul , Jean Delvare , Guenter Roeck , Lee Jones , Miquel Raynal , Richard Weinberger , Sebastian Reichel , Bartlomiej Zolnierkiewicz , Liam Girdwood , Mark Brown , od@zcrc.me, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, Artur Rojek Message-Id: <1564099781.1699.0@crapouillou.net> In-Reply-To: <20190725234735.h7qmtt26qpkjw3n6@pburton-laptop> References: <20190725220215.460-1-paul@crapouillou.net> <20190725220215.460-3-paul@crapouillou.net> <20190725234735.h7qmtt26qpkjw3n6@pburton-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Le jeu. 25 juil. 2019 =E0 19:47, Paul Burton a=20 =E9crit : > Hi Paul, >=20 > On Thu, Jul 25, 2019 at 06:02:06PM -0400, Paul Cercueil wrote: >> Move all the platform data to devicetree. >=20 > Nice! :) >=20 >> The only bit dropped is the PWM beeper, which requires the PWM=20 >> driver >> to be updated. I figured it's okay to remove it here since it's=20 >> really >> a non-critical device, and it'll be re-introduced soon enough. >=20 > OK, I can see that being a price worth paying. Though it's possible to > include the binding at least for that in this series I'd be even > happier. Actually I see we already have >=20 > Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt >=20 > in mainline - what needs to change with it? The PWM driver will be updated to use the TCU clocks and the regmap=20 provided by the TCU driver. The PWM node will be a sub-node of the TCU one. Additionally, there is this[1] ongoing discussion about PWM which makes me uneasy about how to write the binding. So I'd rather not rush it, because once the devicetree is written, it's ABI. [1]: https://lkml.org/lkml/2019/5/22/607 >> + spi { >> + compatible =3D "spi-gpio"; >> + #address-cells =3D <1>; >> + #size-cells =3D <0>; >> + >> + sck-gpios =3D <&gpc 23 GPIO_ACTIVE_HIGH>; >> + mosi-gpios =3D <&gpc 22 GPIO_ACTIVE_HIGH>; >> + cs-gpios =3D <&gpc 21 GPIO_ACTIVE_LOW>; >> + num-chipselects =3D <1>; >> + >> + spi@0 { >> + compatible =3D "ili8960"; >=20 > Should this be "ilitek,ili8960"? >=20 > Is there a binding & driver for this submitted somewhere? If not then=20 > do > we need this at all? It doesn't look like the existing platform data > would actually lead to a driver being loaded so I'm wondering if we=20 > can > just drop this until such a driver (or at least a documented DT=20 > binding) > exists. I can drop it. There is no driver for it, and I'm not even sure the LB60 has a ILI8960 in the first place. > Thanks, > Paul =