From: Yunsheng Lin <linyunsheng@huawei.com> To: <catalin.marinas@arm.com>, <will@kernel.org>, <mingo@redhat.com>, <bp@alien8.de>, <rth@twiddle.net>, <ink@jurassic.park.msu.ru>, <mattst88@gmail.com>, <benh@kernel.crashing.org>, <paulus@samba.org>, <mpe@ellerman.id.au>, <heiko.carstens@de.ibm.com>, <gor@linux.ibm.com>, <borntraeger@de.ibm.com>, <ysato@users.sourceforge.jp>, <dalias@libc.org>, <davem@davemloft.net>, <ralf@linux-mips.org>, <paul.burton@mips.com>, <jhogan@kernel.org>, <jiaxun.yang@flygoat.com>, <chenhc@lemote.com> Cc: <akpm@linux-foundation.org>, <rppt@linux.ibm.com>, <anshuman.khandual@arm.com>, <tglx@linutronix.de>, <cai@lca.pw>, <robin.murphy@arm.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <hpa@zytor.com>, <x86@kernel.org>, <dave.hansen@linux.intel.com>, <luto@kernel.org>, <peterz@infradead.org>, <len.brown@intel.com>, <axboe@kernel.dk>, <dledford@redhat.com>, <jeffrey.t.kirsher@intel.com>, <linux-alpha@vger.kernel.org>, <nfont@linux.vnet.ibm.com>, <naveen.n.rao@linux.vnet.ibm.com>, <mwb@linux.vnet.ibm.com>, <linuxppc-dev@lists.ozlabs.org>, <linux-s390@vger.kernel.org>, <linux-sh@vger.kernel.org>, <sparclinux@vger.kernel.org>, <tbogendoerfer@suse.de>, <linux-mips@vger.kernel.org>, <linuxarm@huawei.com> Subject: [PATCH v2 1/9] arm64: numa: check the node id consistently for arm64 Date: Sat, 31 Aug 2019 13:58:15 +0800 Message-ID: <1567231103-13237-2-git-send-email-linyunsheng@huawei.com> (raw) In-Reply-To: <1567231103-13237-1-git-send-email-linyunsheng@huawei.com> According to Section 6.2.14 from ACPI spec 6.3 [1], the setting of proximity domain is optional, as below: This optional object is used to describe proximity domain associations within a machine. _PXM evaluates to an integer that identifies a device as belonging to a Proximity Domain defined in the System Resource Affinity Table (SRAT). When enabling KASAN and bios has not implemented the proximity domain of the hns3 device, there is a global-out-of-bounds error below: [ 42.970381] ================================================================== [ 42.977595] BUG: KASAN: global-out-of-bounds in __bitmap_weight+0x48/0xb0 [ 42.984370] Read of size 8 at addr ffff20008cdf8790 by task kworker/0:1/13 [ 42.991230] [ 42.992712] CPU: 0 PID: 13 Comm: kworker/0:1 Tainted: G O 5.2.0-rc4-g8bde06a-dirty #3 [ 43.001830] Hardware name: Huawei TaiShan 2280 V2/BC82AMDA, BIOS TA BIOS 2280-A CS V2.B050.01 08/08/2019 [ 43.011298] Workqueue: events work_for_cpu_fn [ 43.015643] Call trace: [ 43.018078] dump_backtrace+0x0/0x1e8 [ 43.021727] show_stack+0x14/0x20 [ 43.025031] dump_stack+0xc4/0xfc [ 43.028335] print_address_description+0x178/0x270 [ 43.033113] __kasan_report+0x164/0x1b8 [ 43.036936] kasan_report+0xc/0x18 [ 43.040325] __asan_load8+0x84/0xa8 [ 43.043801] __bitmap_weight+0x48/0xb0 [ 43.047552] hclge_init_ae_dev+0x988/0x1e78 [hclge] [ 43.052418] hnae3_register_ae_dev+0xcc/0x278 [hnae3] [ 43.057467] hns3_probe+0xe0/0x120 [hns3] [ 43.061464] local_pci_probe+0x74/0xf0 [ 43.065200] work_for_cpu_fn+0x2c/0x48 [ 43.068937] process_one_work+0x3c0/0x878 [ 43.072934] worker_thread+0x400/0x670 [ 43.076670] kthread+0x1b0/0x1b8 [ 43.079885] ret_from_fork+0x10/0x18 [ 43.083446] [ 43.084925] The buggy address belongs to the variable: [ 43.090052] numa_distance+0x30/0x40 [ 43.093613] [ 43.095091] Memory state around the buggy address: [ 43.099870] ffff20008cdf8680: fa fa fa fa 04 fa fa fa fa fa fa fa 00 00 fa fa [ 43.107078] ffff20008cdf8700: fa fa fa fa 04 fa fa fa fa fa fa fa 00 fa fa fa [ 43.114286] >ffff20008cdf8780: fa fa fa fa 00 00 00 00 00 00 00 00 fa fa fa fa [ 43.121494] ^ [ 43.125230] ffff20008cdf8800: 01 fa fa fa fa fa fa fa 04 fa fa fa fa fa fa fa [ 43.132439] ffff20008cdf8880: fa fa fa fa fa fa fa fa 00 00 fa fa fa fa fa fa [ 43.139646] ================================================================== This patch checks node id with the below case before returning node_to_cpumask_map[node]: 1. if node_id >= nr_node_ids, return cpu_none_mask 2. if node_id < 0, return cpu_online_mask 3. if node_to_cpumask_map[node_id] is NULL, return cpu_online_mask Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com> --- arch/arm64/include/asm/numa.h | 6 ++++++ arch/arm64/mm/numa.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm64/include/asm/numa.h b/arch/arm64/include/asm/numa.h index 626ad01..65a0ef6 100644 --- a/arch/arm64/include/asm/numa.h +++ b/arch/arm64/include/asm/numa.h @@ -25,6 +25,12 @@ const struct cpumask *cpumask_of_node(int node); /* Returns a pointer to the cpumask of CPUs on Node 'node'. */ static inline const struct cpumask *cpumask_of_node(int node) { + if (node >= nr_node_ids) + return cpu_none_mask; + + if (node < 0 || !node_to_cpumask_map[node]) + return cpu_online_mask; + return node_to_cpumask_map[node]; } #endif diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c index 4f241cc..7eca267 100644 --- a/arch/arm64/mm/numa.c +++ b/arch/arm64/mm/numa.c @@ -49,7 +49,7 @@ const struct cpumask *cpumask_of_node(int node) if (WARN_ON(node >= nr_node_ids)) return cpu_none_mask; - if (WARN_ON(node_to_cpumask_map[node] == NULL)) + if (WARN_ON(node < 0 || !node_to_cpumask_map[node])) return cpu_online_mask; return node_to_cpumask_map[node]; -- 2.8.1
next prev parent reply index Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-31 5:58 [PATCH v2 0/9] check the node id consistently across different arches Yunsheng Lin 2019-08-31 5:58 ` Yunsheng Lin [this message] 2019-08-31 5:58 ` [PATCH v2 2/9] x86: numa: check the node id consistently for x86 Yunsheng Lin 2019-08-31 8:55 ` Peter Zijlstra 2019-08-31 10:09 ` Yunsheng Lin 2019-08-31 16:12 ` Peter Zijlstra 2019-09-01 4:45 ` Something about loongson_llsc_mb 陈华才 [not found] ` <2019090410032559707512@loongson.cn> 2019-09-04 9:21 ` Peter Zijlstra 2019-09-04 10:04 ` Peter Zijlstra 2019-09-04 12:57 ` Huang Pei 2019-09-02 5:46 ` [PATCH v2 2/9] x86: numa: check the node id consistently for x86 Yunsheng Lin 2019-09-02 7:25 ` Peter Zijlstra 2019-09-02 12:25 ` Yunsheng Lin 2019-09-02 12:56 ` Peter Zijlstra 2019-09-02 18:22 ` Ingo Molnar 2019-09-02 19:14 ` Peter Zijlstra 2019-09-03 6:19 ` Yunsheng Lin 2019-09-03 7:11 ` Peter Zijlstra 2019-09-03 8:31 ` Yunsheng Lin 2019-09-02 18:17 ` Ingo Molnar 2019-09-03 7:53 ` [PATCH] x86/mm: Fix cpumask_of_node() error condition Peter Zijlstra 2019-08-31 5:58 ` [PATCH v2 3/9] alpha: numa: check the node id consistently for alpha Yunsheng Lin 2019-08-31 5:58 ` [PATCH v2 4/9] powerpc: numa: check the node id consistently for powerpc Yunsheng Lin 2019-08-31 5:58 ` [PATCH v2 5/9] s390: numa: check the node id consistently for s390 Yunsheng Lin 2019-09-02 4:05 ` kbuild test robot 2019-08-31 5:58 ` [PATCH v2 6/9] sh: numa: check the node id consistently for sh Yunsheng Lin 2019-08-31 5:58 ` [PATCH v2 7/9] sparc64: numa: check the node id consistently for sparc64 Yunsheng Lin 2019-08-31 6:53 ` David Miller 2019-08-31 8:57 ` Yunsheng Lin 2019-08-31 20:02 ` David Miller 2019-09-02 6:08 ` Yunsheng Lin 2019-09-02 15:17 ` David Miller 2019-08-31 5:58 ` [PATCH v2 8/9] mips: numa: check the node id consistently for mips ip27 Yunsheng Lin 2019-08-31 5:58 ` [PATCH v2 9/9] mips: numa: check the node id consistently for mips loongson64 Yunsheng Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1567231103-13237-2-git-send-email-linyunsheng@huawei.com \ --to=linyunsheng@huawei.com \ --cc=akpm@linux-foundation.org \ --cc=anshuman.khandual@arm.com \ --cc=axboe@kernel.dk \ --cc=benh@kernel.crashing.org \ --cc=borntraeger@de.ibm.com \ --cc=bp@alien8.de \ --cc=cai@lca.pw \ --cc=catalin.marinas@arm.com \ --cc=chenhc@lemote.com \ --cc=dalias@libc.org \ --cc=dave.hansen@linux.intel.com \ --cc=davem@davemloft.net \ --cc=dledford@redhat.com \ --cc=gor@linux.ibm.com \ --cc=heiko.carstens@de.ibm.com \ --cc=hpa@zytor.com \ --cc=ink@jurassic.park.msu.ru \ --cc=jeffrey.t.kirsher@intel.com \ --cc=jhogan@kernel.org \ --cc=jiaxun.yang@flygoat.com \ --cc=len.brown@intel.com \ --cc=linux-alpha@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=luto@kernel.org \ --cc=mattst88@gmail.com \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=mwb@linux.vnet.ibm.com \ --cc=naveen.n.rao@linux.vnet.ibm.com \ --cc=nfont@linux.vnet.ibm.com \ --cc=paul.burton@mips.com \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ --cc=ralf@linux-mips.org \ --cc=robin.murphy@arm.com \ --cc=rppt@linux.ibm.com \ --cc=rth@twiddle.net \ --cc=sparclinux@vger.kernel.org \ --cc=tbogendoerfer@suse.de \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ --cc=x86@kernel.org \ --cc=ysato@users.sourceforge.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-MIPS Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \ linux-mips@vger.kernel.org public-inbox-index linux-mips Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips AGPL code for this site: git clone https://public-inbox.org/public-inbox.git